From: Jakub Kicinski <kuba@kernel.org>
To: Wells Lu <wellslutw@gmail.com>
Cc: davem@davemloft.net, robh+dt@kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
p.zabel@pengutronix.de, pabeni@redhat.com, krzk+dt@kernel.org,
roopa@nvidia.com, andrew@lunn.ch, edumazet@google.com,
wells.lu@sunplus.com
Subject: Re: [PATCH net-next v7 2/2] net: ethernet: Add driver for Sunplus SP7021
Date: Mon, 11 Apr 2022 13:34:57 -0700 [thread overview]
Message-ID: <20220411133457.1c783e4c@kernel.org> (raw)
In-Reply-To: <1649697088-7812-3-git-send-email-wellslutw@gmail.com>
On Tue, 12 Apr 2022 01:11:28 +0800 Wells Lu wrote:
> +config NET_VENDOR_SUNPLUS
> + bool "Sunplus devices"
> + default y
> + depends on ARCH_SUNPLUS || COMPILE_TEST
> + help
> + If you have a network (Ethernet) card belonging to this
> + class, say Y here.
> +
> + Note that the answer to this question doesn't directly
> + affect the kernel: saying N will just cause the configurator
> + to skip all the questions about Sunplus cards. If you say Y,
> + you will be asked for your specific card in the following
> + questions.
> +
> +if NET_VENDOR_SUNPLUS
> +
> +config SP7021_EMAC
> + tristate "Sunplus Dual 10M/100M Ethernet devices"
> + depends on SOC_SP7021 || COMPILE_TEST
> + select PHYLIB
> + select PINCTRL_SPPCTL
> + select COMMON_CLK_SP7021
> + select RESET_SUNPLUS
> + select NVMEM_SUNPLUS_OCOTP
> + help
> + If you have Sunplus dual 10M/100M Ethernet devices, say Y.
> + The network device creates two net-device interfaces.
> + To compile this driver as a module, choose M here. The
> + module will be called sp7021_emac.
x86 allmodconfig is not happy about it:
WARNING: unmet direct dependencies detected for PINCTRL_SPPCTL
Depends on [n]: PINCTRL [=y] && SOC_SP7021 && OF [=y] && HAS_IOMEM [=y]
Selected by [m]:
- SP7021_EMAC [=m] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_SUNPLUS [=y] && (SOC_SP7021 || COMPILE_TEST [=y])
Please wait at least 24h before reposting.
prev parent reply other threads:[~2022-04-11 20:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 17:11 [PATCH net-next v7 0/2] This is a patch series for Ethernet driver of Sunplus SP7021 SoC Wells Lu
2022-04-11 17:11 ` [PATCH net-next v7 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021 Wells Lu
2022-04-11 17:11 ` [PATCH net-next v7 2/2] net: ethernet: Add driver " Wells Lu
2022-04-11 20:34 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411133457.1c783e4c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=roopa@nvidia.com \
--cc=wells.lu@sunplus.com \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.