From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD918C433F5 for ; Tue, 12 Apr 2022 06:21:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232526AbiDLGXp (ORCPT ); Tue, 12 Apr 2022 02:23:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229659AbiDLGXo (ORCPT ); Tue, 12 Apr 2022 02:23:44 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFE8C35269; Mon, 11 Apr 2022 23:21:25 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id CD9FC68AA6; Tue, 12 Apr 2022 08:21:20 +0200 (CEST) Date: Tue, 12 Apr 2022 08:21:20 +0200 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: Re: [PATCH 10/15] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction Message-ID: <20220412062120.GA7796@lst.de> References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Wed, Apr 06, 2022 at 08:25:32PM -0400, Konrad Rzeszutek Wilk wrote: > > diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c > > index c5228f4969eb2..3b4045d508ec8 100644 > > --- a/arch/powerpc/platforms/pseries/svm.c > > +++ b/arch/powerpc/platforms/pseries/svm.c > > @@ -28,7 +28,7 @@ static int __init init_svm(void) > > * need to use the SWIOTLB buffer for DMA even if dma_capable() says > > * otherwise. > > */ > > - swiotlb_force = SWIOTLB_FORCE; > > + ppc_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_FORCE; > > This is the only place you set the ppc_swiotlb_flags.. so I wonder why > the '|=' instead of just '=' ? Preparing for setting others and not clobbering the value. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Tue, 12 Apr 2022 06:21:20 +0000 Subject: Re: [PATCH 10/15] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction Message-Id: <20220412062120.GA7796@lst.de> List-Id: References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-11-hch@lst.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Konrad Rzeszutek Wilk Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org On Wed, Apr 06, 2022 at 08:25:32PM -0400, Konrad Rzeszutek Wilk wrote: > > diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c > > index c5228f4969eb2..3b4045d508ec8 100644 > > --- a/arch/powerpc/platforms/pseries/svm.c > > +++ b/arch/powerpc/platforms/pseries/svm.c > > @@ -28,7 +28,7 @@ static int __init init_svm(void) > > * need to use the SWIOTLB buffer for DMA even if dma_capable() says > > * otherwise. > > */ > > - swiotlb_force = SWIOTLB_FORCE; > > + ppc_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_FORCE; > > This is the only place you set the ppc_swiotlb_flags.. so I wonder why > the '|=' instead of just '=' ? Preparing for setting others and not clobbering the value. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A05E9C433F5 for ; Tue, 12 Apr 2022 06:21:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4114F60DE5; Tue, 12 Apr 2022 06:21:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mcxCpg6NPCDY; Tue, 12 Apr 2022 06:21:31 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id F1DD360F39; Tue, 12 Apr 2022 06:21:30 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B2E20C0082; Tue, 12 Apr 2022 06:21:30 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id B94A4C002F for ; Tue, 12 Apr 2022 06:21:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A07FE83E7B for ; Tue, 12 Apr 2022 06:21:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KGcdEWcruodz for ; Tue, 12 Apr 2022 06:21:27 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.osuosl.org (Postfix) with ESMTPS id B22588348C for ; Tue, 12 Apr 2022 06:21:27 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id CD9FC68AA6; Tue, 12 Apr 2022 08:21:20 +0200 (CEST) Date: Tue, 12 Apr 2022 08:21:20 +0200 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Subject: Re: [PATCH 10/15] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction Message-ID: <20220412062120.GA7796@lst.de> References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-11-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Cc: linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org, Christoph Hellwig , linux-s390@vger.kernel.org, Stefano Stabellini , x86@kernel.org, tboot-devel@lists.sourceforge.net, xen-devel@lists.xenproject.org, David Woodhouse , Tom Lendacky , Anshuman Khandual , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, Juergen Gross , linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org, iommu@lists.linux-foundation.org, Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Apr 06, 2022 at 08:25:32PM -0400, Konrad Rzeszutek Wilk wrote: > > diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c > > index c5228f4969eb2..3b4045d508ec8 100644 > > --- a/arch/powerpc/platforms/pseries/svm.c > > +++ b/arch/powerpc/platforms/pseries/svm.c > > @@ -28,7 +28,7 @@ static int __init init_svm(void) > > * need to use the SWIOTLB buffer for DMA even if dma_capable() says > > * otherwise. > > */ > > - swiotlb_force = SWIOTLB_FORCE; > > + ppc_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_FORCE; > > This is the only place you set the ppc_swiotlb_flags.. so I wonder why > the '|=' instead of just '=' ? Preparing for setting others and not clobbering the value. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5690C433F5 for ; Tue, 12 Apr 2022 06:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XASgtAgdHqsGc0anKVrqO+vQdUMHiIrbUhSs5KqxsHU=; b=2udiSx+0btXqnp 9LZ0e1q8cq1MY4FKXznTLo5X7pMtMwKDOjBpzrs4AhpM3nkngCjGoAv5ryziCrcszXkl0P3K41R5a 6SJeEHyzDl/Xdmysu+M7a0zltbNrdB0ZaRMavMJl5CIbwC6c7K9cj2UyBwGezp7puM88owdkfCs3p xLx2ZVnd8LO1n6LKAMPvBrU7bel9RaOT5AgWJcbvWYtMK3O+YJcvexFEUa3/HRc9cdsketeqDkTvi gXS+242KhCbhd+4EvJplG6vIXmrB6eGz5a2uQvxViL4EXWAscIUpYmU8GMwWz/SBURwgqSwvlkLgK 4oAwQVaHjvhOTRuCyohw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ne9uF-00BqbJ-Ey; Tue, 12 Apr 2022 06:21:39 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ne9u4-00BqYA-0Q; Tue, 12 Apr 2022 06:21:29 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id CD9FC68AA6; Tue, 12 Apr 2022 08:21:20 +0200 (CEST) Date: Tue, 12 Apr 2022 08:21:20 +0200 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: Re: [PATCH 10/15] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction Message-ID: <20220412062120.GA7796@lst.de> References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-11-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_232128_235380_9F0BBCD8 X-CRM114-Status: GOOD ( 16.90 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Apr 06, 2022 at 08:25:32PM -0400, Konrad Rzeszutek Wilk wrote: > > diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c > > index c5228f4969eb2..3b4045d508ec8 100644 > > --- a/arch/powerpc/platforms/pseries/svm.c > > +++ b/arch/powerpc/platforms/pseries/svm.c > > @@ -28,7 +28,7 @@ static int __init init_svm(void) > > * need to use the SWIOTLB buffer for DMA even if dma_capable() says > > * otherwise. > > */ > > - swiotlb_force = SWIOTLB_FORCE; > > + ppc_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_FORCE; > > This is the only place you set the ppc_swiotlb_flags.. so I wonder why > the '|=' instead of just '=' ? Preparing for setting others and not clobbering the value. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4313C43217 for ; Tue, 12 Apr 2022 06:21:55 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Kcwc170Qdz3bcQ for ; Tue, 12 Apr 2022 16:21:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KcwbZ35h4z2xSM for ; Tue, 12 Apr 2022 16:21:28 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id CD9FC68AA6; Tue, 12 Apr 2022 08:21:20 +0200 (CEST) Date: Tue, 12 Apr 2022 08:21:20 +0200 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Subject: Re: [PATCH 10/15] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction Message-ID: <20220412062120.GA7796@lst.de> References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org, Christoph Hellwig , linux-s390@vger.kernel.org, Stefano Stabellini , Joerg Roedel , x86@kernel.org, tboot-devel@lists.sourceforge.net, xen-devel@lists.xenproject.org, David Woodhouse , Tom Lendacky , Anshuman Khandual , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, Juergen Gross , linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org, iommu@lists.linux-foundation.org, Robin Murphy , Lu Baolu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Apr 06, 2022 at 08:25:32PM -0400, Konrad Rzeszutek Wilk wrote: > > diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c > > index c5228f4969eb2..3b4045d508ec8 100644 > > --- a/arch/powerpc/platforms/pseries/svm.c > > +++ b/arch/powerpc/platforms/pseries/svm.c > > @@ -28,7 +28,7 @@ static int __init init_svm(void) > > * need to use the SWIOTLB buffer for DMA even if dma_capable() says > > * otherwise. > > */ > > - swiotlb_force = SWIOTLB_FORCE; > > + ppc_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_FORCE; > > This is the only place you set the ppc_swiotlb_flags.. so I wonder why > the '|=' instead of just '=' ? Preparing for setting others and not clobbering the value. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94785C433EF for ; Tue, 12 Apr 2022 06:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h6K1/IUNqsecNaoCnxdPaVPxOrnG/68vTA8dGoMvKbM=; b=Ams2vC/6atLr82 in4ZTbS+h7nLekzcvnKUiKhbgLQjOdBsoZca/HmtoMWJG0TveZ3oSuix+90HTies1Ov7n95TzR7cN GK6SA60bSXk9hAz6EUGX7JeJT3jWw4Isxwsd6I/mxKy8cYMrwPrzmLdxrcI9nIyHvbxn6NmE3U9IR OA4wVeSpJqiRB/YxAhzqJJfJK/RVez09ixk2hwXjSmBmjiS58BMrnf43+AELPQ/wD3H2lVW18h4xv SKHFi2UusTCc1FrK4FKjCdvQqlb6BH7uqkJI0AHcEiFjb4ClMiYtTox4XCa3wSSRl94kRbXBjcJOk V//PqhqCC+KajT31pYPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ne9u7-00BqZa-ME; Tue, 12 Apr 2022 06:21:31 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ne9u4-00BqYA-0Q; Tue, 12 Apr 2022 06:21:29 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id CD9FC68AA6; Tue, 12 Apr 2022 08:21:20 +0200 (CEST) Date: Tue, 12 Apr 2022 08:21:20 +0200 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: Re: [PATCH 10/15] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction Message-ID: <20220412062120.GA7796@lst.de> References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-11-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_232128_235380_9F0BBCD8 X-CRM114-Status: GOOD ( 16.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 06, 2022 at 08:25:32PM -0400, Konrad Rzeszutek Wilk wrote: > > diff --git a/arch/powerpc/platforms/pseries/svm.c b/arch/powerpc/platforms/pseries/svm.c > > index c5228f4969eb2..3b4045d508ec8 100644 > > --- a/arch/powerpc/platforms/pseries/svm.c > > +++ b/arch/powerpc/platforms/pseries/svm.c > > @@ -28,7 +28,7 @@ static int __init init_svm(void) > > * need to use the SWIOTLB buffer for DMA even if dma_capable() says > > * otherwise. > > */ > > - swiotlb_force = SWIOTLB_FORCE; > > + ppc_swiotlb_flags |= SWIOTLB_ANY | SWIOTLB_FORCE; > > This is the only place you set the ppc_swiotlb_flags.. so I wonder why > the '|=' instead of just '=' ? Preparing for setting others and not clobbering the value. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel