From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <simon.horman@corigine.com>,
Dylan Muller <dylan.muller@corigine.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, oss-drivers@corigine.com
Subject: Re: [PATCH net-next] nfp: update nfp_X logging definitions
Date: Tue, 12 Apr 2022 08:46:59 -0700 [thread overview]
Message-ID: <20220412084659.60838d73@kernel.org> (raw)
In-Reply-To: <20220412152600.190317-1-simon.horman@corigine.com>
On Tue, 12 Apr 2022 17:26:00 +0200 Simon Horman wrote:
> From: Dylan Muller <dylan.muller@corigine.com>
>
> Previously it was not possible to determine which code path was responsible
> for generating a certain message after a call to the nfp_X messaging
> definitions for cases of duplicate strings. We therefore modify nfp_err,
> nfp_warn, nfp_info, nfp_dbg and nfp_printk to print the corresponding file
> and line number where the nfp_X definition is used.
>
> Signed-off-by: Dylan Muller <dylan.muller@corigine.com>
> Signed-off-by: Simon Horman <simon.horman@corigine.com>
Examples? The messages are usually unique. Unless you also print
the kernel version the line numbers are meaningless in real life.
next prev parent reply other threads:[~2022-04-12 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 15:26 [PATCH net-next] nfp: update nfp_X logging definitions Simon Horman
2022-04-12 15:46 ` Jakub Kicinski [this message]
2022-04-13 13:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412084659.60838d73@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dylan.muller@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.