From: Philippe Schenker <dev@pschenker.ch>
To: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>
Cc: linux@leemhuis.info, Philippe Schenker <dev@pschenker.ch>,
"David S. Miller" <davem@davemloft.net>,
Deren Wu <deren.wu@mediatek.com>,
Jakub Kicinski <kuba@kernel.org>, Kalle Valo <kvalo@kernel.org>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
YN Chen <YN.Chen@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
netdev@vger.kernel.org
Subject: [PATCH] Revert "mt76: mt7921: enable aspm by default"
Date: Tue, 12 Apr 2022 11:04:14 +0200 [thread overview]
Message-ID: <20220412090415.17541-1-dev@pschenker.ch> (raw)
This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
This commit introduces a regression on some systems where the kernel is
crashing in different locations after a reboot was issued.
This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest firmware.
Link: https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/
Signed-off-by: Philippe Schenker <dev@pschenker.ch>
---
drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
index 1a01d025bbe5..59f9ee089389 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
@@ -20,10 +20,6 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
{ },
};
-static bool mt7921_disable_aspm;
-module_param_named(disable_aspm, mt7921_disable_aspm, bool, 0644);
-MODULE_PARM_DESC(disable_aspm, "disable PCI ASPM support");
-
static void
mt7921_rx_poll_complete(struct mt76_dev *mdev, enum mt76_rxq_id q)
{
@@ -280,8 +276,7 @@ static int mt7921_pci_probe(struct pci_dev *pdev,
if (ret)
goto err_free_pci_vec;
- if (mt7921_disable_aspm)
- mt76_pci_disable_aspm(pdev);
+ mt76_pci_disable_aspm(pdev);
mdev = mt76_alloc_device(&pdev->dev, sizeof(*dev), &mt7921_ops,
&drv_ops);
--
2.35.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Philippe Schenker <dev@pschenker.ch>
To: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>
Cc: linux@leemhuis.info, Philippe Schenker <dev@pschenker.ch>,
"David S. Miller" <davem@davemloft.net>,
Deren Wu <deren.wu@mediatek.com>,
Jakub Kicinski <kuba@kernel.org>, Kalle Valo <kvalo@kernel.org>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
YN Chen <YN.Chen@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
netdev@vger.kernel.org
Subject: [PATCH] Revert "mt76: mt7921: enable aspm by default"
Date: Tue, 12 Apr 2022 11:04:14 +0200 [thread overview]
Message-ID: <20220412090415.17541-1-dev@pschenker.ch> (raw)
This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
This commit introduces a regression on some systems where the kernel is
crashing in different locations after a reboot was issued.
This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest firmware.
Link: https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/
Signed-off-by: Philippe Schenker <dev@pschenker.ch>
---
drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
index 1a01d025bbe5..59f9ee089389 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
@@ -20,10 +20,6 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
{ },
};
-static bool mt7921_disable_aspm;
-module_param_named(disable_aspm, mt7921_disable_aspm, bool, 0644);
-MODULE_PARM_DESC(disable_aspm, "disable PCI ASPM support");
-
static void
mt7921_rx_poll_complete(struct mt76_dev *mdev, enum mt76_rxq_id q)
{
@@ -280,8 +276,7 @@ static int mt7921_pci_probe(struct pci_dev *pdev,
if (ret)
goto err_free_pci_vec;
- if (mt7921_disable_aspm)
- mt76_pci_disable_aspm(pdev);
+ mt76_pci_disable_aspm(pdev);
mdev = mt76_alloc_device(&pdev->dev, sizeof(*dev), &mt7921_ops,
&drv_ops);
--
2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Philippe Schenker <dev@pschenker.ch>
To: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>
Cc: linux@leemhuis.info, Philippe Schenker <dev@pschenker.ch>,
"David S. Miller" <davem@davemloft.net>,
Deren Wu <deren.wu@mediatek.com>,
Jakub Kicinski <kuba@kernel.org>, Kalle Valo <kvalo@kernel.org>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
YN Chen <YN.Chen@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
netdev@vger.kernel.org
Subject: [PATCH] Revert "mt76: mt7921: enable aspm by default"
Date: Tue, 12 Apr 2022 11:04:14 +0200 [thread overview]
Message-ID: <20220412090415.17541-1-dev@pschenker.ch> (raw)
This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
This commit introduces a regression on some systems where the kernel is
crashing in different locations after a reboot was issued.
This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest firmware.
Link: https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/
Signed-off-by: Philippe Schenker <dev@pschenker.ch>
---
drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
index 1a01d025bbe5..59f9ee089389 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
@@ -20,10 +20,6 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
{ },
};
-static bool mt7921_disable_aspm;
-module_param_named(disable_aspm, mt7921_disable_aspm, bool, 0644);
-MODULE_PARM_DESC(disable_aspm, "disable PCI ASPM support");
-
static void
mt7921_rx_poll_complete(struct mt76_dev *mdev, enum mt76_rxq_id q)
{
@@ -280,8 +276,7 @@ static int mt7921_pci_probe(struct pci_dev *pdev,
if (ret)
goto err_free_pci_vec;
- if (mt7921_disable_aspm)
- mt76_pci_disable_aspm(pdev);
+ mt76_pci_disable_aspm(pdev);
mdev = mt76_alloc_device(&pdev->dev, sizeof(*dev), &mt7921_ops,
&drv_ops);
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2022-04-12 9:05 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 9:04 Philippe Schenker [this message]
2022-04-12 9:04 ` [PATCH] Revert "mt76: mt7921: enable aspm by default" Philippe Schenker
2022-04-12 9:04 ` Philippe Schenker
2022-04-12 9:37 ` Kalle Valo
2022-04-12 9:37 ` Kalle Valo
2022-04-12 9:37 ` Kalle Valo
2022-04-12 9:55 ` Thorsten Leemhuis
2022-04-12 9:55 ` Thorsten Leemhuis
2022-04-12 9:55 ` Thorsten Leemhuis
2022-04-12 10:33 ` Kalle Valo
2022-04-12 10:33 ` Kalle Valo
2022-04-12 10:33 ` Kalle Valo
2022-04-12 10:36 ` Kalle Valo
2022-04-12 10:36 ` Kalle Valo
2022-04-12 10:36 ` Kalle Valo
2022-04-27 7:32 ` Thorsten Leemhuis
2022-04-27 7:32 ` Thorsten Leemhuis
2022-04-27 7:32 ` Thorsten Leemhuis
2022-04-12 11:06 ` Deren Wu
2022-04-12 11:06 ` Deren Wu
2022-04-12 11:06 ` Deren Wu
2022-04-12 12:30 ` Philippe Schenker
2022-04-12 12:30 ` Philippe Schenker
2022-04-12 12:30 ` Philippe Schenker
2022-04-12 12:45 ` Kalle Valo
2022-04-12 12:45 ` Kalle Valo
2022-04-12 12:45 ` Kalle Valo
2022-06-01 8:28 ` Philippe Schenker
2022-06-01 8:28 ` Philippe Schenker
2022-06-01 8:28 ` Philippe Schenker
2022-06-01 8:58 ` Kalle Valo
2022-06-01 8:58 ` Kalle Valo
2022-06-01 8:58 ` Kalle Valo
2022-06-01 16:55 ` Deren Wu
2022-06-01 16:55 ` Deren Wu
2022-06-01 16:55 ` Deren Wu
2022-06-02 10:00 ` Philippe Schenker
2022-06-02 10:00 ` Philippe Schenker
2022-06-02 10:00 ` Philippe Schenker
[not found] <e93aef5c9f8a97efe23cfb5892f78f919ce328e7.camel@pschenker.ch--annotate>
2022-06-01 22:23 ` sean.wang
2022-06-01 22:23 ` sean.wang
2022-06-01 22:23 ` sean.wang
2022-06-02 8:44 ` Philippe Schenker
2022-06-02 8:44 ` Philippe Schenker
2022-06-02 8:44 ` Philippe Schenker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412090415.17541-1-dev@pschenker.ch \
--to=dev@pschenker.ch \
--cc=YN.Chen@mediatek.com \
--cc=davem@davemloft.net \
--cc=deren.wu@mediatek.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.