From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 2/6] staging: r8188eu: rename parameter of block_write()
Date: Tue, 12 Apr 2022 20:57:50 +0200 [thread overview]
Message-ID: <20220412185754.8695-3-straube.linux@gmail.com> (raw)
In-Reply-To: <20220412185754.8695-1-straube.linux@gmail.com>
Rename the parameter buffSize of block_write() to avoid camel case.
buffSize -> size
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/core/rtw_fw.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_fw.c b/drivers/staging/r8188eu/core/rtw_fw.c
index 0905384bafc7..5f59acfd8b5d 100644
--- a/drivers/staging/r8188eu/core/rtw_fw.c
+++ b/drivers/staging/r8188eu/core/rtw_fw.c
@@ -71,7 +71,7 @@ static void fw_download_enable(struct adapter *padapter, bool enable)
}
}
-static int block_write(struct adapter *padapter, void *buffer, u32 buffSize)
+static int block_write(struct adapter *padapter, void *buffer, u32 size)
{
int ret = _SUCCESS;
u32 blockSize_p1 = 4; /* (Default) Phase #1 : PCI muse use 4-byte write to download FW */
@@ -85,8 +85,8 @@ static int block_write(struct adapter *padapter, void *buffer, u32 buffSize)
blockSize_p1 = MAX_REG_BLOCK_SIZE;
/* 3 Phase #1 */
- blockCount_p1 = buffSize / blockSize_p1;
- remainSize_p1 = buffSize % blockSize_p1;
+ blockCount_p1 = size / blockSize_p1;
+ remainSize_p1 = size % blockSize_p1;
for (i = 0; i < blockCount_p1; i++) {
ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + i * blockSize_p1), blockSize_p1, (bufferPtr + i * blockSize_p1));
--
2.35.1
next prev parent reply other threads:[~2022-04-12 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 18:57 [PATCH 0/6] staging: r8188eu: clean up block_write() in rtw_fw.c Michael Straube
2022-04-12 18:57 ` [PATCH 1/6] staging: r8188eu: correct macro spelling mistake Michael Straube
2022-04-12 18:57 ` Michael Straube [this message]
2022-04-13 6:53 ` [PATCH 2/6] staging: r8188eu: rename parameter of block_write() Greg KH
2022-04-13 6:54 ` Greg KH
2022-04-12 18:57 ` [PATCH 3/6] staging: r8188eu: change void parameters to u8 Michael Straube
2022-04-12 18:57 ` [PATCH 4/6] staging: r8188eu: reduce variables in block_write() Michael Straube
2022-04-12 18:57 ` [PATCH 5/6] staging: r8188eu: remove unneeded initializations Michael Straube
2022-04-12 18:57 ` [PATCH 6/6] staging: r8188eu: clean up long lines in block_write() Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412185754.8695-3-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.