Re: [PATCH v2 1/2] vdpa: Add support for querying vendor statistics

From: kernel test robot <lkp@intel.com>
To: Eli Cohen <elic@nvidia.com>, mst@redhat.com, jasowang@redhat.com
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, si-wei.liu@oracle.com,
	Eli Cohen <elic@nvidia.com>
Subject: Re: [PATCH v2 1/2] vdpa: Add support for querying vendor statistics
Date: Wed, 13 Apr 2022 00:28:42 +0800	[thread overview]
Message-ID: <202204130003.fROyiuxA-lkp@intel.com> (raw)
In-Reply-To: <20220412130402.46945-2-elic@nvidia.com>

Hi Eli,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.18-rc2 next-20220412]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Eli-Cohen/Show-statistics-for-a-vdpa-device/20220412-212129
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e
config: i386-randconfig-a004-20220411 (https://download.01.org/0day-ci/archive/20220413/202204130003.fROyiuxA-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fe2478d44e4f7f191c43fef629ac7a23d0251e72)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/813a1bf827634a8d7e148b133e2849fac37819cd
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Eli-Cohen/Show-statistics-for-a-vdpa-device/20220412-212129
        git checkout 813a1bf827634a8d7e148b133e2849fac37819cd
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/usb/typec/ drivers/vdpa/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/vdpa/vdpa.c:1122:61: warning: implicit conversion from 'int' to 's16' (aka 'short') changes value from 65535 to -1 [-Wconstant-conversion]
           [VDPA_ATTR_DEV_QUEUE_INDEX] = NLA_POLICY_RANGE(NLA_U32, 0, 65535),
                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
   include/net/netlink.h:396:9: note: expanded from macro 'NLA_POLICY_RANGE'
           .max = _max                                     \
                  ^~~~
   1 warning generated.

vim +1122 drivers/vdpa/vdpa.c

  1114	
  1115	static const struct nla_policy vdpa_nl_policy[VDPA_ATTR_MAX + 1] = {
  1116		[VDPA_ATTR_MGMTDEV_BUS_NAME] = { .type = NLA_NUL_STRING },
  1117		[VDPA_ATTR_MGMTDEV_DEV_NAME] = { .type = NLA_STRING },
  1118		[VDPA_ATTR_DEV_NAME] = { .type = NLA_STRING },
  1119		[VDPA_ATTR_DEV_NET_CFG_MACADDR] = NLA_POLICY_ETH_ADDR,
  1120		/* virtio spec 1.1 section 5.1.4.1 for valid MTU range */
  1121		[VDPA_ATTR_DEV_NET_CFG_MTU] = NLA_POLICY_MIN(NLA_U16, 68),
> 1122		[VDPA_ATTR_DEV_QUEUE_INDEX] = NLA_POLICY_RANGE(NLA_U32, 0, 65535),
  1123	};
  1124	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp