All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: aliya-rahmani <aliyarahmani786@gmail.com>
Cc: tomm.merciai@gmail.com, gregkh@linuxfoundation.org,
	linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '('
Date: Wed, 13 Apr 2022 10:51:31 +0300	[thread overview]
Message-ID: <20220413075131.GH3293@kadam> (raw)
In-Reply-To: <20220413073545.14666-1-aliyarahmani786@gmail.com>

On Wed, Apr 13, 2022 at 01:05:45PM +0530, aliya-rahmani wrote:
> From: Aliya Rahmani <aliyarahmani786@gmail.com>
> 
> Removed indentation to fix the checkpatch error that lines should not
> end with a '('.
> 
> Signed-off-by: Aliya Rahmani <aliyarahmani786@gmail.com>
> 
> ---
>  drivers/staging/vt6655/rxtx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 53506e242a96..dce9d87d2363 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -569,8 +569,7 @@ s_uFillDataHead(
>  
>  static
>  void
> -s_vFillRTSHead(
> -	struct vnt_private *pDevice,
> +s_vFillRTSHead(struct vnt_private *pDevice,
>  	unsigned char byPktType,

Indent these lines as well and move the ) forward.

s_vFillRTSHead(struct vnt_private *pDevice,
	       unsigned char byPktType,
	       ...
	       unsigned char byFBOption)
{

regards,
dan carpenter


  reply	other threads:[~2022-04-13  7:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13  7:35 [PATCH] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '(' aliya-rahmani
2022-04-13  7:51 ` Dan Carpenter [this message]
2022-04-13  9:06 ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220413075131.GH3293@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=aliyarahmani786@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=tomm.merciai@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.