From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FB97C433EF for ; Wed, 13 Apr 2022 12:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2vwvn7V0brhBsUdgkGpwxBimUEGrHa1GZSh0PZSJCq8=; b=XQXofvUgBGgg96 lHWWHdUvQN2OqUl2Dg3VA1iRa7e51EL882riDy5fZccUUFmylVJT8/OLA60KHNJviu5wqXoeNPui8 papHM2qLVBPry/8TbD4+jm5qHOr8HmHOjhUyXYEpyQgNAy5GCWd/WXmEv925knLK7hv9Az5CaEeF5 T6GqKglFqKRiV2/lREGQOgiU6sBb2ZYlOY8AGd7ngtMRLUK8NvBmpg/GLmzTB4fo7HA75k167V0X7 QBdnDVz8UgzA0++BvwBgU7dzrLA366P9lZ4NYkAYhCAKuWNRtBj0Y/p2KClw9FKEgtLV9aiCO719P 1RMhQHrIJHAksjUtSWGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1necaL-0017Ke-Ql; Wed, 13 Apr 2022 12:59:01 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1necaD-0017Gl-Sg for linux-mtd@lists.infradead.org; Wed, 13 Apr 2022 12:58:56 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 79759200012; Wed, 13 Apr 2022 12:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1649854726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/lt5mlGJZcuBVHxRss/04dHWoVmPgHYi8/JWSHvb6Dk=; b=Px+SIUNwXGbqpReLs2RRDVD+hDL8TDHEUwFW5MVebHhxM4E5YWiVny3r5i81UC3drFpHmX E07RVeqIKlSfYAABvYULm/UftBS1eaVN6Slwg8G8HDnarnpiBp2y8f3I8yJM1ByfVo2Dw5 eo4HIQB1iIeH7Qds3q0jVTCPjXy9TPoxOHxf5y5dd4MMvtDIjZ/FrTal95izOwP4lnMJ2u jXPBv0yDW+KReaDFOSUlFmoRnnJOSsW92/WxheuyGc8nFDRJwPZqTjDtFmCIlDNnzYBjro Df10JWWGIWKqLNhUFdVS9U0oaRWZAhBBB8bReMNjZLUSF/XuNsG4Nt2VM1vH8A== Date: Wed, 13 Apr 2022 14:58:43 +0200 From: Miquel Raynal To: Chuanhong Guo Cc: linux-mtd@lists.infradead.org, Richard Weinberger , Vignesh Raghavendra , Patrice Chotard , Boris Brezillon , Christophe Kerello , Mark Brown , Daniel Palmer , linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v2] mtd: spinand: add support for ESMT F50x1G41LB Message-ID: <20220413145843.46a3d9b5@xps13> In-Reply-To: <20220413083824.247136-1-gch981213@gmail.com> References: <20220413083824.247136-1-gch981213@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_055854_231749_DED34F34 X-CRM114-Status: GOOD ( 21.94 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGksCgpnY2g5ODEyMTNAZ21haWwuY29tIHdyb3RlIG9uIFdlZCwgMTMgQXByIDIwMjIgMTY6Mzg6 MTkgKzA4MDA6Cgo+IFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciBFU01UIEY1MEwxRzQxTEIg YW5kIEY1MEQxRzQxTEIuCj4gSXQgc2VlbXMgdGhhdCBFU01UIGxpa2VzIHRvIHVzZSByYW5kb20g SkVERUMgSUQgZnJvbSBvdGhlciB2ZW5kb3JzLgo+IFRoZWlyIDFHIGNoaXBzIHVzZXMgMHhjOCBm cm9tIEdpZ2FEZXZpY2UgYW5kIDJHLzRHIGNoaXBzIHVzZXMgMHgyYyBmcm9tCj4gTWljcm9uLiBG b3IgdGhpcyByZWFzb24sIHRoZSBFU01UIGVudHJ5IGlzIG5hbWVkIGVzbXRfYzggd2l0aCBleHBs aWNpdAo+IEpFREVDIElEIGluIHZhcmlhYmxlIG5hbWUuCj4gCj4gRGF0YXNoZWV0czoKPiBodHRw czovL3d3dy5lc210LmNvbS50dy91cGxvYWQvcGRmL0VTTVQvZGF0YXNoZWV0cy9GNTBMMUc0MUxC KDJNKS5wZGYKPiBodHRwczovL3d3dy5lc210LmNvbS50dy91cGxvYWQvcGRmL0VTTVQvZGF0YXNo ZWV0cy9GNTBEMUc0MUxCKDJNKS5wZGYKPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHVhbmhvbmcgR3Vv IDxnY2g5ODEyMTNAZ21haWwuY29tPgo+IC0tLQo+IFRoaXMgcGF0Y2ggaXMgbWFkZSBwdXJlbHkg YmFzZWQgb24gZGF0YXNoZWV0IGluZm8gd2l0aG91dCB0ZXN0aW5nCj4gb24gYW55IGFjdHVhbCBj aGlwcy4KCkRvIHlvdSBwbGFuIHRvIGdldCBvbmUgb2YgdGhlc2UgYW55IHRpbWUgc29vbj8KCkkg YW0gbm90IHJlYWxseSBjb25maWRlbnQgbWVyZ2luZyBhIDEwMCUgbm9uLXRlc3RlZCBkcml2ZXIg OikKCj4gQ2hhbmdlIHNpbmNlIHYxOiBkcm9wIDB4N2YgcGFkZGluZyBmcm9tIFNQSU5BTkRfSUQu Cj4gCj4gIGRyaXZlcnMvbXRkL25hbmQvc3BpL01ha2VmaWxlIHwgIDIgKy0KPiAgZHJpdmVycy9t dGQvbmFuZC9zcGkvY29yZS5jICAgfCAgMSArCj4gIGRyaXZlcnMvbXRkL25hbmQvc3BpL2VzbXQu YyAgIHwgOTQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9s aW51eC9tdGQvc3BpbmFuZC5oICAgfCAgMSArCj4gIDQgZmlsZXMgY2hhbmdlZCwgOTcgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tdGQv bmFuZC9zcGkvZXNtdC5jCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvc3BpL01h a2VmaWxlIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvTWFrZWZpbGUKPiBpbmRleCA5NjYyYjljMWQ1 YTkuLjdlM2FiOGE5YWVjNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3NwaS9NYWtl ZmlsZQo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvc3BpL01ha2VmaWxlCj4gQEAgLTEsMyArMSwz IEBACj4gICMgU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAKPiAtc3BpbmFuZC1vYmpz IDo9IGNvcmUubyBnaWdhZGV2aWNlLm8gbWFjcm9uaXgubyBtaWNyb24ubyBwYXJhZ29uLm8gdG9z aGliYS5vIHdpbmJvbmQubwo+ICtzcGluYW5kLW9ianMgOj0gY29yZS5vIGVzbXQubyBnaWdhZGV2 aWNlLm8gbWFjcm9uaXgubyBtaWNyb24ubyBwYXJhZ29uLm8gdG9zaGliYS5vIHdpbmJvbmQubwo+ ICBvYmotJChDT05GSUdfTVREX1NQSV9OQU5EKSArPSBzcGluYW5kLm8KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9tdGQvbmFuZC9zcGkvY29yZS5jIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvY29yZS5j Cj4gaW5kZXggZmY4MzM2ODcwYmMwLi42YzVkNzllYzM1MDEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9tdGQvbmFuZC9zcGkvY29yZS5jCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvY29yZS5j Cj4gQEAgLTkyNyw2ICs5MjcsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG5hbmRfb3BzIHNwaW5h bmRfb3BzID0gewo+ICB9Owo+ICAKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBzcGluYW5kX21hbnVm YWN0dXJlciAqc3BpbmFuZF9tYW51ZmFjdHVyZXJzW10gPSB7Cj4gKwkmZXNtdF9jOF9zcGluYW5k X21hbnVmYWN0dXJlciwKPiAgCSZnaWdhZGV2aWNlX3NwaW5hbmRfbWFudWZhY3R1cmVyLAo+ICAJ Jm1hY3Jvbml4X3NwaW5hbmRfbWFudWZhY3R1cmVyLAo+ICAJJm1pY3Jvbl9zcGluYW5kX21hbnVm YWN0dXJlciwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9zcGkvZXNtdC5jIGIvZHJp dmVycy9tdGQvbmFuZC9zcGkvZXNtdC5jCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAw MDAwMDAwMDAwMDAuLmY4NjcxNjMzMjg5Mwo+IC0tLSAvZGV2L251bGwKPiArKysgYi9kcml2ZXJz L210ZC9uYW5kL3NwaS9lc210LmMKPiBAQCAtMCwwICsxLDk0IEBACj4gKy8vIFNQRFgtTGljZW5z ZS1JZGVudGlmaWVyOiBHUEwtMi4wCj4gKy8qCj4gKyAqIEF1dGhvcjoKPiArICoJQ2h1YW5ob25n IEd1byA8Z2NoOTgxMjEzQGdtYWlsLmNvbT4KPiArICovCj4gKwo+ICsjaW5jbHVkZSA8bGludXgv ZGV2aWNlLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9rZXJuZWwuaD4KPiArI2luY2x1ZGUgPGxpbnV4 L210ZC9zcGluYW5kLmg+Cj4gKwo+ICsvKiBFU01UIHVzZXMgR2lnYURldmljZSAweGM4IEpFQ0RF QyBJRCBvbiBzb21lIFNQSSBOQU5EcyAqLwo+ICsjZGVmaW5lIFNQSU5BTkRfTUZSX0VTTVRfQzgJ CQkweGM4CgpXaGF0IGhhcHBlbnMgaWYgdGhlIGdpZ2FkZXZpY2UgZHJpdmVyIHByb2JlcyBmaXJz dD8KCj4gKwo+ICsjZGVmaW5lIEY1MEwyRzQxWEFfRUNDX1NUQVRVU19NQVNLCQlHRU5NQVNLKDYs IDQpCj4gKyNkZWZpbmUgRjUwTDJHNDFYQV9TVEFUVVNfRUNDXzFfM19CSVRGTElQUwkoMSA8PCA0 KQo+ICsjZGVmaW5lIEY1MEwyRzQxWEFfU1RBVFVTX0VDQ180XzZfQklURkxJUFMJKDMgPDwgNCkK PiArI2RlZmluZSBGNTBMMkc0MVhBX1NUQVRVU19FQ0NfN184X0JJVEZMSVBTCSg1IDw8IDQpCj4g KwoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 141B1C433EF for ; Wed, 13 Apr 2022 12:58:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235540AbiDMNBO (ORCPT ); Wed, 13 Apr 2022 09:01:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbiDMNBM (ORCPT ); Wed, 13 Apr 2022 09:01:12 -0400 Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [IPv6:2001:4b98:dc4:8::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 064AC5B3D3 for ; Wed, 13 Apr 2022 05:58:47 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 79759200012; Wed, 13 Apr 2022 12:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1649854726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/lt5mlGJZcuBVHxRss/04dHWoVmPgHYi8/JWSHvb6Dk=; b=Px+SIUNwXGbqpReLs2RRDVD+hDL8TDHEUwFW5MVebHhxM4E5YWiVny3r5i81UC3drFpHmX E07RVeqIKlSfYAABvYULm/UftBS1eaVN6Slwg8G8HDnarnpiBp2y8f3I8yJM1ByfVo2Dw5 eo4HIQB1iIeH7Qds3q0jVTCPjXy9TPoxOHxf5y5dd4MMvtDIjZ/FrTal95izOwP4lnMJ2u jXPBv0yDW+KReaDFOSUlFmoRnnJOSsW92/WxheuyGc8nFDRJwPZqTjDtFmCIlDNnzYBjro Df10JWWGIWKqLNhUFdVS9U0oaRWZAhBBB8bReMNjZLUSF/XuNsG4Nt2VM1vH8A== Date: Wed, 13 Apr 2022 14:58:43 +0200 From: Miquel Raynal To: Chuanhong Guo Cc: linux-mtd@lists.infradead.org, Richard Weinberger , Vignesh Raghavendra , Patrice Chotard , Boris Brezillon , Christophe Kerello , Mark Brown , Daniel Palmer , linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v2] mtd: spinand: add support for ESMT F50x1G41LB Message-ID: <20220413145843.46a3d9b5@xps13> In-Reply-To: <20220413083824.247136-1-gch981213@gmail.com> References: <20220413083824.247136-1-gch981213@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, gch981213@gmail.com wrote on Wed, 13 Apr 2022 16:38:19 +0800: > This patch adds support for ESMT F50L1G41LB and F50D1G41LB. > It seems that ESMT likes to use random JEDEC ID from other vendors. > Their 1G chips uses 0xc8 from GigaDevice and 2G/4G chips uses 0x2c from > Micron. For this reason, the ESMT entry is named esmt_c8 with explicit > JEDEC ID in variable name. >=20 > Datasheets: > https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F50L1G41LB(2M).pdf > https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F50D1G41LB(2M).pdf >=20 > Signed-off-by: Chuanhong Guo > --- > This patch is made purely based on datasheet info without testing > on any actual chips. Do you plan to get one of these any time soon? I am not really confident merging a 100% non-tested driver :) > Change since v1: drop 0x7f padding from SPINAND_ID. >=20 > drivers/mtd/nand/spi/Makefile | 2 +- > drivers/mtd/nand/spi/core.c | 1 + > drivers/mtd/nand/spi/esmt.c | 94 +++++++++++++++++++++++++++++++++++ > include/linux/mtd/spinand.h | 1 + > 4 files changed, 97 insertions(+), 1 deletion(-) > create mode 100644 drivers/mtd/nand/spi/esmt.c >=20 > diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile > index 9662b9c1d5a9..7e3ab8a9aec7 100644 > --- a/drivers/mtd/nand/spi/Makefile > +++ b/drivers/mtd/nand/spi/Makefile > @@ -1,3 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0 > -spinand-objs :=3D core.o gigadevice.o macronix.o micron.o paragon.o tosh= iba.o winbond.o > +spinand-objs :=3D core.o esmt.o gigadevice.o macronix.o micron.o paragon= .o toshiba.o winbond.o > obj-$(CONFIG_MTD_SPI_NAND) +=3D spinand.o > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index ff8336870bc0..6c5d79ec3501 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -927,6 +927,7 @@ static const struct nand_ops spinand_ops =3D { > }; > =20 > static const struct spinand_manufacturer *spinand_manufacturers[] =3D { > + &esmt_c8_spinand_manufacturer, > &gigadevice_spinand_manufacturer, > ¯onix_spinand_manufacturer, > µn_spinand_manufacturer, > diff --git a/drivers/mtd/nand/spi/esmt.c b/drivers/mtd/nand/spi/esmt.c > new file mode 100644 > index 000000000000..f86716332893 > --- /dev/null > +++ b/drivers/mtd/nand/spi/esmt.c > @@ -0,0 +1,94 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Author: > + * Chuanhong Guo > + */ > + > +#include > +#include > +#include > + > +/* ESMT uses GigaDevice 0xc8 JECDEC ID on some SPI NANDs */ > +#define SPINAND_MFR_ESMT_C8 0xc8 What happens if the gigadevice driver probes first? > + > +#define F50L2G41XA_ECC_STATUS_MASK GENMASK(6, 4) > +#define F50L2G41XA_STATUS_ECC_1_3_BITFLIPS (1 << 4) > +#define F50L2G41XA_STATUS_ECC_4_6_BITFLIPS (3 << 4) > +#define F50L2G41XA_STATUS_ECC_7_8_BITFLIPS (5 << 4) > + Thanks, Miqu=C3=A8l