From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
Zhi Wang <zhi.wang.linux@gmail.com>
Subject: Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile
Date: Wed, 13 Apr 2022 13:25:20 -0300 [thread overview]
Message-ID: <20220413162520.GT2120790@nvidia.com> (raw)
In-Reply-To: <20220413161212.GA30300@lst.de>
On Wed, Apr 13, 2022 at 06:12:12PM +0200, Christoph Hellwig wrote:
> On Wed, Apr 13, 2022 at 07:04:54PM +0300, Jani Nikula wrote:
> > > v6:
> > > - Remove the reference of intel_gvt_device_info.(Christoph)
> > > - Refine the save_mmio() function. (Christoph)
> > >
> > > which don't belong in the commit log. It might be worth to fix that
> > > before sending a pull request.
> >
> > I'll just note, without any value judgement, that it is customary in the
> > drm land to do so. They are fine here even if they're not accepted in
> > other subsystems. I'm not going to insist one way or the other.
>
> Ok. Seems very odd to me, but I guess I don't spend enough time in
> drm land to know this particular quirk.
FWIW, I've seen netdev has being doing this too sometimes..
IMHO I prefer maintainers put the Link: headers then we can get the
changelog/etc from lore.
Jason
prev parent reply other threads:[~2022-04-13 16:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 12:25 [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile Jani Nikula
2022-04-13 12:25 ` [Intel-gfx] [PATCH 1/2] drm/i915/gvt: fix trace TRACE_INCLUDE_PATH Jani Nikula
2022-04-13 15:36 ` Christoph Hellwig
2022-04-13 12:25 ` [Intel-gfx] [PATCH 2/2] drm/i915/gvt: better align the Makefile with i915 Makefile Jani Nikula
2022-04-13 15:37 ` Christoph Hellwig
2022-04-13 13:40 ` [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile Wang, Zhi A
2022-04-13 15:41 ` Christoph Hellwig
2022-04-13 16:04 ` Jani Nikula
2022-04-13 16:12 ` Christoph Hellwig
2022-04-13 16:25 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220413162520.GT2120790@nvidia.com \
--to=jgg@nvidia.com \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.