From: Herve Codina <herve.codina@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: "Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Clement Leger" <clement.leger@bootlin.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [PATCH 1/6] PCI: rcar-gen2: Add support for clocks
Date: Wed, 13 Apr 2022 16:49:54 +0200 [thread overview]
Message-ID: <20220413164954.32365292@bootlin.com> (raw)
In-Reply-To: <YlWfslEOdrf62KiP@robh.at.kernel.org>
Hi Rob,
On Tue, 12 Apr 2022 10:50:10 -0500
Rob Herring <robh@kernel.org> wrote:
> On Tue, Apr 12, 2022 at 11:40:24AM +0200, Herve Codina wrote:
> > The PCI rcar-gen2 does not call any clk_prepare_enable().
> > This lead to an access failure when the driver tries to access
> > the IP (at least on a RZ/N1D platform).
> >
> > Prepare and enable clocks using the bulk version of
> > clk_prepare_enable() in order to prepare and enable all clocks
> > attached to this device.
>
> The binding says there is only a single clock, so it needs an update if
> there are multiple clocks. (And ideally converted to DT schema format.)
Indeed, I will convert to DT schema format and update the clocks property
description.
Regards,
Hervé
next prev parent reply other threads:[~2022-04-13 14:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 9:40 [PATCH 0/6] RZN1 USB Host support Herve Codina
2022-04-12 9:40 ` [PATCH 1/6] PCI: rcar-gen2: Add support for clocks Herve Codina
2022-04-12 15:50 ` Rob Herring
2022-04-13 14:49 ` Herve Codina [this message]
2022-04-12 9:40 ` [PATCH 2/6] dt-bindings: PCI: pci-rcar-gen2: Add device tree support for r9a06g032 Herve Codina
2022-04-12 9:40 ` [PATCH 3/6] PCI: rcar-gen2: Add R9A06G032 support Herve Codina
2022-04-12 10:05 ` Miquel Raynal
2022-04-13 9:08 ` Sergey Shtylyov
2022-04-13 14:59 ` Herve Codina
2022-04-12 9:40 ` [PATCH 4/6] ARM: dts: r9a06g032: Add internal PCI bridge node Herve Codina
2022-04-12 9:40 ` [PATCH 5/6] ARM: dts: r9a06g032: Add USB PHY DT support Herve Codina
2022-04-12 9:40 ` [PATCH 6/6] ARM: dts: r9a06g032: Link the PCI USB devices to the USB PHY Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220413164954.32365292@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=bhelgaas@google.com \
--cc=clement.leger@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.