All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Felix Matouschek <felix@matouschek.org>
Cc: linux-mtd@lists.infradead.org,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v2] mtd: spinand: Add support for XTX XT26G0xA
Date: Wed, 13 Apr 2022 17:56:05 +0200	[thread overview]
Message-ID: <20220413175605.758ca842@xps13> (raw)
In-Reply-To: <c49e86c8-5433-343f-d41f-ce6e9dcdf75b@matouschek.org>

Hi Felix,

felix@matouschek.org wrote on Wed, 13 Apr 2022 17:38:28 +0200:

> Hi Miquel,
> 
> Am 11.04.22 um 22:03 schrieb Miquel Raynal:
> >> According to the data-sheet (section 7, page 27) the switch should be
> >> able to handle all values of the status register. So should I remove the
> >> final "return -EINVAL"?  
> > 
> > I think so, yes.  
> 
> I noticed that there are actually some possible values for the ECC bits in the 
> status register, that are not covered by the switch case. According to the
> data-sheet they should not happen, but would it be wise to catch them anyways?
> Maybe if something goes wrong?

Yes of course, that was my advice in the first place :)

> 
> Thank you,
> Felix


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2022-04-13 15:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08 16:19 [PATCH v2] mtd: spinand: Add support for XTX XT26G0xA Felix Matouschek
2022-04-11  7:23 ` Miquel Raynal
2022-04-11 19:53   ` Felix Matouschek
2022-04-11 20:03     ` Miquel Raynal
2022-04-13 15:38       ` Felix Matouschek
2022-04-13 15:56         ` Miquel Raynal [this message]
2022-04-18 13:32           ` Felix Matouschek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220413175605.758ca842@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=felix@matouschek.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.