From: Christoph Hellwig <hch@lst.de>
To: Klaus Jensen <its@irrelevant.dk>
Cc: Christoph Hellwig <hch@lst.de>,
Niklas Cassel <Niklas.Cassel@wdc.com>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
Luis Chamberlain <mcgrof@kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 3/3] nvme-pci: disable namespace identifiers for Qemu controllers
Date: Thu, 14 Apr 2022 06:19:27 +0200 [thread overview]
Message-ID: <20220414041927.GA10493@lst.de> (raw)
In-Reply-To: <Ylct1QXgzpoxpHaq@apples>
On Wed, Apr 13, 2022 at 10:08:53PM +0200, Klaus Jensen wrote:
> You are absolutely right in the case of live-migration, but hw/nvme is
> marked unmigratable, so we do not worry about that.
>
> We probably screwed up with the compatibility parameter here, since it
> really only guarantees the id and some headaches for you as driver
> maintainer. I'm sorry about that - I'll keep this in mind for the
> future.
>
> Regardless, the fact remains that it is possible to have a device with a
> buggy uuid namespace descriptor using the Intel identifier, so we should
> add the quirk for that as well.
I've added the quirk to the old ID for now.
next prev parent reply other threads:[~2022-04-14 4:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 4:49 quirk broken namespace identifiers v2 Christoph Hellwig
2022-04-13 4:49 ` [PATCH 1/3] nvme: add a quirk to disable namespace identifiers Christoph Hellwig
2022-04-13 4:49 ` [PATCH 2/3] nvme-pci: disable namespace identifiers for the MAXIO MAP1002/1202 Christoph Hellwig
2022-04-13 4:49 ` [PATCH 3/3] nvme-pci: disable namespace identifiers for Qemu controllers Christoph Hellwig
2022-04-13 7:34 ` Niklas Cassel
2022-04-13 8:40 ` Klaus Jensen
2022-04-13 15:34 ` Christoph Hellwig
2022-04-13 15:49 ` Klaus Jensen
2022-04-13 15:50 ` Christoph Hellwig
2022-04-13 20:08 ` Klaus Jensen
2022-04-13 20:38 ` Keith Busch
2022-04-14 4:19 ` Christoph Hellwig [this message]
2022-04-13 14:42 ` quirk broken namespace identifiers v2 Keith Busch
-- strict thread matches above, loose matches on Subject: below --
2022-04-12 6:11 quirk broken namespace identifiers Christoph Hellwig
2022-04-12 6:11 ` [PATCH 3/3] nvme-pci: disable namespace identifiers for Qemu controllers Christoph Hellwig
2022-04-12 6:33 ` Klaus Jensen
2022-04-12 11:45 ` Christoph Hellwig
2022-04-12 20:43 ` Klaus Jensen
2022-04-12 10:25 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220414041927.GA10493@lst.de \
--to=hch@lst.de \
--cc=Niklas.Cassel@wdc.com \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.