From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE947C433F5 for ; Thu, 14 Apr 2022 07:52:18 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D687516C5; Thu, 14 Apr 2022 09:51:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D687516C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1649922735; bh=iaCus6tThruadpFJ0OLu/AmaobE6jZNTFys7/Zk2JVo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iFNMsu6+st9qRgb+65t2kx2dPGuQoyo28dvHL6HIyFgGgGLDbGQLXUo9vQ8wFjzII 06Qv+qbe3/PjxAUrX1gwjxGlwQfu8Ajp1YBGK4s0PLQZVkva3U8OKF+oldv5XeOsck NARqwaTH/yLGKtVqZjhoV1WZfKa7J3vWEV86x03I= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 70197F8012E; Thu, 14 Apr 2022 09:51:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 20621F80162; Thu, 14 Apr 2022 09:51:24 +0200 (CEST) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1EFB5F80114 for ; Thu, 14 Apr 2022 09:51:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1EFB5F80114 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neuG4-0003M7-Ga; Thu, 14 Apr 2022 09:51:16 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1neuG2-0000k3-Oi; Thu, 14 Apr 2022 09:51:14 +0200 Date: Thu, 14 Apr 2022 09:51:14 +0200 From: Sascha Hauer To: Mark Brown Subject: Re: [PATCH v5 00/21] ASoC: fsl_micfil: Driver updates Message-ID: <20220414075114.GC2387@pengutronix.de> References: <20220408112928.1326755-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408112928.1326755-1-s.hauer@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:49:24 up 14 days, 20:19, 59 users, load average: 0.07, 0.11, 0.09 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Cc: alsa-devel@alsa-project.org, Xiubo Li , Fabio Estevam , Vinod Koul , NXP Linux Team , kernel@pengutronix.de, dmaengine@vger.kernel.org, Shengjiu Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Mark, Ok to apply this series? I just realized that I missed to Cc: you on this series. Let me know if I should resend. Sascha On Fri, Apr 08, 2022 at 01:29:07PM +0200, Sascha Hauer wrote: > This series has a bunch of cleanups for the FSL MICFIL driver. There is > not much chance for regressions in this series as the driver currently > can't work at all. The MICFIL needs multififo support in the i.MX SDMA > engine which is added with this series, see 11/20. > > The multififo support is selected in the dma phandle arguments in the > device tree, the transfer type must be '25' aka IMX_DMATYPE_MULTI_SAI. > This is set already to 25 in the upstream i.MX8M[NM] dtsi files, but the > SDMA driver silently ignores unsupported values instead of throwing an > error. This is fixed in this series and multififo support is added. > > The dmaengine patches have acks from Vinod, so the series is free to > go through the ASoC tree. > > Changes since v4: > - collect more acks > - whitespace cleanup in 16/21 > > Changes since v3: > - Add commit log to "ASoC: fsl_micfil: drop unused variables" > - Fix include name in "ASoC: fsl_micfil: add multi fifo support" > - Drop unnecessary temporary adding of struct fsl_micfil::osr > - Leave default quality setting at 'medium' > - Drop debugging message printed at error level > - collect acks from Shengjiu Wang and Vinod Koul > > Changes since v2: > - Add forgotten commit log to dmaengine patches > - Add patch to move include/linux/platform_data/dma-imx.h to include/linux/dma/imx-dma.h > - Use prefix dmaengine: for dma patches > > Changes since v1: > - Drop unused variable sw_done_sel > - Evaluate sdmac->direction directly instead of storing value in n_fifos > - add missing include linux/bitfield.h > > Sascha Hauer (21): > ASoC: fsl_micfil: Drop unnecessary register read > ASoC: fsl_micfil: Drop unused register read > ASoC: fsl_micfil: drop fsl_micfil_set_mclk_rate() > ASoC: fsl_micfil: do not define SHIFT/MASK for single bits > ASoC: fsl_micfil: use GENMASK to define register bit fields > ASoC: fsl_micfil: use clear/set bits > ASoC: fsl_micfil: drop error messages from failed register accesses > ASoC: fsl_micfil: drop unused variables > dmaengine: imx: Move header to include/dma/ > dmaengine: imx-sdma: error out on unsupported transfer types > dmaengine: imx-sdma: Add multi fifo support > ASoC: fsl_micfil: add multi fifo support > ASoC: fsl_micfil: use define for OSR default value > ASoC: fsl_micfil: Drop get_pdm_clk() > ASoC: fsl_micfil: simplify clock setting > ASoC: fsl_micfil: rework quality setting > ASoC: fsl_micfil: drop unused include > ASoC: fsl_micfil: drop only once used defines > ASoC: fsl_micfil: drop support for undocumented property > ASoC: fsl_micfil: fold fsl_set_clock_params() into its only user > ASoC: fsl_micfil: Remove debug message > > drivers/dma/imx-dma.c | 2 +- > drivers/dma/imx-sdma.c | 76 +++- > drivers/mmc/host/mxcmmc.c | 2 +- > drivers/spi/spi-fsl-lpspi.c | 2 +- > drivers/spi/spi-imx.c | 2 +- > drivers/tty/serial/imx.c | 2 +- > drivers/video/fbdev/mx3fb.c | 2 +- > .../dma-imx.h => dma/imx-dma.h} | 26 +- > sound/soc/fsl/fsl_asrc.c | 2 +- > sound/soc/fsl/fsl_asrc_dma.c | 2 +- > sound/soc/fsl/fsl_easrc.h | 2 +- > sound/soc/fsl/fsl_micfil.c | 369 +++++++----------- > sound/soc/fsl/fsl_micfil.h | 269 +++---------- > sound/soc/fsl/imx-pcm.h | 2 +- > sound/soc/fsl/imx-ssi.h | 2 +- > 15 files changed, 297 insertions(+), 465 deletions(-) > rename include/linux/{platform_data/dma-imx.h => dma/imx-dma.h} (67%) > > -- > 2.30.2 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EDC1C433F5 for ; Thu, 14 Apr 2022 07:51:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240414AbiDNHxy (ORCPT ); Thu, 14 Apr 2022 03:53:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240327AbiDNHxy (ORCPT ); Thu, 14 Apr 2022 03:53:54 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B97436B76 for ; Thu, 14 Apr 2022 00:51:25 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neuG4-0003M7-Ga; Thu, 14 Apr 2022 09:51:16 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1neuG2-0000k3-Oi; Thu, 14 Apr 2022 09:51:14 +0200 Date: Thu, 14 Apr 2022 09:51:14 +0200 From: Sascha Hauer To: Mark Brown Cc: alsa-devel@alsa-project.org, Xiubo Li , Fabio Estevam , Shengjiu Wang , kernel@pengutronix.de, Vinod Koul , NXP Linux Team , dmaengine@vger.kernel.org Subject: Re: [PATCH v5 00/21] ASoC: fsl_micfil: Driver updates Message-ID: <20220414075114.GC2387@pengutronix.de> References: <20220408112928.1326755-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408112928.1326755-1-s.hauer@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:49:24 up 14 days, 20:19, 59 users, load average: 0.07, 0.11, 0.09 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dmaengine@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Mark, Ok to apply this series? I just realized that I missed to Cc: you on this series. Let me know if I should resend. Sascha On Fri, Apr 08, 2022 at 01:29:07PM +0200, Sascha Hauer wrote: > This series has a bunch of cleanups for the FSL MICFIL driver. There is > not much chance for regressions in this series as the driver currently > can't work at all. The MICFIL needs multififo support in the i.MX SDMA > engine which is added with this series, see 11/20. > > The multififo support is selected in the dma phandle arguments in the > device tree, the transfer type must be '25' aka IMX_DMATYPE_MULTI_SAI. > This is set already to 25 in the upstream i.MX8M[NM] dtsi files, but the > SDMA driver silently ignores unsupported values instead of throwing an > error. This is fixed in this series and multififo support is added. > > The dmaengine patches have acks from Vinod, so the series is free to > go through the ASoC tree. > > Changes since v4: > - collect more acks > - whitespace cleanup in 16/21 > > Changes since v3: > - Add commit log to "ASoC: fsl_micfil: drop unused variables" > - Fix include name in "ASoC: fsl_micfil: add multi fifo support" > - Drop unnecessary temporary adding of struct fsl_micfil::osr > - Leave default quality setting at 'medium' > - Drop debugging message printed at error level > - collect acks from Shengjiu Wang and Vinod Koul > > Changes since v2: > - Add forgotten commit log to dmaengine patches > - Add patch to move include/linux/platform_data/dma-imx.h to include/linux/dma/imx-dma.h > - Use prefix dmaengine: for dma patches > > Changes since v1: > - Drop unused variable sw_done_sel > - Evaluate sdmac->direction directly instead of storing value in n_fifos > - add missing include linux/bitfield.h > > Sascha Hauer (21): > ASoC: fsl_micfil: Drop unnecessary register read > ASoC: fsl_micfil: Drop unused register read > ASoC: fsl_micfil: drop fsl_micfil_set_mclk_rate() > ASoC: fsl_micfil: do not define SHIFT/MASK for single bits > ASoC: fsl_micfil: use GENMASK to define register bit fields > ASoC: fsl_micfil: use clear/set bits > ASoC: fsl_micfil: drop error messages from failed register accesses > ASoC: fsl_micfil: drop unused variables > dmaengine: imx: Move header to include/dma/ > dmaengine: imx-sdma: error out on unsupported transfer types > dmaengine: imx-sdma: Add multi fifo support > ASoC: fsl_micfil: add multi fifo support > ASoC: fsl_micfil: use define for OSR default value > ASoC: fsl_micfil: Drop get_pdm_clk() > ASoC: fsl_micfil: simplify clock setting > ASoC: fsl_micfil: rework quality setting > ASoC: fsl_micfil: drop unused include > ASoC: fsl_micfil: drop only once used defines > ASoC: fsl_micfil: drop support for undocumented property > ASoC: fsl_micfil: fold fsl_set_clock_params() into its only user > ASoC: fsl_micfil: Remove debug message > > drivers/dma/imx-dma.c | 2 +- > drivers/dma/imx-sdma.c | 76 +++- > drivers/mmc/host/mxcmmc.c | 2 +- > drivers/spi/spi-fsl-lpspi.c | 2 +- > drivers/spi/spi-imx.c | 2 +- > drivers/tty/serial/imx.c | 2 +- > drivers/video/fbdev/mx3fb.c | 2 +- > .../dma-imx.h => dma/imx-dma.h} | 26 +- > sound/soc/fsl/fsl_asrc.c | 2 +- > sound/soc/fsl/fsl_asrc_dma.c | 2 +- > sound/soc/fsl/fsl_easrc.h | 2 +- > sound/soc/fsl/fsl_micfil.c | 369 +++++++----------- > sound/soc/fsl/fsl_micfil.h | 269 +++---------- > sound/soc/fsl/imx-pcm.h | 2 +- > sound/soc/fsl/imx-ssi.h | 2 +- > 15 files changed, 297 insertions(+), 465 deletions(-) > rename include/linux/{platform_data/dma-imx.h => dma/imx-dma.h} (67%) > > -- > 2.30.2 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |