From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: Rob Herring <robh@kernel.org>
Cc: "wsa@kernel.org" <wsa@kernel.org>, kernel <kernel@axis.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: add property to avoid device detection
Date: Thu, 14 Apr 2022 10:55:40 +0200 [thread overview]
Message-ID: <20220414085539.GA7392@axis.com> (raw)
In-Reply-To: <YlXtobiXIyObF/7+@robh.at.kernel.org>
On Tue, Apr 12, 2022 at 11:22:41PM +0200, Rob Herring wrote:
> On Tue, Apr 12, 2022 at 10:50:45AM +0200, Vincent Whitchurch wrote:
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt
> > index fc3dd7ec0445..960d1d5c9362 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c.txt
> > @@ -72,6 +72,10 @@ wants to support one of the below features, it should adapt these bindings.
> > this information to adapt power management to keep the arbitration awake
> > all the time, for example. Can not be combined with 'single-master'.
> >
> > +- no-detect
> > + states that no other devices are present on this bus other than the
> > + ones listed in the devicetree.
>
> This belongs in the schema instead:
>
> https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/i2c/i2c-controller.yaml
OK, thank you, I've sent a PR[0] now, but I must admit I don't quite
understand how this property differs from the other ones in this file
which aren't documented there.
[0] https://github.com/devicetree-org/dt-schema/pull/72
next prev parent reply other threads:[~2022-04-14 8:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 8:50 [PATCH v2 0/2] i2c: Allow disabling auto detection via devicetree Vincent Whitchurch
2022-04-12 8:50 ` [PATCH v2 1/2] dt-bindings: i2c: add property to avoid device detection Vincent Whitchurch
2022-04-12 8:52 ` Krzysztof Kozlowski
2022-04-12 21:22 ` Rob Herring
2022-04-14 8:55 ` Vincent Whitchurch [this message]
2022-04-14 19:40 ` Rob Herring
2022-05-14 14:26 ` Wolfram Sang
2022-05-16 6:43 ` Vincent Whitchurch
2022-05-16 7:12 ` Wolfram Sang
2022-05-16 7:57 ` Peter Rosin
2022-05-16 8:07 ` Peter Rosin
2022-05-18 16:09 ` Luca Ceresoli
2022-04-12 8:50 ` [PATCH v2 2/2] i2c: core: support no-detect property Vincent Whitchurch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220414085539.GA7392@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.