From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF1C9C433FE for ; Thu, 14 Apr 2022 15:49:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245259AbiDNPwG (ORCPT ); Thu, 14 Apr 2022 11:52:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350431AbiDNPQd (ORCPT ); Thu, 14 Apr 2022 11:16:33 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E017DFFBE; Thu, 14 Apr 2022 07:59:15 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 1EDD31BF206; Thu, 14 Apr 2022 14:59:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1649948353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FAf8yLi3lQ6imgrUHohSJNasrVq7HVgTeNQSDWU87gs=; b=lEnYzDaWqAHzINN5jDYX7d7Mfkuiz7OUjP//NPHNqOqSmv5dr81IDkm5DKEELYlo4EWrjs Aee598u3irhAsKOiSlyPJapwDYZ7iQkNM1ViK5rvwLoNFNEzTSq3XAIJElcvofC/Lz459k TOsDc/Tjgx/qSKVoeNriDf3NubHCUx1AmNYGp+xn8pMXCtmuBfiLBBu7n3pwzi1/gi7cYq 2iwqNlK+diZNt+VmC6zzBTmnNEAgTr7G2hVOlxqN6inxqqjDlVLAE+/OAO28Oo/GmyovGG ORnjovIcReNJ3Gn0dYc94m/YrJQOhA15j4PNcQaRI0ux2yrcHT7A7szjE0JAKw== Date: Thu, 14 Apr 2022 16:59:09 +0200 From: Miquel Raynal To: Manivannan Sadhasivam Cc: Md Sadre Alam , richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, quic_srichara@quicinc.com Subject: Re: [PATCH] mtd: rawnand: qcom: fix memory corruption that causes panic Message-ID: <20220414165909.249c2325@xps13> In-Reply-To: <20220414143907.GA20493@thinkpad> References: <1649914773-22434-1-git-send-email-quic_mdalam@quicinc.com> <20220414101517.7bbc5e9d@xps13> <2697e757-f446-9cdb-95e0-ea01a642e6d4@quicinc.com> <20220414144236.4ea54e20@xps13> <20220414143907.GA20493@thinkpad> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Manivannan, mani@kernel.org wrote on Thu, 14 Apr 2022 20:09:07 +0530: > On Thu, Apr 14, 2022 at 02:42:36PM +0200, Miquel Raynal wrote: > > Hi Md, > >=20 > > quic_mdalam@quicinc.com wrote on Thu, 14 Apr 2022 17:50:48 +0530: > > =20 > > > > Hi Md, > > > > > > > > quic_mdalam@quicinc.com wrote on Thu, 14 Apr 2022 11:09:33 +0530: > > > > =20 > > > >> This patch fixes a memory corruption that occurred in the > > > >> nand_scan() path for Hynix nand device. > > > >> > > > >> On boot, for Hynix nand device will panic at a weird place: > > > >> | Unable to handle kernel NULL pointer dereference at virtual > > > >> address 00000070 > > > >> | [00000070] *pgd=3D00000000 > > > >> | Internal error: Oops: 5 [#1] PREEMPT SMP ARM Modules linked in: > > > >> | CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.17.0-01473-g13ae1769= cfb0 > > > >> #38 > > > >> | Hardware name: Generic DT based system PC is at > > > >> | nandc_set_reg+0x8/0x1c LR is at qcom_nandc_command+0x20c/0x5d0 > > > >> | pc : [] lr : [] psr: 00000113 > > > >> | sp : c14adc50 ip : c14ee208 fp : c0cc970c > > > >> | r10: 000000a3 r9 : 00000000 r8 : 00000040 > > > >> | r7 : c16f6a00 r6 : 00000090 r5 : 00000004 r4 :c14ee040 > > > >> | r3 : 00000000 r2 : 0000000b r1 : 00000000 r0 :c14ee040 > > > >> | Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none > > > >> | Control: 10c5387d Table: 8020406a DAC: 00000051 Register r0 > > > >> | information: slab kmalloc-2k start c14ee000 pointer offset > > > >> 64 size 2048 > > > >> | Process swapper/0 (pid: 1, stack limit =3D 0x(ptrval)) nandc_set= _reg > > > >> | from qcom_nandc_command+0x20c/0x5d0 qcom_nandc_command from > > > >> | nand_readid_op+0x198/0x1e8 nand_readid_op from > > > >> | hynix_nand_has_valid_jedecid+0x30/0x78 > > > >> | hynix_nand_has_valid_jedecid from hynix_nand_init+0xb8/0x454 > > > >> | hynix_nand_init from nand_scan_with_ids+0xa30/0x14a8 > > > >> | nand_scan_with_ids from qcom_nandc_probe+0x648/0x7b0 > > > >> | qcom_nandc_probe from platform_probe+0x58/0xac > > > >> > > > >> The problem is that the nand_scan()'s qcom_nand_attach_chip callba= ck > > > >> is updating the nandc->max_cwperpage from 1 to 4.This causes the > > > >> sg_init_table of clear_bam_transaction() in the driver's > > > >> qcom_nandc_command() to memset much more than what was initially > > > >> allocated by alloc_bam_transaction(). =20 > > > > Thanks for investigating! > > > > =20 > > > >> This patch will update nandc->max_cwperpage 1 to 4 after nand_scan= () > > > >> returns, and remove updating nandc->max_cwperpage from > > > >> qcom_nand_attach_chip call back. =20 > > > > The fix does not look right, as far as I understand, this should be= properly handled during the attach phase. That is where we have all inform= ation about the chip and do the configuration for this chip. > > > > > > > > If you update max_cwperpage there you should probably update other = internal variables that depend on it as well. =20 > > >=20 > > > =C2=A0=C2=A0 Currently we are updating max_cwperpage=C2=A0 in qcom_n= and_attach_chip(), but we are seeing issue for Hynix nand device since nand= _scan_tail() is getting called after nand_attach() and in nand_attach() we = are updating max_cwperpage to 4 or 8 based on page size. > > >=20 > > > =C2=A0=C2=A0=C2=A0 From nand_scan_tail() there is a call for nand_ma= nufacturer_init() , specific to Hynix nand read_id is getting called that's= why we are seeing this issue only for Hynix nand device. Read id sequence = as below > > >=20 > > > =C2=A0=C2=A0 hynix_nand_has_valid_jedecid() > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 | > > >=20 > > > =C2=A0=C2=A0 nand_readid_op() > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 | > > >=20 > > > =C2=A0qcom_nandc_command() > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | > > >=20 > > > pre_command() > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | > > >=20 > > > clear_bam_transaction()=C2=A0=C2=A0 --> In this call we are doing sg_= init_table() which is calling memset() based on max_cwperpage.Since initial= ly we have allocated bam transaction as per max_cwperpage =3D1 and , since = nand_chip_attach() updated max_cwperpage,=C2=A0 now we are doing memset as = per max_cwperpage =3D 4 or 8. > > >=20 > > >=20 > > > So anyway we have to updated max_cwperpage after nand_scan() call onl= y.=C2=A0 Since there is no other dependency on max_cwperpage in nand_attach= _chip() and we are using this in bam_alloc() and bam_clear(). =20 > >=20 > > Why don't you update the sg table after increasing max_cwperpage? > > =20 >=20 > Or we could move the bam reallocation inside qcom_nand_attach_chip() as b= elow? Much better approach, yes. >=20 > diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qco= m_nandc.c > index 7c6efa3b6255..58c16054630f 100644 > --- a/drivers/mtd/nand/raw/qcom_nandc.c > +++ b/drivers/mtd/nand/raw/qcom_nandc.c > @@ -2653,9 +2653,23 @@ static int qcom_nand_attach_chip(struct nand_chip = *chip) > =20 > mtd_set_ooblayout(mtd, &qcom_nand_ooblayout_ops); > =20 > + /* Free the initially allocated BAM transaction for reading the O= NFI params */ > + if (nandc->props->is_bam) > + free_bam_transaction(nandc); > + > nandc->max_cwperpage =3D max_t(unsigned int, nandc->max_cwperpage, > cwperpage); > =20 > + /* Now allocate the BAM transaction based on updated max_cwperpag= e */ > + if (nandc->props->is_bam) { > + nandc->bam_txn =3D alloc_bam_transaction(nandc); > + if (!nandc->bam_txn) { > + dev_err(nandc->dev, > + "failed to allocate bam transaction\n"); > + return -ENOMEM; > + } > + } > + > /* > * DATA_UD_BYTES varies based on whether the read/write command p= rotects > * spare data with ECC too. We protect spare data by default, so = we set > @@ -2956,17 +2970,6 @@ static int qcom_nand_host_init_and_register(struct= qcom_nand_controller *nandc, > if (ret) > return ret; > =20 > - if (nandc->props->is_bam) { > - free_bam_transaction(nandc); > - nandc->bam_txn =3D alloc_bam_transaction(nandc); > - if (!nandc->bam_txn) { > - dev_err(nandc->dev, > - "failed to allocate bam transaction\n"); > - nand_cleanup(chip); > - return -ENOMEM; > - } > - } > - > ret =3D mtd_device_parse_register(mtd, probes, NULL, NULL, 0); > if (ret) > nand_cleanup(chip); >=20 > Thanks, > Mani Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E730DC433EF for ; Thu, 14 Apr 2022 14:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9s+P1Y6tzIhalBMtcLWsifVpw7y6rTk+z+MOMZrbynE=; b=b24KKD0SOEn8iw nITBInbleU2Jegzsc38vs/BZtLwOBQhOiVeloX9zGW1vNIyE1nnfAdDWGffcXqcW3FJCJdssuws10 +A0qAjjC4PwcuQrqiyfDflgTEEpRe/OxFLZHkUhtJvjrwRx7E5Y6NCsegkApuA5ylxJgFAnrNyFGE 059Y67yPpLy3/nqmYneOhc4P9YcFoOtM9SiqCWhjrsRSakzpPIiGZmR/Uje3+h5cu7NJluR3TG1oD 5LEYXoc2UeWY2bc+EtXlaDOhPFXMl+QzNx/iTjStAEIvFchioqv01HNPgkUi7kIhb9yvJGLSgV0Jm 0qNdJDRjSY3rHolQlfZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nf0wQ-0067mM-Ph; Thu, 14 Apr 2022 14:59:26 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nf0wL-0067iW-PP for linux-mtd@lists.infradead.org; Thu, 14 Apr 2022 14:59:24 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 1EDD31BF206; Thu, 14 Apr 2022 14:59:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1649948353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FAf8yLi3lQ6imgrUHohSJNasrVq7HVgTeNQSDWU87gs=; b=lEnYzDaWqAHzINN5jDYX7d7Mfkuiz7OUjP//NPHNqOqSmv5dr81IDkm5DKEELYlo4EWrjs Aee598u3irhAsKOiSlyPJapwDYZ7iQkNM1ViK5rvwLoNFNEzTSq3XAIJElcvofC/Lz459k TOsDc/Tjgx/qSKVoeNriDf3NubHCUx1AmNYGp+xn8pMXCtmuBfiLBBu7n3pwzi1/gi7cYq 2iwqNlK+diZNt+VmC6zzBTmnNEAgTr7G2hVOlxqN6inxqqjDlVLAE+/OAO28Oo/GmyovGG ORnjovIcReNJ3Gn0dYc94m/YrJQOhA15j4PNcQaRI0ux2yrcHT7A7szjE0JAKw== Date: Thu, 14 Apr 2022 16:59:09 +0200 From: Miquel Raynal To: Manivannan Sadhasivam Cc: Md Sadre Alam , richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, quic_srichara@quicinc.com Subject: Re: [PATCH] mtd: rawnand: qcom: fix memory corruption that causes panic Message-ID: <20220414165909.249c2325@xps13> In-Reply-To: <20220414143907.GA20493@thinkpad> References: <1649914773-22434-1-git-send-email-quic_mdalam@quicinc.com> <20220414101517.7bbc5e9d@xps13> <2697e757-f446-9cdb-95e0-ea01a642e6d4@quicinc.com> <20220414144236.4ea54e20@xps13> <20220414143907.GA20493@thinkpad> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_075922_305953_35DEC4F9 X-CRM114-Status: GOOD ( 39.51 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWFuaXZhbm5hbiwKCm1hbmlAa2VybmVsLm9yZyB3cm90ZSBvbiBUaHUsIDE0IEFwciAyMDIy IDIwOjA5OjA3ICswNTMwOgoKPiBPbiBUaHUsIEFwciAxNCwgMjAyMiBhdCAwMjo0MjozNlBNICsw MjAwLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ID4gSGkgTWQsCj4gPiAKPiA+IHF1aWNfbWRhbGFt QHF1aWNpbmMuY29tIHdyb3RlIG9uIFRodSwgMTQgQXByIDIwMjIgMTc6NTA6NDggKzA1MzA6Cj4g PiAgIAo+ID4gPiA+IEhpIE1kLAo+ID4gPiA+Cj4gPiA+ID4gcXVpY19tZGFsYW1AcXVpY2luYy5j b20gd3JvdGUgb24gVGh1LCAxNCBBcHIgMjAyMiAxMTowOTozMyArMDUzMDoKPiA+ID4gPiAgICAK PiA+ID4gPj4gVGhpcyBwYXRjaCBmaXhlcyBhIG1lbW9yeSBjb3JydXB0aW9uIHRoYXQgb2NjdXJy ZWQgaW4gdGhlCj4gPiA+ID4+IG5hbmRfc2NhbigpIHBhdGggZm9yIEh5bml4IG5hbmQgZGV2aWNl Lgo+ID4gPiA+Pgo+ID4gPiA+PiBPbiBib290LCBmb3IgSHluaXggbmFuZCBkZXZpY2Ugd2lsbCBw YW5pYyBhdCBhIHdlaXJkIHBsYWNlOgo+ID4gPiA+PiB8IFVuYWJsZSB0byBoYW5kbGUga2VybmVs IE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSBhdCB2aXJ0dWFsCj4gPiA+ID4+ICAgIGFkZHJlc3Mg MDAwMDAwNzAKPiA+ID4gPj4gfCBbMDAwMDAwNzBdICpwZ2Q9MDAwMDAwMDAKPiA+ID4gPj4gfCBJ bnRlcm5hbCBlcnJvcjogT29wczogNSBbIzFdIFBSRUVNUFQgU01QIEFSTSBNb2R1bGVzIGxpbmtl ZCBpbjoKPiA+ID4gPj4gfCBDUFU6IDAgUElEOiAxIENvbW06IHN3YXBwZXIvMCBOb3QgdGFpbnRl ZCA1LjE3LjAtMDE0NzMtZzEzYWUxNzY5Y2ZiMAo+ID4gPiA+PiAgICAjMzgKPiA+ID4gPj4gfCBI YXJkd2FyZSBuYW1lOiBHZW5lcmljIERUIGJhc2VkIHN5c3RlbSBQQyBpcyBhdAo+ID4gPiA+PiB8 IG5hbmRjX3NldF9yZWcrMHg4LzB4MWMgTFIgaXMgYXQgcWNvbV9uYW5kY19jb21tYW5kKzB4MjBj LzB4NWQwCj4gPiA+ID4+IHwgcGMgOiBbPGMwODhiNzRjPl0gICAgbHIgOiBbPGMwODhkOWM4Pl0g ICAgcHNyOiAwMDAwMDExMwo+ID4gPiA+PiB8IHNwIDogYzE0YWRjNTAgIGlwIDogYzE0ZWUyMDgg IGZwIDogYzBjYzk3MGMKPiA+ID4gPj4gfCByMTA6IDAwMDAwMGEzICByOSA6IDAwMDAwMDAwICBy OCA6IDAwMDAwMDQwCj4gPiA+ID4+IHwgcjcgOiBjMTZmNmEwMCAgcjYgOiAwMDAwMDA5MCAgcjUg OiAwMDAwMDAwNCAgcjQgOmMxNGVlMDQwCj4gPiA+ID4+IHwgcjMgOiAwMDAwMDAwMCAgcjIgOiAw MDAwMDAwYiAgcjEgOiAwMDAwMDAwMCAgcjAgOmMxNGVlMDQwCj4gPiA+ID4+IHwgRmxhZ3M6IG56 Y3YgIElSUXMgb24gIEZJUXMgb24gIE1vZGUgU1ZDXzMyICBJU0EgQVJNIFNlZ21lbnQgbm9uZQo+ ID4gPiA+PiB8IENvbnRyb2w6IDEwYzUzODdkICBUYWJsZTogODAyMDQwNmEgIERBQzogMDAwMDAw NTEgUmVnaXN0ZXIgcjAKPiA+ID4gPj4gfCBpbmZvcm1hdGlvbjogc2xhYiBrbWFsbG9jLTJrIHN0 YXJ0IGMxNGVlMDAwIHBvaW50ZXIgb2Zmc2V0Cj4gPiA+ID4+ICAgIDY0IHNpemUgMjA0OAo+ID4g PiA+PiB8IFByb2Nlc3Mgc3dhcHBlci8wIChwaWQ6IDEsIHN0YWNrIGxpbWl0ID0gMHgocHRydmFs KSkgbmFuZGNfc2V0X3JlZwo+ID4gPiA+PiB8IGZyb20gcWNvbV9uYW5kY19jb21tYW5kKzB4MjBj LzB4NWQwIHFjb21fbmFuZGNfY29tbWFuZCBmcm9tCj4gPiA+ID4+IHwgbmFuZF9yZWFkaWRfb3Ar MHgxOTgvMHgxZTggbmFuZF9yZWFkaWRfb3AgZnJvbQo+ID4gPiA+PiB8IGh5bml4X25hbmRfaGFz X3ZhbGlkX2plZGVjaWQrMHgzMC8weDc4Cj4gPiA+ID4+IHwgaHluaXhfbmFuZF9oYXNfdmFsaWRf amVkZWNpZCBmcm9tIGh5bml4X25hbmRfaW5pdCsweGI4LzB4NDU0Cj4gPiA+ID4+IHwgaHluaXhf bmFuZF9pbml0IGZyb20gbmFuZF9zY2FuX3dpdGhfaWRzKzB4YTMwLzB4MTRhOAo+ID4gPiA+PiB8 IG5hbmRfc2Nhbl93aXRoX2lkcyBmcm9tIHFjb21fbmFuZGNfcHJvYmUrMHg2NDgvMHg3YjAKPiA+ ID4gPj4gfCBxY29tX25hbmRjX3Byb2JlIGZyb20gcGxhdGZvcm1fcHJvYmUrMHg1OC8weGFjCj4g PiA+ID4+Cj4gPiA+ID4+IFRoZSBwcm9ibGVtIGlzIHRoYXQgdGhlIG5hbmRfc2NhbigpJ3MgcWNv bV9uYW5kX2F0dGFjaF9jaGlwIGNhbGxiYWNrCj4gPiA+ID4+IGlzIHVwZGF0aW5nIHRoZSBuYW5k Yy0+bWF4X2N3cGVycGFnZSBmcm9tIDEgdG8gNC5UaGlzIGNhdXNlcyB0aGUKPiA+ID4gPj4gc2df aW5pdF90YWJsZSBvZiBjbGVhcl9iYW1fdHJhbnNhY3Rpb24oKSBpbiB0aGUgZHJpdmVyJ3MKPiA+ ID4gPj4gcWNvbV9uYW5kY19jb21tYW5kKCkgdG8gbWVtc2V0IG11Y2ggbW9yZSB0aGFuIHdoYXQg d2FzIGluaXRpYWxseQo+ID4gPiA+PiBhbGxvY2F0ZWQgYnkgYWxsb2NfYmFtX3RyYW5zYWN0aW9u KCkuICAgIAo+ID4gPiA+IFRoYW5rcyBmb3IgaW52ZXN0aWdhdGluZyEKPiA+ID4gPiAgICAKPiA+ ID4gPj4gVGhpcyBwYXRjaCB3aWxsIHVwZGF0ZSBuYW5kYy0+bWF4X2N3cGVycGFnZSAxIHRvIDQg YWZ0ZXIgbmFuZF9zY2FuKCkKPiA+ID4gPj4gcmV0dXJucywgYW5kIHJlbW92ZSB1cGRhdGluZyBu YW5kYy0+bWF4X2N3cGVycGFnZSBmcm9tCj4gPiA+ID4+IHFjb21fbmFuZF9hdHRhY2hfY2hpcCBj YWxsIGJhY2suICAgIAo+ID4gPiA+IFRoZSBmaXggZG9lcyBub3QgbG9vayByaWdodCwgYXMgZmFy IGFzIEkgdW5kZXJzdGFuZCwgdGhpcyBzaG91bGQgYmUgcHJvcGVybHkgaGFuZGxlZCBkdXJpbmcg dGhlIGF0dGFjaCBwaGFzZS4gVGhhdCBpcyB3aGVyZSB3ZSBoYXZlIGFsbCBpbmZvcm1hdGlvbiBh Ym91dCB0aGUgY2hpcCBhbmQgZG8gdGhlIGNvbmZpZ3VyYXRpb24gZm9yIHRoaXMgY2hpcC4KPiA+ ID4gPgo+ID4gPiA+IElmIHlvdSB1cGRhdGUgbWF4X2N3cGVycGFnZSB0aGVyZSB5b3Ugc2hvdWxk IHByb2JhYmx5IHVwZGF0ZSBvdGhlciBpbnRlcm5hbCB2YXJpYWJsZXMgdGhhdCBkZXBlbmQgb24g aXQgYXMgd2VsbC4gICAgCj4gPiA+IAo+ID4gPiAgwqDCoCBDdXJyZW50bHkgd2UgYXJlIHVwZGF0 aW5nIG1heF9jd3BlcnBhZ2XCoCBpbiBxY29tX25hbmRfYXR0YWNoX2NoaXAoKSwgYnV0IHdlIGFy ZSBzZWVpbmcgaXNzdWUgZm9yIEh5bml4IG5hbmQgZGV2aWNlIHNpbmNlIG5hbmRfc2Nhbl90YWls KCkgaXMgZ2V0dGluZyBjYWxsZWQgYWZ0ZXIgbmFuZF9hdHRhY2goKSBhbmQgaW4gbmFuZF9hdHRh Y2goKSB3ZSBhcmUgdXBkYXRpbmcgbWF4X2N3cGVycGFnZSB0byA0IG9yIDggYmFzZWQgb24gcGFn ZSBzaXplLgo+ID4gPiAKPiA+ID4gIMKgwqDCoCBGcm9tIG5hbmRfc2Nhbl90YWlsKCkgdGhlcmUg aXMgYSBjYWxsIGZvciBuYW5kX21hbnVmYWN0dXJlcl9pbml0KCkgLCBzcGVjaWZpYyB0byBIeW5p eCBuYW5kIHJlYWRfaWQgaXMgZ2V0dGluZyBjYWxsZWQgdGhhdCdzIHdoeSB3ZSBhcmUgc2VlaW5n IHRoaXMgaXNzdWUgb25seSBmb3IgSHluaXggbmFuZCBkZXZpY2UuIFJlYWQgaWQgc2VxdWVuY2Ug YXMgYmVsb3cKPiA+ID4gCj4gPiA+ICDCoMKgIGh5bml4X25hbmRfaGFzX3ZhbGlkX2plZGVjaWQo KQo+ID4gPiAKPiA+ID4gIMKgwqDCoMKgwqDCoMKgIMKgIMKgIMKgIMKgIHwKPiA+ID4gCj4gPiA+ ICDCoMKgIG5hbmRfcmVhZGlkX29wKCkKPiA+ID4gCj4gPiA+ICDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgfAo+ID4gPiAKPiA+ID4gIMKgcWNvbV9uYW5kY19jb21tYW5kKCkKPiA+ID4gCj4gPiA+ ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwKPiA+ID4gCj4gPiA+IHByZV9jb21tYW5kKCkKPiA+ ID4gCj4gPiA+ICDCoMKgwqDCoMKgwqDCoMKgwqAgfAo+ID4gPiAKPiA+ID4gY2xlYXJfYmFtX3Ry YW5zYWN0aW9uKCnCoMKgIC0tPiBJbiB0aGlzIGNhbGwgd2UgYXJlIGRvaW5nIHNnX2luaXRfdGFi bGUoKSB3aGljaCBpcyBjYWxsaW5nIG1lbXNldCgpIGJhc2VkIG9uIG1heF9jd3BlcnBhZ2UuU2lu Y2UgaW5pdGlhbGx5IHdlIGhhdmUgYWxsb2NhdGVkIGJhbSB0cmFuc2FjdGlvbiBhcyBwZXIgbWF4 X2N3cGVycGFnZSA9MSBhbmQgLCBzaW5jZSBuYW5kX2NoaXBfYXR0YWNoKCkgdXBkYXRlZCBtYXhf Y3dwZXJwYWdlLMKgIG5vdyB3ZSBhcmUgZG9pbmcgbWVtc2V0IGFzIHBlciBtYXhfY3dwZXJwYWdl ID0gNCBvciA4Lgo+ID4gPiAKPiA+ID4gCj4gPiA+IFNvIGFueXdheSB3ZSBoYXZlIHRvIHVwZGF0 ZWQgbWF4X2N3cGVycGFnZSBhZnRlciBuYW5kX3NjYW4oKSBjYWxsIG9ubHkuwqAgU2luY2UgdGhl cmUgaXMgbm8gb3RoZXIgZGVwZW5kZW5jeSBvbiBtYXhfY3dwZXJwYWdlIGluIG5hbmRfYXR0YWNo X2NoaXAoKSBhbmQgd2UgYXJlIHVzaW5nIHRoaXMgaW4gYmFtX2FsbG9jKCkgYW5kIGJhbV9jbGVh cigpLiAgCj4gPiAKPiA+IFdoeSBkb24ndCB5b3UgdXBkYXRlIHRoZSBzZyB0YWJsZSBhZnRlciBp bmNyZWFzaW5nIG1heF9jd3BlcnBhZ2U/Cj4gPiAgIAo+IAo+IE9yIHdlIGNvdWxkIG1vdmUgdGhl IGJhbSByZWFsbG9jYXRpb24gaW5zaWRlIHFjb21fbmFuZF9hdHRhY2hfY2hpcCgpIGFzIGJlbG93 PwoKTXVjaCBiZXR0ZXIgYXBwcm9hY2gsIHllcy4KCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv bXRkL25hbmQvcmF3L3Fjb21fbmFuZGMuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L3Fjb21fbmFu ZGMuYwo+IGluZGV4IDdjNmVmYTNiNjI1NS4uNThjMTYwNTQ2MzBmIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvbXRkL25hbmQvcmF3L3Fjb21fbmFuZGMuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQv cmF3L3Fjb21fbmFuZGMuYwo+IEBAIC0yNjUzLDkgKzI2NTMsMjMgQEAgc3RhdGljIGludCBxY29t X25hbmRfYXR0YWNoX2NoaXAoc3RydWN0IG5hbmRfY2hpcCAqY2hpcCkKPiAgCj4gICAgICAgICBt dGRfc2V0X29vYmxheW91dChtdGQsICZxY29tX25hbmRfb29ibGF5b3V0X29wcyk7Cj4gIAo+ICsg ICAgICAgLyogRnJlZSB0aGUgaW5pdGlhbGx5IGFsbG9jYXRlZCBCQU0gdHJhbnNhY3Rpb24gZm9y IHJlYWRpbmcgdGhlIE9ORkkgcGFyYW1zICovCj4gKyAgICAgICBpZiAobmFuZGMtPnByb3BzLT5p c19iYW0pCj4gKyAgICAgICAgICAgICAgIGZyZWVfYmFtX3RyYW5zYWN0aW9uKG5hbmRjKTsKPiAr Cj4gICAgICAgICBuYW5kYy0+bWF4X2N3cGVycGFnZSA9IG1heF90KHVuc2lnbmVkIGludCwgbmFu ZGMtPm1heF9jd3BlcnBhZ2UsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGN3cGVycGFnZSk7Cj4gIAo+ICsgICAgICAgLyogTm93IGFsbG9jYXRlIHRoZSBCQU0gdHJhbnNh Y3Rpb24gYmFzZWQgb24gdXBkYXRlZCBtYXhfY3dwZXJwYWdlICovCj4gKyAgICAgICBpZiAobmFu ZGMtPnByb3BzLT5pc19iYW0pIHsKPiArICAgICAgICAgICAgICAgbmFuZGMtPmJhbV90eG4gPSBh bGxvY19iYW1fdHJhbnNhY3Rpb24obmFuZGMpOwo+ICsgICAgICAgICAgICAgICBpZiAoIW5hbmRj LT5iYW1fdHhuKSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgZGV2X2VycihuYW5kYy0+ZGV2 LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImZhaWxlZCB0byBhbGxvY2F0ZSBi YW0gdHJhbnNhY3Rpb25cbiIpOwo+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRU5P TUVNOwo+ICsgICAgICAgICAgICAgICB9Cj4gKyAgICAgICB9Cj4gKwo+ICAgICAgICAgLyoKPiAg ICAgICAgICAqIERBVEFfVURfQllURVMgdmFyaWVzIGJhc2VkIG9uIHdoZXRoZXIgdGhlIHJlYWQv d3JpdGUgY29tbWFuZCBwcm90ZWN0cwo+ICAgICAgICAgICogc3BhcmUgZGF0YSB3aXRoIEVDQyB0 b28uIFdlIHByb3RlY3Qgc3BhcmUgZGF0YSBieSBkZWZhdWx0LCBzbyB3ZSBzZXQKPiBAQCAtMjk1 NiwxNyArMjk3MCw2IEBAIHN0YXRpYyBpbnQgcWNvbV9uYW5kX2hvc3RfaW5pdF9hbmRfcmVnaXN0 ZXIoc3RydWN0IHFjb21fbmFuZF9jb250cm9sbGVyICpuYW5kYywKPiAgICAgICAgIGlmIChyZXQp Cj4gICAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gIAo+IC0gICAgICAgaWYgKG5hbmRjLT5w cm9wcy0+aXNfYmFtKSB7Cj4gLSAgICAgICAgICAgICAgIGZyZWVfYmFtX3RyYW5zYWN0aW9uKG5h bmRjKTsKPiAtICAgICAgICAgICAgICAgbmFuZGMtPmJhbV90eG4gPSBhbGxvY19iYW1fdHJhbnNh Y3Rpb24obmFuZGMpOwo+IC0gICAgICAgICAgICAgICBpZiAoIW5hbmRjLT5iYW1fdHhuKSB7Cj4g LSAgICAgICAgICAgICAgICAgICAgICAgZGV2X2VycihuYW5kYy0+ZGV2LAo+IC0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgImZhaWxlZCB0byBhbGxvY2F0ZSBiYW0gdHJhbnNhY3Rpb25c biIpOwo+IC0gICAgICAgICAgICAgICAgICAgICAgIG5hbmRfY2xlYW51cChjaGlwKTsKPiAtICAg ICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKPiAtICAgICAgICAgICAgICAgfQo+ IC0gICAgICAgfQo+IC0KPiAgICAgICAgIHJldCA9IG10ZF9kZXZpY2VfcGFyc2VfcmVnaXN0ZXIo bXRkLCBwcm9iZXMsIE5VTEwsIE5VTEwsIDApOwo+ICAgICAgICAgaWYgKHJldCkKPiAgICAgICAg ICAgICAgICAgbmFuZF9jbGVhbnVwKGNoaXApOwo+IAo+IFRoYW5rcywKPiBNYW5pCgoKVGhhbmtz LApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo=