From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@xilinx.com>
Cc: Gagandeep Singh <G.Singh@nxp.com>,
Harold Huang <baymaxhuang@gmail.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] kni: update kernel API to receive packets
Date: Fri, 15 Apr 2022 07:59:59 -0700 [thread overview]
Message-ID: <20220415075959.27778efd@hermes.local> (raw)
In-Reply-To: <d8b536b2-7fd9-204e-65ee-173a6346d5ce@xilinx.com>
On Fri, 15 Apr 2022 13:30:33 +0100
Ferruh Yigit <ferruh.yigit@xilinx.com> wrote:
> >> But this change would cause KNI kernel module does not work in the old kernel
> >> without this patch. I suggested using netif_rx_ni to keep compatibility.
> >
> > netif_rx() API exists from very older versions of kernel before v2.6. There will be
> > no compilation issues. Only difference was, netif_rx_ni() can be used in noninterrupt contexts
> > to improve performance.
>
> May not be compilation issue, but with old kernels won't the behavior be
> different when 'netif_rx_ni()' switched to 'netif_rx()
Probably best handled by #ifdef on kernel version but will be
a mess for backports to distro kernels.
Looks like:
Older -> New
netif_rx_ni netif_rx
neitf_rx __netif_rx
next prev parent reply other threads:[~2022-04-15 15:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 12:23 [PATCH] kni: update kernel API to receive packets Gagandeep Singh
2022-04-15 3:24 ` Harold Huang
2022-04-15 4:07 ` Gagandeep Singh
2022-04-15 12:30 ` Ferruh Yigit
2022-04-15 14:59 ` Stephen Hemminger [this message]
2022-04-18 11:33 ` Gagandeep Singh
2022-04-20 5:03 ` Gagandeep Singh
2022-04-20 7:45 ` Wang, Haiyue
2022-04-20 10:39 ` Gagandeep Singh
2022-04-21 3:45 ` [PATCH v2] " Gagandeep Singh
2022-04-21 8:29 ` Ferruh Yigit
2022-04-21 8:59 ` [PATCH v3] " Gagandeep Singh
2022-05-23 9:15 ` Min Hu (Connor)
2022-06-26 13:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415075959.27778efd@hermes.local \
--to=stephen@networkplumber.org \
--cc=G.Singh@nxp.com \
--cc=baymaxhuang@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.