All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Codina via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/php-apcu: needs threads
Date: Fri, 15 Apr 2022 08:36:57 +0200	[thread overview]
Message-ID: <20220415083657.357a65ce@bootlin.com> (raw)
In-Reply-To: <20220414203059.1818820-1-fontaine.fabrice@gmail.com>

Hi Fabrice,

On Thu, 14 Apr 2022 22:30:59 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> php-apcu needs threads since its addition in commit
> 8ddeeffa186d8bce875ac713c1e71483c618842a:
> 
> In file included from /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.c:20:
> /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.h:41:11: fatal error: pthread.h: No such file or directory
>    41 | # include "pthread.h"
>       |           ^~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/314405423aeece5ee55d76ec5c4fa1919e7ee853
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/php-apcu/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/php-apcu/Config.in b/package/php-apcu/Config.in
> index 6338980222..f8e1eb17bb 100644
> --- a/package/php-apcu/Config.in
> +++ b/package/php-apcu/Config.in
> @@ -1,6 +1,10 @@
>  config BR2_PACKAGE_PHP_APCU
>  	bool "php-apcu"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	help
>  	  APCu is an in-memory key-value store for PHP.
>  
>  	  https://pecl.php.net/package/APCu
> +
> +comment "php-apcu needs a toolchain w/ threads"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS

Acked.

Thanks,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-04-15  6:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 20:30 [Buildroot] [PATCH 1/1] package/php-apcu: needs threads Fabrice Fontaine
2022-04-15  6:36 ` Herve Codina via buildroot [this message]
2022-04-17 19:36   ` Thomas Petazzoni via buildroot
2022-04-18 15:20     ` Herve Codina via buildroot
2022-04-19 20:40 ` Arnout Vandecappelle
2022-05-22 20:19 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220415083657.357a65ce@bootlin.com \
    --to=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=herve.codina@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.