From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [broonie-sound:for-5.19 2/59] sound/soc/codecs/lpass-macro-common.c:28 lpass_macro_pds_init() warn: passing zero to 'PTR_ERR'
Date: Fri, 15 Apr 2022 20:29:13 +0800 [thread overview]
Message-ID: <202204152011.P1CbEWrd-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4836 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
CC: Mark Brown <broonie@kernel.org>
CC: Venkata Prasad Potturu <quic_potturu@quicinc.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.19
head: 19aed2d6cdb72a7c92909832b9480d9cadebeef9
commit: 1a8ee4cf84187bce17c76886eb6dd9389c3b99a8 [2/59] ASoC: codecs: Fix error handling in power domain init and exit handlers
:::::: branch date: 20 hours ago
:::::: commit date: 10 days ago
config: s390-randconfig-m031-20220414 (https://download.01.org/0day-ci/archive/20220415/202204152011.P1CbEWrd-lkp(a)intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
sound/soc/codecs/lpass-macro-common.c:28 lpass_macro_pds_init() warn: passing zero to 'PTR_ERR'
Old smatch warnings:
sound/soc/codecs/lpass-macro-common.c:54 lpass_macro_pds_init() warn: passing zero to 'ERR_PTR'
vim +/PTR_ERR +28 sound/soc/codecs/lpass-macro-common.c
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 13
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 14 struct lpass_macro *lpass_macro_pds_init(struct device *dev)
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 15 {
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 16 struct lpass_macro *l_pds;
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 17 int ret;
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 18
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 19 if (!of_find_property(dev->of_node, "power-domains", NULL))
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 20 return NULL;
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 21
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 22 l_pds = devm_kzalloc(dev, sizeof(*l_pds), GFP_KERNEL);
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 23 if (!l_pds)
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 24 return ERR_PTR(-ENOMEM);
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 25
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 26 l_pds->macro_pd = dev_pm_domain_attach_by_name(dev, "macro");
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 27 if (IS_ERR_OR_NULL(l_pds->macro_pd)) {
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 @28 ret = PTR_ERR(l_pds->macro_pd);
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 29 goto macro_err;
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 30 }
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 31
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 32 ret = pm_runtime_resume_and_get(l_pds->macro_pd);
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 33 if (ret < 0)
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 34 goto macro_sync_err;
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 35
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 36 l_pds->dcodec_pd = dev_pm_domain_attach_by_name(dev, "dcodec");
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 37 if (IS_ERR_OR_NULL(l_pds->dcodec_pd)) {
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 38 ret = PTR_ERR(l_pds->dcodec_pd);
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 39 goto dcodec_err;
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 40 }
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 41
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 42 ret = pm_runtime_resume_and_get(l_pds->dcodec_pd);
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 43 if (ret < 0)
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 44 goto dcodec_sync_err;
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 45 return l_pds;
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 46
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 47 dcodec_sync_err:
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 48 dev_pm_domain_detach(l_pds->dcodec_pd, false);
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 49 dcodec_err:
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 50 pm_runtime_put(l_pds->macro_pd);
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 51 macro_sync_err:
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 52 dev_pm_domain_detach(l_pds->macro_pd, false);
1a8ee4cf84187b Srinivasa Rao Mandadapu 2022-03-22 53 macro_err:
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 54 return ERR_PTR(ret);
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 55 }
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 56 EXPORT_SYMBOL_GPL(lpass_macro_pds_init);
9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 57
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2022-04-15 12:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204152011.P1CbEWrd-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.