[Buildroot] [PATCH] package/urandom-scripts: do not seed if initial seed doesn't exist

From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: peter@korsgaard.com, buildroot@buildroot.org
Cc: Eugen Hristev <Eugen.Hristev@microchip.com>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: [Buildroot] [PATCH] package/urandom-scripts: do not seed if initial seed doesn't exist
Date: Sat, 16 Apr 2022 13:31:38 +0200	[thread overview]
Message-ID: <20220416113138.72159-1-Jason@zx2c4.com> (raw)
In-Reply-To: <87sfqd8eo9.fsf@dell.be.48ers.dk>

By returning a failure in the event that the initial seed doesn't exist,
we'd then skip creating a new seed, which means we'd never in fact have
an initial seed, and this script is therefore useless. Fix this by
checking for the existence of the seed file first, and just returning 0
if it's not there.

Reported-by: Nicolas Cavallari <Nicolas.Cavallari@green-communications.fr>
Reported-by: Eugen Hristev <Eugen.Hristev@microchip.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 package/urandom-scripts/S20urandom | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/urandom-scripts/S20urandom b/package/urandom-scripts/S20urandom
index c6b2ebd48f..6c6aea9eee 100644
--- a/package/urandom-scripts/S20urandom
+++ b/package/urandom-scripts/S20urandom
@@ -18,6 +18,7 @@ else
 fi
 
 init_rng() {
+	[ -f "$URANDOM_SEED" ] || return 0
 	printf 'Initializing random number generator: '
 	dd if="$URANDOM_SEED" bs="$pool_size" of=/dev/urandom count=1 2> /dev/null
 	status=$?
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
