All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Michael Straube <straube.linux@gmail.com>
Subject: [PATCH v4 0/8] staging: r8188eu: fix and clean up some firmware code
Date: Sun, 17 Apr 2022 19:54:33 +0200	[thread overview]
Message-ID: <20220417175441.13830-1-straube.linux@gmail.com> (raw)

This series fixes wrong size of struct rt_firmware_hdr in the first
patch and does some cleanups in rtl8188e_firmware_download() in the
other patches.

Tested on x86_64 with Inter-Tech DMG-02.

v4:
- Keep the in-line comments of struct rt_firmware_hdr.

v3:
- Splitted the first patch into two separate patches.
- Added back logging the firmware version only once.
- Included the compile time check for size of rt_firmware_hdr from
  patch 8/8 of v2 in the patch that replaces the hardcoded size.

v2:
- Added a patch to check size of struct rt_firmware_hdr at compile time.

Michael Straube (8):
  staging: r8188eu: fix struct rt_firmware_hdr
  staging: r8188eu: convert u32 fields of rt_firmware_hdr to __le32
  staging: r8188eu: clean up comments in struct rt_firmware_hdr
  staging: r8188eu: rename fields of struct rt_firmware_hdr
  staging: r8188eu: use sizeof instead of hardcoded firmware header size
  staging: r8188eu: remove variables from rtl8188e_firmware_download()
  staging: r8188eu: use pr_info_once() to log the firmware version
  staging: r8188eu: check firmware header existence before access

 drivers/staging/r8188eu/core/rtw_fw.c | 84 +++++++++++----------------
 1 file changed, 34 insertions(+), 50 deletions(-)

-- 
2.35.1


             reply	other threads:[~2022-04-17 17:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-17 17:54 Michael Straube [this message]
2022-04-17 17:54 ` [PATCH v4 1/8] staging: r8188eu: fix struct rt_firmware_hdr Michael Straube
2022-04-17 17:54 ` [PATCH v4 2/8] staging: r8188eu: convert u32 fields of rt_firmware_hdr to __le32 Michael Straube
2022-04-17 17:54 ` [PATCH v4 3/8] staging: r8188eu: clean up comments in struct rt_firmware_hdr Michael Straube
2022-04-17 17:54 ` [PATCH v4 4/8] staging: r8188eu: rename fields of " Michael Straube
2022-04-17 17:54 ` [PATCH v4 5/8] staging: r8188eu: use sizeof instead of hardcoded firmware header size Michael Straube
2022-04-17 17:54 ` [PATCH v4 6/8] staging: r8188eu: remove variables from rtl8188e_firmware_download() Michael Straube
2022-04-17 17:54 ` [PATCH v4 7/8] staging: r8188eu: use pr_info_once() to log the firmware version Michael Straube
2022-04-17 17:54 ` [PATCH v4 8/8] staging: r8188eu: check firmware header existence before access Michael Straube
2022-04-17 18:24 ` [PATCH v4 0/8] staging: r8188eu: fix and clean up some firmware code Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220417175441.13830-1-straube.linux@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.