From: Christoph Hellwig <hch@lst.de>
To: Zhihao Cheng <chengzhihao1@huawei.com>
Cc: Christoph Hellwig <hch@lst.de>,
viro@zeniv.linux.org.uk, torvalds@linux-foundation.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com
Subject: Re: [PATCH] fs-writeback: Flush plug before next iteration in wb_writeback()
Date: Mon, 18 Apr 2022 07:00:13 +0200 [thread overview]
Message-ID: <20220418050013.GA3372@lst.de> (raw)
In-Reply-To: <71acc295-3a5b-176d-a58e-2aa3ba7627d6@huawei.com>
On Sat, Apr 16, 2022 at 04:41:35PM +0800, Zhihao Cheng wrote:
> So, how about applying the safe and simple method(flush plug) for the time
> being?
As said before - if you flush everytime here the plug is basically
useless and we could remove it. But it was added for a reason. So let's
at least improve the accounting for the skipped writeback as suggested in
your last mail.
prev parent reply other threads:[~2022-04-18 5:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 1:37 [PATCH] fs-writeback: Flush plug before next iteration in wb_writeback() Zhihao Cheng
2022-04-15 6:39 ` Christoph Hellwig
2022-04-15 8:39 ` Zhihao Cheng
2022-04-16 5:42 ` Christoph Hellwig
2022-04-16 8:41 ` Zhihao Cheng
2022-04-18 5:00 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220418050013.GA3372@lst.de \
--to=hch@lst.de \
--cc=chengzhihao1@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.