From: Christoph Hellwig <hch@lst.de>
To: Sven Peter <sven@svenpeter.dev>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Hector Martin <marcan@marcan.st>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Marc Zyngier <maz@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-spdx@vger.kernel.org
Subject: Re: [PATCH v2 6/6] nvme-apple: Add initial Apple SoC NVMe driver
Date: Tue, 19 Apr 2022 07:31:57 +0200 [thread overview]
Message-ID: <20220419053157.GA31530@lst.de> (raw)
In-Reply-To: <20220415142055.30873-7-sven@svenpeter.dev>
On Fri, Apr 15, 2022 at 04:20:55PM +0200, Sven Peter wrote:
> +++ b/drivers/nvme/host/apple.c
> @@ -0,0 +1,1597 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Apple ANS NVM Express device driver
> + * Copyright The Asahi Linux Contributors
Is that actually a valid legal entity?
> +#include <linux/io-64-nonatomic-lo-hi.h>
Does this controller still not support 64-bit MMIO accesses like
the old Apple PCIe controllers or is this just a leftover?
The rest of the code looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Sven Peter <sven@svenpeter.dev>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Hector Martin <marcan@marcan.st>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Marc Zyngier <maz@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-spdx@vger.kernel.org
Subject: Re: [PATCH v2 6/6] nvme-apple: Add initial Apple SoC NVMe driver
Date: Tue, 19 Apr 2022 07:31:57 +0200 [thread overview]
Message-ID: <20220419053157.GA31530@lst.de> (raw)
In-Reply-To: <20220415142055.30873-7-sven@svenpeter.dev>
On Fri, Apr 15, 2022 at 04:20:55PM +0200, Sven Peter wrote:
> +++ b/drivers/nvme/host/apple.c
> @@ -0,0 +1,1597 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Apple ANS NVM Express device driver
> + * Copyright The Asahi Linux Contributors
Is that actually a valid legal entity?
> +#include <linux/io-64-nonatomic-lo-hi.h>
Does this controller still not support 64-bit MMIO accesses like
the old Apple PCIe controllers or is this just a leftover?
The rest of the code looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-19 5:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 14:20 [PATCH v2 0/6] Apple M1 (Pro/Max) NVMe driver Sven Peter
2022-04-15 14:20 ` Sven Peter
2022-04-15 14:20 ` Sven Peter
2022-04-15 14:20 ` [PATCH v2 1/6] dt-bindings: iommu: Add Apple SART DMA address filter Sven Peter
2022-04-15 14:20 ` Sven Peter
2022-04-26 0:56 ` Rob Herring
2022-04-26 0:56 ` Rob Herring
2022-04-15 14:20 ` [PATCH v2 2/6] dt-bindings: nvme: Add Apple ANS NVMe Sven Peter
2022-04-15 14:20 ` Sven Peter
2022-04-26 0:59 ` Rob Herring
2022-04-26 0:59 ` Rob Herring
2022-04-15 14:20 ` [PATCH v2 3/6] soc: apple: Always include Makefile Sven Peter
2022-04-15 14:20 ` Sven Peter
2022-04-15 14:20 ` [PATCH v2 4/6] soc: apple: Add SART driver Sven Peter
2022-04-15 14:20 ` Sven Peter
2022-04-15 14:20 ` [PATCH v2 5/6] soc: apple: Add RTKit IPC library Sven Peter
2022-04-15 14:20 ` Sven Peter
2022-04-15 14:20 ` [PATCH v2 6/6] nvme-apple: Add initial Apple SoC NVMe driver Sven Peter
2022-04-15 14:20 ` Sven Peter
2022-04-19 5:31 ` Christoph Hellwig [this message]
2022-04-19 5:31 ` Christoph Hellwig
2022-04-19 5:59 ` Hector Martin
2022-04-19 5:59 ` Hector Martin
2022-04-19 9:47 ` Sven Peter
2022-04-19 9:47 ` Sven Peter
2022-04-19 9:52 ` Arnd Bergmann
2022-04-19 9:52 ` Arnd Bergmann
2022-04-20 4:34 ` hch
2022-04-20 4:34 ` hch
2022-04-20 9:53 ` Arnd Bergmann
2022-04-20 9:53 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419053157.GA31530@lst.de \
--to=hch@lst.de \
--cc=alyssa@rosenzweig.io \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=devicetree@vger.kernel.org \
--cc=kbusch@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-spdx@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sagi@grimberg.me \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.