drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c:1053:12: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]

All of lore.kernel.org
 help / color / mirror / Atom feed

From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c:1053:12: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
Date: Tue, 19 Apr 2022 10:13:25 +0800	[thread overview]
Message-ID: <202204191037.9JDSPIGa-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 14592 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Alex Deucher <alexander.deucher@amd.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b2d229d4ddb17db541098b83524d901257e93845
commit: d5c7255dc7ff6e1239d794b9c53029d83ced04ca drm/amdgpu/pm: fix powerplay OD interface
date:   5 months ago
:::::: branch date: 29 hours ago
:::::: commit date: 5 months ago
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (cppcheck warning):
        # apt-get install cppcheck
        git checkout d5c7255dc7ff6e1239d794b9c53029d83ced04ca
        cppcheck --quiet --enable=style,performance,portability --template=gcc FILE

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck warnings: (new ones prefixed by >>)
>> drivers/gpu/ipu-v3/ipu-di.c:460:13: warning: Local variable 'div' shadows outer variable [shadowVariable]
      unsigned div;
               ^
   drivers/gpu/ipu-v3/ipu-di.c:441:12: note: Shadowed declaration
     unsigned div, error;
              ^
   drivers/gpu/ipu-v3/ipu-di.c:460:13: note: Shadow variable
      unsigned div;
               ^

cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/i2c/i2c-dev.c:59:16: warning: Uninitialized variable: i2c_dev->adap [uninitvar]
     if (i2c_dev->adap->nr == index)
                  ^
--
   drivers/gpu/ipu-v3/ipu-prv.h:146:25: warning: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned]
    IPU_CONF_CSI_SEL  = (1 << 31),
                           ^
   drivers/gpu/ipu-v3/ipu-prv.h:146:25: warning: Signed integer overflow for expression '1<<31'. [integerOverflow]
    IPU_CONF_CSI_SEL  = (1 << 31),
                           ^
>> drivers/gpu/ipu-v3/ipu-di.c:196:19: warning: Signed integer overflow for expression '0xffff<<(16*((wave_gen-1)&0x1))'. [integerOverflow]
     reg &= ~(0xffff << (16 * ((wave_gen - 1) & 0x1)));
                     ^
--
>> drivers/mmc/core/mmc_test.c:1487:6: warning: The if condition is the same as the previous if condition [duplicateCondition]
    if (timed)
        ^
   drivers/mmc/core/mmc_test.c:1484:6: note: First condition
    if (timed)
        ^
   drivers/mmc/core/mmc_test.c:1487:6: note: Second condition
    if (timed)
        ^
>> drivers/mmc/core/mmc_test.c:3026:51: warning: Parameter 'card' can be declared with const [constParameter]
   static void mmc_test_free_result(struct mmc_card *card)
                                                     ^
   drivers/mmc/core/mmc_test.c:3159:55: warning: Parameter 'card' can be declared with const [constParameter]
   static void mmc_test_free_dbgfs_file(struct mmc_card *card)
                                                         ^
>> drivers/mmc/core/mmc_test.c:3035:19: warning: Uninitialized variable: gr->card [uninitvar]
     if (card && gr->card != card)
                     ^
   drivers/mmc/core/mmc_test.c:3062:11: warning: Uninitialized variable: gr->card [uninitvar]
     if (gr->card != card)
             ^
>> drivers/mmc/core/mmc_test.c:3071:19: warning: Uninitialized variable: tr->iops [uninitvar]
       tr->rate, tr->iops / 100, tr->iops % 100);
                     ^
   drivers/mmc/core/mmc_test.c:3062:16: note: Assuming condition is false
     if (gr->card != card)
                  ^
   drivers/mmc/core/mmc_test.c:3071:19: note: Uninitialized variable: tr->iops
       tr->rate, tr->iops / 100, tr->iops % 100);
                     ^
>> drivers/mmc/core/mmc_test.c:3166:19: warning: Uninitialized variable: df->card [uninitvar]
     if (card && df->card != card)
                     ^
--
   In file included from drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu10_hwmgr.c:
>> drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c:1053:12: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
      size += sprintf(buf + size, "%d: %uMhz %sn",
              ^

vim +1053 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c

a960d61cbd6254 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Rex Zhu      2017-05-11  1016  
c425688520990d drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-03-06  1017  static int smu10_print_clock_levels(struct pp_hwmgr *hwmgr,
a960d61cbd6254 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Rex Zhu      2017-05-11  1018  		enum pp_clock_type type, char *buf)
a960d61cbd6254 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Rex Zhu      2017-05-11  1019  {
c425688520990d drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-03-06  1020  	struct smu10_hwmgr *data = (struct smu10_hwmgr *)(hwmgr->backend);
c425688520990d drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-03-06  1021  	struct smu10_voltage_dependency_table *mclk_table =
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1022  			data->clock_vol_info.vdd_dep_on_fclk;
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1023  	uint32_t i, now, size = 0;
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1024  	uint32_t min_freq, max_freq = 0;
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1025  	uint32_t ret = 0;
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1026  
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1027  	switch (type) {
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1028  	case PP_SCLK:
a0ec225633d9f6 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Evan Quan    2020-03-27  1029  		smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetGfxclkFrequency, &now);
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1030  
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1031  	/* driver only know min/max gfx_clk, Add level 1 for all other gfx clks */
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1032  		if (now == data->gfx_max_freq_limit/100)
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1033  			i = 2;
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1034  		else if (now == data->gfx_min_freq_limit/100)
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1035  			i = 0;
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1036  		else
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1037  			i = 1;
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1038  
d5c7255dc7ff6e drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Alex Deucher 2021-11-23  1039  		size += sprintf(buf + size, "0: %uMhz %s\n",
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1040  					data->gfx_min_freq_limit/100,
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1041  					i == 0 ? "*" : "");
d5c7255dc7ff6e drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Alex Deucher 2021-11-23  1042  		size += sprintf(buf + size, "1: %uMhz %s\n",
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1043  					i == 1 ? now : SMU10_UMD_PSTATE_GFXCLK,
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1044  					i == 1 ? "*" : "");
d5c7255dc7ff6e drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Alex Deucher 2021-11-23  1045  		size += sprintf(buf + size, "2: %uMhz %s\n",
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1046  					data->gfx_max_freq_limit/100,
21c77de3566115 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Rex Zhu      2018-04-20  1047  					i == 2 ? "*" : "");
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1048  		break;
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1049  	case PP_MCLK:
a0ec225633d9f6 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c    Evan Quan    2020-03-27  1050  		smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetFclkFrequency, &now);
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1051  
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1052  		for (i = 0; i < mclk_table->count; i++)
d5c7255dc7ff6e drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Alex Deucher 2021-11-23 @1053  			size += sprintf(buf + size, "%d: %uMhz %s\n",
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1054  					i,
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1055  					mclk_table->entries[i].clk / 100,
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1056  					((mclk_table->entries[i].clk / 100)
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1057  					 == now) ? "*" : "");
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1058  		break;
12a6727dee5d11 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-09-27  1059  	case OD_SCLK:
12a6727dee5d11 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-09-27  1060  		if (hwmgr->od_enabled) {
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1061  			ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetMinGfxclkFrequency, &min_freq);
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1062  			if (ret)
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1063  				return ret;
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1064  			ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetMaxGfxclkFrequency, &max_freq);
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1065  			if (ret)
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1066  				return ret;
12a6727dee5d11 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-09-27  1067  
d5c7255dc7ff6e drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Alex Deucher 2021-11-23  1068  			size += sprintf(buf + size, "%s:\n", "OD_SCLK");
d5c7255dc7ff6e drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Alex Deucher 2021-11-23  1069  			size += sprintf(buf + size, "0: %10uMhz\n",
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1070  			(data->gfx_actual_soft_min_freq > 0) ? data->gfx_actual_soft_min_freq : min_freq);
d5c7255dc7ff6e drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Alex Deucher 2021-11-23  1071  			size += sprintf(buf + size, "1: %10uMhz\n",
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1072  			(data->gfx_actual_soft_max_freq > 0) ? data->gfx_actual_soft_max_freq : max_freq);
12a6727dee5d11 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-09-27  1073  		}
12a6727dee5d11 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-09-27  1074  		break;
12a6727dee5d11 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-09-27  1075  	case OD_RANGE:
12a6727dee5d11 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-09-27  1076  		if (hwmgr->od_enabled) {
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1077  			ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetMinGfxclkFrequency, &min_freq);
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1078  			if (ret)
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1079  				return ret;
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1080  			ret = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_GetMaxGfxclkFrequency, &max_freq);
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1081  			if (ret)
37f5d8b777a9a5 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-12-18  1082  				return ret;
12a6727dee5d11 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-09-27  1083  
d5c7255dc7ff6e drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Alex Deucher 2021-11-23  1084  			size += sprintf(buf + size, "%s:\n", "OD_RANGE");
d5c7255dc7ff6e drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Alex Deucher 2021-11-23  1085  			size += sprintf(buf + size, "SCLK: %7uMHz %10uMHz\n",
12a6727dee5d11 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-09-27  1086  				min_freq, max_freq);
12a6727dee5d11 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-09-27  1087  		}
12a6727dee5d11 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c Xiaojian Du  2020-09-27  1088  		break;
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1089  	default:
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1090  		break;
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1091  	}
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1092  
5f628d997d1e41 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Evan Quan    2017-09-26  1093  	return size;
a960d61cbd6254 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Rex Zhu      2017-05-11  1094  }
a960d61cbd6254 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c       Rex Zhu      2017-05-11  1095  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

next             reply	other threads:[~2022-04-19  2:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19  2:13 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-04-17  6:33 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c:1053:12: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202204191037.9JDSPIGa-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.