From: Stephen Hemminger <stephen@networkplumber.org>
To: Sean Morrissey <sean.morrissey@intel.com>
Cc: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>, dev@dpdk.org
Subject: Re: [PATCH v1 18/19] timer: remove unneeded header includes
Date: Thu, 21 Apr 2022 13:08:27 -0700 [thread overview]
Message-ID: <20220421130827.32634853@hermes.local> (raw)
In-Reply-To: <20220421190859.264174-19-sean.morrissey@intel.com>
On Thu, 21 Apr 2022 19:08:58 +0000
Sean Morrissey <sean.morrissey@intel.com> wrote:
> diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c
> index c51a393e5c..f52ccc33ed 100644
> --- a/lib/timer/rte_timer.c
> +++ b/lib/timer/rte_timer.c
> @@ -5,12 +5,9 @@
> #include <stdio.h>
> #include <stdint.h>
> #include <stdbool.h>
> -#include <inttypes.h>
> #include <assert.h>
> -#include <sys/queue.h>
>
> #include <rte_common.h>
> -#include <rte_cycles.h>
> #include <rte_eal_memconfig.h>
> #include <rte_memory.h>
> #include <rte_lcore.h>
This doesn't look right.
rte_timer.c relies on rte_get_timer_cycles() which is defined in
rte_cycles.h
Perhaps iwyu is getting confused, or thinking that is already covered
by another include file?
next prev parent reply other threads:[~2022-04-21 20:08 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 19:08 [PATCH v1 00/19] remove IWYU flagged headers Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 01/19] cmdline: remove unneeded header includes Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 02/19] eal: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 03/19] ethdev: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 04/19] gpudev: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 05/19] gso: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 06/19] hash: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 07/19] ip_frag: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 08/19] jobstats: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 09/19] mempool: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 10/19] meter: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 11/19] net: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 12/19] power: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 13/19] rawdev: " Sean Morrissey
2022-04-22 4:51 ` Hemant Agrawal
2022-04-21 19:08 ` [PATCH v1 14/19] regexdev: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 15/19] sched: " Sean Morrissey
2022-04-21 19:08 ` [PATCH v1 16/19] stack: " Sean Morrissey
2022-04-21 20:10 ` Stephen Hemminger
2022-04-21 19:08 ` [PATCH v1 17/19] table: " Sean Morrissey
2022-04-21 20:09 ` Stephen Hemminger
2022-04-21 19:08 ` [PATCH v1 18/19] timer: " Sean Morrissey
2022-04-21 20:08 ` Stephen Hemminger [this message]
2022-04-22 8:44 ` Morrissey, Sean
2022-04-21 19:08 ` [PATCH v1 19/19] vhost: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 00/19] remove IWYU flagged headers Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 01/19] cmdline: remove unneeded header includes Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 02/19] eal: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 03/19] ethdev: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 04/19] gpudev: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 05/19] gso: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 06/19] hash: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 07/19] ip_frag: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 08/19] jobstats: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 09/19] mempool: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 10/19] meter: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 11/19] net: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 12/19] power: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 13/19] rawdev: " Sean Morrissey
2022-06-17 4:21 ` Hemant Agrawal
2022-06-16 15:17 ` [PATCH v2 14/19] regexdev: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 15/19] sched: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 16/19] stack: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 17/19] table: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 18/19] timer: " Sean Morrissey
2022-06-16 15:17 ` [PATCH v2 19/19] vhost: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 00/18] remove IWYU flagged headers Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 01/18] cmdline: remove unneeded header includes Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 02/18] eal: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 03/18] ethdev: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 04/18] gpudev: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 05/18] gso: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 06/18] hash: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 07/18] ip_frag: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 08/18] jobstats: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 09/18] meter: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 10/18] net: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 11/18] power: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 12/18] rawdev: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 13/18] regexdev: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 14/18] sched: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 15/18] stack: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 16/18] table: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 17/18] timer: " Sean Morrissey
2022-06-17 19:08 ` [PATCH v3 18/18] vhost: " Sean Morrissey
2022-06-20 1:42 ` Xia, Chenbo
2022-06-20 10:40 ` [PATCH v4 00/14] remove IWYU flagged headers Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 01/14] cmdline: remove unneeded header includes Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 02/14] eal: " Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 03/14] ethdev: " Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 04/14] gpudev: " Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 05/14] gso: " Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 06/14] hash: " Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 07/14] jobstats: " Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 08/14] meter: " Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 09/14] net: " Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 10/14] power: " Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 11/14] rawdev: " Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 12/14] sched: " Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 13/14] timer: " Sean Morrissey
2022-06-20 10:40 ` [PATCH v4 14/14] vhost: " Sean Morrissey
2022-06-21 14:48 ` [PATCH v4 00/14] remove IWYU flagged headers Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421130827.32634853@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=sean.morrissey@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.