From: Andrea Parri <parri.andrea@gmail.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Michael Kelley <mikelley@microsoft.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-hyperv@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] hv_sock: Copy packets sent by Hyper-V out of the ring buffer
Date: Thu, 21 Apr 2022 17:21:17 +0200 [thread overview]
Message-ID: <20220421152117.GA4679@anparri> (raw)
In-Reply-To: <20220421135839.2fj6fk6bvlrau73o@sgarzare-redhat>
> > @@ -378,6 +381,8 @@ static void hvs_open_connection(struct vmbus_channel *chan)
> > rcvbuf = ALIGN(rcvbuf, HV_HYP_PAGE_SIZE);
> > }
> >
> > + chan->max_pkt_size = HVS_MAX_PKT_SIZE;
> > +
>
> premise, I don't know HyperV channels :-(
>
> Is this change necessary to use hv_pkt_iter_first() instead of
> hv_pkt_iter_first_raw()?
Yes, the change is required to initialize the buffer which holds the
copies of the incoming packets (in hv_ringbuffer_init()).
> If yes, then please mention that you set this value in the commit message,
> otherwise maybe better to have a separate patch.
Sure, will do.
Thanks,
Andrea
next prev parent reply other threads:[~2022-04-21 15:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 20:07 [PATCH 0/5] hv_sock: Hardening changes Andrea Parri (Microsoft)
2022-04-20 20:07 ` [PATCH 1/5] hv_sock: Check hv_pkt_iter_first_raw()'s return value Andrea Parri (Microsoft)
2022-04-20 23:07 ` Michael Kelley (LINUX)
2022-04-20 23:07 ` Michael Kelley (LINUX) via Virtualization
2022-04-21 13:50 ` Stefano Garzarella
2022-04-21 13:50 ` Stefano Garzarella
2022-04-20 20:07 ` [PATCH 2/5] hv_sock: Copy packets sent by Hyper-V out of the ring buffer Andrea Parri (Microsoft)
2022-04-20 23:08 ` Michael Kelley (LINUX)
2022-04-20 23:08 ` Michael Kelley (LINUX) via Virtualization
2022-04-21 13:58 ` Stefano Garzarella
2022-04-21 13:58 ` Stefano Garzarella
2022-04-21 15:21 ` Andrea Parri [this message]
2022-04-20 20:07 ` [PATCH 3/5] hv_sock: Add validation for untrusted Hyper-V values Andrea Parri (Microsoft)
2022-04-20 23:09 ` Michael Kelley (LINUX)
2022-04-20 23:09 ` Michael Kelley (LINUX) via Virtualization
2022-04-21 14:08 ` Stefano Garzarella
2022-04-21 14:08 ` Stefano Garzarella
2022-04-21 15:30 ` Andrea Parri
2022-04-21 16:14 ` Stefano Garzarella
2022-04-21 16:14 ` Stefano Garzarella
2022-04-20 20:07 ` [PATCH 4/5] Drivers: hv: vmbus: Accept hv_sock offers in isolated guests Andrea Parri (Microsoft)
2022-04-20 23:10 ` Michael Kelley (LINUX)
2022-04-20 23:10 ` Michael Kelley (LINUX) via Virtualization
2022-04-20 20:07 ` [PATCH 5/5] Drivers: hv: vmbus: Refactor the ring-buffer iterator functions Andrea Parri (Microsoft)
2022-04-20 23:15 ` Michael Kelley (LINUX)
2022-04-20 23:15 ` Michael Kelley (LINUX) via Virtualization
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421152117.GA4679@anparri \
--to=parri.andrea@gmail.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.