From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 184C3C433F5
	for <linux-kernel@archiver.kernel.org>; Sat, 23 Apr 2022 13:27:33 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235746AbiDWNa0 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Sat, 23 Apr 2022 09:30:26 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42118 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S235770AbiDWN2a (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 23 Apr 2022 09:28:30 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64180167E0;
        Sat, 23 Apr 2022 06:25:31 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 9330A611D7;
        Sat, 23 Apr 2022 13:25:30 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98B15C385A5;
        Sat, 23 Apr 2022 13:25:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1650720330;
        bh=zxVPO5bmDECXatmB0RKWLBnS085dQKZW1VzRai5v08M=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=R5+kayZkQBvr37gPmZ+FaFEoi3LGSBZo1BiDxuzOy6am0QFEyTWM20L7gZnXugQHr
         Z/zVy5Q7pvp+Wj8PG7qe9xJqubhp6/HroCzjXyD4i8iiM1v4RDT8NTuboXz6AmGWVx
         YhdXmqwC1P7lzxXPjORq2Y0cRhEkcJZ930z3ghhrS5YqrHsAsMDfLH/NVY/rAg7DyJ
         8nno9NlDqbLmm3lWWEUdZpYfmWWWwuu7f4wv1W25O4dLsLUbgF0iLAsSqJpTkQ64yO
         yh63Ha+I1l+xNFObKpUzWy2GKw/qzwb3yql/RNIOAz9cXE+KnKpQhLbq40RkJQogNx
         Y+dR4YLt83pGQ==
Date:   Sat, 23 Apr 2022 15:25:23 +0200
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     Nathan Rossi <nathan@nathanrossi.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: Skip cmode writable for mv88e6*41
 if unchanged
Message-ID: <20220423152523.1f38e2d8@thinkpad>
In-Reply-To: <20220423132035.238704-1-nathan@nathanrossi.com>
References: <20220423132035.238704-1-nathan@nathanrossi.com>
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 23 Apr 2022 13:20:35 +0000
Nathan Rossi <nathan@nathanrossi.com> wrote:

> The mv88e6341_port_set_cmode function always calls the set writable
> regardless of whether the current cmode is different from the desired
> cmode. This is problematic for specific configurations of the mv88e6341
> and mv88e6141 (in single chip adddressing mode?) where the hidden
> registers are not accessible.

I don't have a problem with skipping setting cmode writable if cmode is
not being changed. But hidden registers should be accessible regardless
of whether you are using single chip addressing mode or not. You need
to find why it isn't working for you, this is a bug.

Marek