From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: axboe@kernel.dk, io-uring@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH] io_uring: cleanup error-handling around io_req_complete
Date: Sat, 23 Apr 2022 19:49:48 +0200 [thread overview]
Message-ID: <20220423174948.GB29219@lst.de> (raw)
In-Reply-To: <20220422101048.419942-1-joshi.k@samsung.com>
On Fri, Apr 22, 2022 at 03:40:48PM +0530, Kanchan Joshi wrote:
> Move common error-handling to io_req_complete, so that various callers
> avoid repeating that. Few callers (io_tee, io_splice) require slightly
> different handling. These are changed to use __io_req_complete instead.
>
> Suggested-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-04-23 17:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220422101608epcas5p22e9c82eb1b3beef6bf6e1c2e83b4b19b@epcas5p2.samsung.com>
2022-04-22 10:10 ` [PATCH] io_uring: cleanup error-handling around io_req_complete Kanchan Joshi
2022-04-23 17:49 ` Christoph Hellwig [this message]
2022-04-23 18:06 ` Jens Axboe
2022-04-24 6:22 ` Kanchan Joshi
2022-04-25 0:32 ` Jens Axboe
2022-04-25 0:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220423174948.GB29219@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.