From: Stephen Hemminger <stephen@networkplumber.org>
To: bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [PATCH net-next v4 2/2] net: vxlan: vxlan_core.c: Add extack support to vxlan_fdb_delete
Date: Mon, 25 Apr 2022 09:06:49 -0700 [thread overview]
Message-ID: <20220425090649.1b99fade@hermes.local> (raw)
In-Reply-To: <a99bfeb371857968a3fa734c00bd9b0e122719c1.1650896000.git.eng.alaamohamedsoliman.am@gmail.com>
On Mon, 25 Apr 2022 16:25:07 +0200
Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com> wrote:
> static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
> union vxlan_addr *ip, __be16 *port, __be32 *src_vni,
> - __be32 *vni, u32 *ifindex, u32 *nhid)
> + __be32 *vni, u32 *ifindex, u32 *nhid, struct netlink_ext_ack *extack)
> {
> struct net *net = dev_net(vxlan->dev);
> int err;
>
> if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] ||
> - tb[NDA_PORT]))
> - return -EINVAL;
> + tb[NDA_PORT])) {
> + NL_SET_ERR_MSG(extack,
> + "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
> + return -EINVAL;
> + }
The indentation is off here?
next prev parent reply other threads:[~2022-04-25 16:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 14:25 [Bridge] [PATCH net-next v4 0/2] propagate extack to vxlan_fdb_delete Alaa Mohamed
2022-04-25 14:25 ` Alaa Mohamed
2022-04-25 14:25 ` [Intel-wired-lan] " Alaa Mohamed
2022-04-25 14:25 ` [Bridge] [PATCH net-next v4 1/2] rtnetlink: add extack support in fdb del handlers Alaa Mohamed
2022-04-25 14:25 ` Alaa Mohamed
2022-04-25 14:25 ` [Intel-wired-lan] " Alaa Mohamed
2022-04-26 10:23 ` kernel test robot
2022-04-26 10:23 ` kernel test robot
2022-04-25 14:25 ` [Bridge] [PATCH net-next v4 2/2] net: vxlan: vxlan_core.c: Add extack support to vxlan_fdb_delete Alaa Mohamed
2022-04-25 14:25 ` Alaa Mohamed
2022-04-25 14:25 ` [Intel-wired-lan] " Alaa Mohamed
2022-04-25 16:06 ` Stephen Hemminger [this message]
2022-04-25 15:48 ` [Bridge] [PATCH net-next v4 0/2] propagate extack " Jakub Kicinski
2022-04-25 15:48 ` Jakub Kicinski
2022-04-25 15:48 ` [Intel-wired-lan] " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425090649.1b99fade@hermes.local \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.