From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDB9BC433EF for ; Mon, 25 Apr 2022 12:56:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 49193833D7; Mon, 25 Apr 2022 14:56:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="iUlsk7n1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 796BB80F91; Mon, 25 Apr 2022 14:56:47 +0200 (CEST) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7E1B883A96 for ; Mon, 25 Apr 2022 14:56:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x732.google.com with SMTP id a186so10629523qkc.10 for ; Mon, 25 Apr 2022 05:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ha1zopjR8a0N2xQMmWqd+y3XRd8F37zis2zGb46CXdM=; b=iUlsk7n1/znQhcbUBajnlatF46SgRdwJ0obSBMJSGTzQe7DIutb/GVYMxgtOscadTz xV165HhsuNMAeaux3CcJqHuvbtzJBWRTPlvownT6iTAO1UzvNUm4eMJ5iio0k5cBpzyA 4Wx9c7FYxaJHdJe3XNz9gM1CxmrwZkSNSZmBU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ha1zopjR8a0N2xQMmWqd+y3XRd8F37zis2zGb46CXdM=; b=2MzjNpabIDMdEviDEWLHOkNw8kGNhOONL6MNOfesBHqFAENdIvfn6TBlX1ThIhnFM+ M8f0bqn0uF9t1pfFfhS6lc8lEvqIsT/o3MnRl8Oug277JYnJo/QQU0Aq1vhcTw4a44Ff 4t1yiLdnzFikqiAZhsVDqrKMwDYnITBEGc/Fr9NrfGkh97VMmg74foJfjRvSZ8VIUwZ9 eeChMnYj3+SboAbEnUCDouzamCLz5pfbdf+v2QYyLuBxS1CTnEkQv0nayzEm97orc+Vc PGCrhW29B2jkv2XI802sdIJYK6UeLok0O/3WzL9LC43k/DRlA/7jNU/CvjYkT+WrooIm pQIg== X-Gm-Message-State: AOAM531TX2UQphlwxCBTkvdJUGG+ixkBZ/HcRlohIL7paXHwrUbBfxBa 2cvpbz9EjzK5gnJWU8NYW0lgP4J6gkB2HQ== X-Google-Smtp-Source: ABdhPJxqPj0dKdUafdqbgvkk+0gfafSYzlPbhxylRW7IrXuK4xkWCjKX4x30Eux05ysY6ohvcU3CTQ== X-Received: by 2002:a05:620a:6db:b0:69e:84e3:5059 with SMTP id 27-20020a05620a06db00b0069e84e35059mr9835198qky.709.1650891399247; Mon, 25 Apr 2022 05:56:39 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id j62-20020a378741000000b0069ebd098171sm5044858qkd.8.2022.04.25.05.56.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 05:56:38 -0700 (PDT) Date: Mon, 25 Apr 2022 08:56:36 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Fabio Estevam , Peng Fan , Stefano Babic Subject: Re: [PATCH] ARM: imx: imx8q: Use LPUART_BASE macro in config files Message-ID: <20220425125636.GC6921@bill-the-cat> References: <20220424214310.52628-1-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YZ5djTAD1cGYuMQK" Content-Disposition: inline In-Reply-To: <20220424214310.52628-1-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 24, 2022 at 11:43:10PM +0200, Marek Vasut wrote: > Replace ad-hoc value with LPUART_BASE macro, no functional change. >=20 > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Peng Fan > Cc: Stefano Babic > Cc: Tom Rini > --- > include/configs/cgtqmx8.h | 2 +- > include/configs/imx8qm_mek.h | 4 ++-- > include/configs/imx8qxp_mek.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/include/configs/cgtqmx8.h b/include/configs/cgtqmx8.h > index 6da0483ef09..db2555c23cc 100644 > --- a/include/configs/cgtqmx8.h > +++ b/include/configs/cgtqmx8.h > @@ -20,7 +20,7 @@ > #define CONFIG_SPL_BSS_MAX_SIZE 0x1000 /* 4 KB */ > #define CONFIG_SYS_SPL_MALLOC_START 0x00120000 > #define CONFIG_SYS_SPL_MALLOC_SIZE 0x3000 /* 12 KB */ > -#define CONFIG_SERIAL_LPUART_BASE 0x5a060000 > +#define CONFIG_SERIAL_LPUART_BASE LPUART_BASE > #define CONFIG_MALLOC_F_ADDR 0x00120000 > =20 > #define CONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE > diff --git a/include/configs/imx8qm_mek.h b/include/configs/imx8qm_mek.h > index 61d56e269ac..b9ad61ce501 100644 > --- a/include/configs/imx8qm_mek.h > +++ b/include/configs/imx8qm_mek.h > @@ -21,7 +21,7 @@ > #define CONFIG_SPL_BSS_MAX_SIZE 0x1000 /* 4 KB */ > #define CONFIG_SYS_SPL_MALLOC_START 0x00120000 > #define CONFIG_SYS_SPL_MALLOC_SIZE 0x3000 /* 12 KB */ > -#define CONFIG_SERIAL_LPUART_BASE 0x5a060000 > +#define CONFIG_SERIAL_LPUART_BASE LPUART_BASE > #define CONFIG_MALLOC_F_ADDR 0x00120000 > =20 > #define CONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE > @@ -41,7 +41,7 @@ > "script=3Dboot.scr\0" \ > "image=3DImage\0" \ > "panel=3DNULL\0" \ > - "console=3DttyLP0,${baudrate} earlycon=3Dlpuart32,0x5a060000,${baudrate= }\0" \ > + "console=3DttyLP0,${baudrate} earlycon=3Dlpuart32," __stringify(LPUART_= BASE) ",${baudrate}\0" \ > "fdt_addr=3D0x83000000\0" \ > "fdt_high=3D0xffffffffffffffff\0" \ > "boot_fdt=3Dtry\0" \ > diff --git a/include/configs/imx8qxp_mek.h b/include/configs/imx8qxp_mek.h > index 26dc4ded030..11a8ac50691 100644 > --- a/include/configs/imx8qxp_mek.h > +++ b/include/configs/imx8qxp_mek.h > @@ -19,7 +19,7 @@ > #define CONFIG_SPL_BSS_MAX_SIZE 0x1000 /* 4 KB */ > #define CONFIG_SYS_SPL_MALLOC_START 0x00120000 > #define CONFIG_SYS_SPL_MALLOC_SIZE 0x3000 /* 12 KB */ > -#define CONFIG_SERIAL_LPUART_BASE 0x5a060000 > +#define CONFIG_SERIAL_LPUART_BASE LPUART_BASE > #define CONFIG_MALLOC_F_ADDR 0x00120000 > =20 > #define CONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE This kind of change makes Kconfig migration harder for moveconfig.py to handle. I don't see CONFIG_SERIAL_LPUART_BASE used in code, so we should just drop it. And so far as we're consistent about how to pass earlycon info, we just put the raw address, but I don't strongly object to __stringify(LPUART_BASE) as it is clearer, and handling the default env part of board config.h has its own challenges more broadly. --=20 Tom --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJmmnoACgkQFHw5/5Y0 tyz3KgwAkr0G/rJNLEGXIxO8VEQlXkgqbuWPbv/1qOqwHieySE3GR0wnUypO+jQX nnRSQR6jUA3Mpn8JANYJjItqR5ymQrhhbeKzSwBP26KeED1kS+CN7OEVbunRGBkk oKCrwFKnvNDtyU2Tzfz1iYB7vxKGxh1droEG/taGjMwPZYvYB+CsRVUwQmq3veMo RKAwNrR5VvEo4ItF2T/7qHKAOMAsvC0KH2xHljXsdbbcVsM8UZY91KSXzXDfK2O4 5QIQSt9Uq7lxzVvhlEPrIrmnFVIvI9OE+FB4pN3op+SUH1aE35Josvuh0lqGf0NZ 5brdHIG2x4KaxbVQcuFuaQ7CfFTqTg4E+NUXr9+HYzS96I2PhRLXeUXQSddO0484 O6SupzUcq8W8mta5yJgoc7W445ewvXKs5a0rXfNeIrkcLJ2xf8AFFBkLVVIhaTdz p+L2CArIXbxq5ffNwDgpc0SCyZHU1RxPO2JgmHr3idhGQJdqGjCMpk5aMQWEcMbT 8FIHgFSe =CVdp -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK--