All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beau Belgrave <beaub@linux.microsoft.com>
To: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com
Cc: linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, beaub@linux.microsoft.com
Subject: [PATCH v2 3/7] tracing/user_events: Use WRITE instead of READ for io vector import
Date: Mon, 25 Apr 2022 11:46:27 -0700	[thread overview]
Message-ID: <20220425184631.2068-4-beaub@linux.microsoft.com> (raw)
In-Reply-To: <20220425184631.2068-1-beaub@linux.microsoft.com>

import_single_range expects the direction/rw to be where it came from,
not the protection/limit. Since the import is in a write path use WRITE.

Link: https://lore.kernel.org/all/2059213643.196683.1648499088753.JavaMail.zimbra@efficios.com/

Reported-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Beau Belgrave <beaub@linux.microsoft.com>
---
 kernel/trace/trace_events_user.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c
index 075d694d20e3..15edbf6b1e2e 100644
--- a/kernel/trace/trace_events_user.c
+++ b/kernel/trace/trace_events_user.c
@@ -1245,7 +1245,8 @@ static ssize_t user_events_write(struct file *file, const char __user *ubuf,
 	if (unlikely(*ppos != 0))
 		return -EFAULT;
 
-	if (unlikely(import_single_range(READ, (char *)ubuf, count, &iov, &i)))
+	if (unlikely(import_single_range(WRITE, (char __user *)ubuf,
+					 count, &iov, &i)))
 		return -EFAULT;
 
 	return user_events_write_core(file, &i);
-- 
2.25.1


  parent reply	other threads:[~2022-04-25 18:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 18:46 [PATCH v2 0/7] tracing/user_events: Update user_events ABI from Beau Belgrave
2022-04-25 18:46 ` [PATCH v2 1/7] tracing/user_events: Fix repeated word in comments Beau Belgrave
2022-04-25 18:46 ` [PATCH v2 2/7] tracing/user_events: Use NULL for strstr checks Beau Belgrave
2022-04-25 18:46 ` Beau Belgrave [this message]
2022-04-25 18:46 ` [PATCH v2 4/7] tracing/user_events: Ensure user provided strings are safely formatted Beau Belgrave
2022-04-25 18:46 ` [PATCH v2 5/7] tracing/user_events: Use refcount instead of atomic for ref tracking Beau Belgrave
2022-04-25 18:46 ` [PATCH v2 6/7] tracing/user_events: Use bits vs bytes for enabled status page data Beau Belgrave
2022-07-26 22:01   ` Steven Rostedt
2022-07-27  0:02     ` Beau Belgrave
2022-07-27  0:14       ` Steven Rostedt
2022-07-27  2:01         ` Beau Belgrave
2022-07-27 13:45           ` Steven Rostedt
2022-07-27 19:01             ` Beau Belgrave
2022-04-25 18:46 ` [PATCH v2 7/7] tracing/user_events: Update ABI documentation to align to bits vs bytes Beau Belgrave

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220425184631.2068-4-beaub@linux.microsoft.com \
    --to=beaub@linux.microsoft.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.