From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B09B5C433EF for ; Mon, 25 Apr 2022 18:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LRBDjhn/9XvuQycJie9i+baYAtKY43WpJBS/LUoYI3g=; b=ul3JUKsK8A8jtk Uvcq8WVXDUJAmHlxX+ydg3Re2kWxAjcNXvLgQKT15LNkxPKwwBx5iEiCUjE+Sf3TFgQH4+o/JiXos K4vJ7ijGv1nMKhevSW994kbrATUyZhKQGET3SdQhzxKMGsyteSrua/Ffkv+mG7MjtC+awrIX9KxwY J2FwDbFHnEj/+54QBz30GAcIyuOT/yRxyUYLt18MltrauDVO5+7CL8rCpPQppCEIMYoglaZT3JmH4 LavEq+Y4FxdwM+x2Hw8wNVE7HhK+i9I/tdmGiEZGMiqFV3BtF5/9z70I3/YEGGNgzKd57TDkvVqFa tXgp7ti4nRZTBZfyIhBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj36W-00An0B-6w; Mon, 25 Apr 2022 18:06:32 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj36R-00Amz4-Nk for linux-arm-kernel@lists.infradead.org; Mon, 25 Apr 2022 18:06:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650909987; x=1682445987; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rrOdhDVkrjSqoJ/S0GscDU5/gE99xaEHwiNxAV66yds=; b=L0AEbTcSGjvsLxPnGJVaLh1UTCGaNVQLkLU21aa1JWEVt75zqYP5eGct vxY8N6wRIB6F56BqjzrgxQhYW4JLaU2c2bBaSt9XP+cBFE904JoqZt3wa jgO9Vfexk+04SFaVx9cxzWUnttnlgOSDYYD05qSVmhqRTnGb0xZd7jOO5 GFSWJXgCoTEttzIWPWXGCO61g2Fj5kS4rxG22zqvAMCvumr7kN5bDLyT4 WnRnmo4plF/N7xUKMcH0Vr5SwwNOIBd3WRzr6sb19jSI61JcFaw72EKzJ 3E/ZIv4fGwlplv6QwDhXsptHZunSUkUpHlOPrmimk+0iuMSvyAowE7mUq A==; X-IronPort-AV: E=McAfee;i="6400,9594,10328"; a="264174278" X-IronPort-AV: E=Sophos;i="5.90,289,1643702400"; d="scan'208";a="264174278" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2022 11:06:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,289,1643702400"; d="scan'208";a="704670374" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 25 Apr 2022 11:06:24 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nj36N-0002kk-RW; Mon, 25 Apr 2022 18:06:23 +0000 Date: Tue, 26 Apr 2022 02:05:25 +0800 From: kernel test robot To: cgel.zte@gmail.com, daniel@thingy.jp Cc: kbuild-all@lists.01.org, romain.perier@gmail.com, daniel.lezcano@linaro.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: Re: [PATCH] clocksource/drivers: remove unnecessary return in switch statement Message-ID: <202204260158.ccGqDClt-lkp@intel.com> References: <20220425084644.3495153-1-chi.minghao@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220425084644.3495153-1-chi.minghao@zte.com.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220425_110627_829935_0561CA84 X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/timers/core] [also build test WARNING on v5.18-rc4 next-20220422] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/cgel-zte-gmail-com/clocksource-drivers-remove-unnecessary-return-in-switch-statement/20220425-170540 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ce8abf340e40e1126bfcb9e7679b3d6b524ae3e0 config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220426/202204260158.ccGqDClt-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/f185e49aea517bee5dfb706df47fa5f70bfac370 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review cgel-zte-gmail-com/clocksource-drivers-remove-unnecessary-return-in-switch-statement/20220425-170540 git checkout f185e49aea517bee5dfb706df47fa5f70bfac370 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/clocksource/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/clocksource/timer-msc313e.c: In function 'msc313e_timer_init': >> drivers/clocksource/timer-msc313e.c:230:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 230 | int ret = 0; | ^~~ vim +/ret +230 drivers/clocksource/timer-msc313e.c 5fc1f93f69989e Romain Perier 2021-12-17 227 5fc1f93f69989e Romain Perier 2021-12-17 228 static int __init msc313e_timer_init(struct device_node *np) 5fc1f93f69989e Romain Perier 2021-12-17 229 { 5fc1f93f69989e Romain Perier 2021-12-17 @230 int ret = 0; 5fc1f93f69989e Romain Perier 2021-12-17 231 static int num_called; 5fc1f93f69989e Romain Perier 2021-12-17 232 5fc1f93f69989e Romain Perier 2021-12-17 233 switch (num_called) { 5fc1f93f69989e Romain Perier 2021-12-17 234 case 0: 5fc1f93f69989e Romain Perier 2021-12-17 235 ret = msc313e_clksrc_init(np); 5fc1f93f69989e Romain Perier 2021-12-17 236 break; 5fc1f93f69989e Romain Perier 2021-12-17 237 5fc1f93f69989e Romain Perier 2021-12-17 238 default: 5fc1f93f69989e Romain Perier 2021-12-17 239 ret = msc313e_clkevt_init(np); 5fc1f93f69989e Romain Perier 2021-12-17 240 break; 5fc1f93f69989e Romain Perier 2021-12-17 241 } 5fc1f93f69989e Romain Perier 2021-12-17 242 5fc1f93f69989e Romain Perier 2021-12-17 243 num_called++; 5fc1f93f69989e Romain Perier 2021-12-17 244 5fc1f93f69989e Romain Perier 2021-12-17 245 return 0; 5fc1f93f69989e Romain Perier 2021-12-17 246 } 5fc1f93f69989e Romain Perier 2021-12-17 247 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 214C7C433F5 for ; Mon, 25 Apr 2022 18:06:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244219AbiDYSJi (ORCPT ); Mon, 25 Apr 2022 14:09:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237543AbiDYSJb (ORCPT ); Mon, 25 Apr 2022 14:09:31 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14F5138BCA for ; Mon, 25 Apr 2022 11:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650909987; x=1682445987; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rrOdhDVkrjSqoJ/S0GscDU5/gE99xaEHwiNxAV66yds=; b=L0AEbTcSGjvsLxPnGJVaLh1UTCGaNVQLkLU21aa1JWEVt75zqYP5eGct vxY8N6wRIB6F56BqjzrgxQhYW4JLaU2c2bBaSt9XP+cBFE904JoqZt3wa jgO9Vfexk+04SFaVx9cxzWUnttnlgOSDYYD05qSVmhqRTnGb0xZd7jOO5 GFSWJXgCoTEttzIWPWXGCO61g2Fj5kS4rxG22zqvAMCvumr7kN5bDLyT4 WnRnmo4plF/N7xUKMcH0Vr5SwwNOIBd3WRzr6sb19jSI61JcFaw72EKzJ 3E/ZIv4fGwlplv6QwDhXsptHZunSUkUpHlOPrmimk+0iuMSvyAowE7mUq A==; X-IronPort-AV: E=McAfee;i="6400,9594,10328"; a="325813053" X-IronPort-AV: E=Sophos;i="5.90,289,1643702400"; d="scan'208";a="325813053" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2022 11:06:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,289,1643702400"; d="scan'208";a="704670374" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 25 Apr 2022 11:06:24 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nj36N-0002kk-RW; Mon, 25 Apr 2022 18:06:23 +0000 Date: Tue, 26 Apr 2022 02:05:25 +0800 From: kernel test robot To: cgel.zte@gmail.com, daniel@thingy.jp Cc: kbuild-all@lists.01.org, romain.perier@gmail.com, daniel.lezcano@linaro.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: Re: [PATCH] clocksource/drivers: remove unnecessary return in switch statement Message-ID: <202204260158.ccGqDClt-lkp@intel.com> References: <20220425084644.3495153-1-chi.minghao@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220425084644.3495153-1-chi.minghao@zte.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/timers/core] [also build test WARNING on v5.18-rc4 next-20220422] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/cgel-zte-gmail-com/clocksource-drivers-remove-unnecessary-return-in-switch-statement/20220425-170540 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ce8abf340e40e1126bfcb9e7679b3d6b524ae3e0 config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220426/202204260158.ccGqDClt-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/f185e49aea517bee5dfb706df47fa5f70bfac370 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review cgel-zte-gmail-com/clocksource-drivers-remove-unnecessary-return-in-switch-statement/20220425-170540 git checkout f185e49aea517bee5dfb706df47fa5f70bfac370 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/clocksource/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/clocksource/timer-msc313e.c: In function 'msc313e_timer_init': >> drivers/clocksource/timer-msc313e.c:230:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 230 | int ret = 0; | ^~~ vim +/ret +230 drivers/clocksource/timer-msc313e.c 5fc1f93f69989e Romain Perier 2021-12-17 227 5fc1f93f69989e Romain Perier 2021-12-17 228 static int __init msc313e_timer_init(struct device_node *np) 5fc1f93f69989e Romain Perier 2021-12-17 229 { 5fc1f93f69989e Romain Perier 2021-12-17 @230 int ret = 0; 5fc1f93f69989e Romain Perier 2021-12-17 231 static int num_called; 5fc1f93f69989e Romain Perier 2021-12-17 232 5fc1f93f69989e Romain Perier 2021-12-17 233 switch (num_called) { 5fc1f93f69989e Romain Perier 2021-12-17 234 case 0: 5fc1f93f69989e Romain Perier 2021-12-17 235 ret = msc313e_clksrc_init(np); 5fc1f93f69989e Romain Perier 2021-12-17 236 break; 5fc1f93f69989e Romain Perier 2021-12-17 237 5fc1f93f69989e Romain Perier 2021-12-17 238 default: 5fc1f93f69989e Romain Perier 2021-12-17 239 ret = msc313e_clkevt_init(np); 5fc1f93f69989e Romain Perier 2021-12-17 240 break; 5fc1f93f69989e Romain Perier 2021-12-17 241 } 5fc1f93f69989e Romain Perier 2021-12-17 242 5fc1f93f69989e Romain Perier 2021-12-17 243 num_called++; 5fc1f93f69989e Romain Perier 2021-12-17 244 5fc1f93f69989e Romain Perier 2021-12-17 245 return 0; 5fc1f93f69989e Romain Perier 2021-12-17 246 } 5fc1f93f69989e Romain Perier 2021-12-17 247 -- 0-DAY CI Kernel Test Service https://01.org/lkp