All of lore.kernel.org
 help / color / mirror / Atom feed
From: Almog Khaikin <almogkh@gmail.com>
To: axboe@kernel.dk
Cc: io-uring@vger.kernel.org
Subject: [PATCH] io_uring: replace smp_mb() with smp_mb__after_atomic() in io_sq_thread()
Date: Tue, 26 Apr 2022 19:34:03 +0300	[thread overview]
Message-ID: <20220426163403.112692-1-almogkh@gmail.com> (raw)

The IORING_SQ_NEED_WAKEUP flag is now set using atomic_or() which
implies a full barrier on some architectures but it is not required to
do so. Use the more appropriate smp_mb__after_atomic() which avoids the
extra barrier on those architectures.

Signed-off-by: Almog Khaikin <almogkh@gmail.com>
---
 fs/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 72cb2d50125c..1e7466079af7 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -8229,7 +8229,7 @@ static int io_sq_thread(void *data)
 				 * Ensure the store of the wakeup flag is not
 				 * reordered with the load of the SQ tail
 				 */
-				smp_mb();
+				smp_mb__after_atomic();
 
 				if (io_sqring_entries(ctx)) {
 					needs_sched = false;

base-commit: 6f07a54a90ee98ae13b37ac358624d7cc7e57850
-- 
2.36.0


             reply	other threads:[~2022-04-26 16:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 16:34 Almog Khaikin [this message]
2022-04-26 17:04 ` [PATCH] io_uring: replace smp_mb() with smp_mb__after_atomic() in io_sq_thread() Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220426163403.112692-1-almogkh@gmail.com \
    --to=almogkh@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.