From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Baruch Siach via buildroot <buildroot@buildroot.org>
Cc: "José Luis Salvador Rufo" <salvador.joseluis@gmail.com>,
"Thomas De Schampheleire" <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH 1/1] docs/manual/prerequisite.txt: add diffutils
Date: Wed, 27 Apr 2022 00:01:59 +0200 [thread overview]
Message-ID: <20220427000159.58749c28@windsurf> (raw)
In-Reply-To: <87bkwn21vp.fsf@tarshish>
Hello,
On Tue, 26 Apr 2022 20:16:12 +0300
Baruch Siach via buildroot <buildroot@buildroot.org> wrote:
> Hi José,
>
> On Tue, Apr 26 2022, José Luis Salvador Rufo wrote:
> > Patch title: docs/manual/prerequisite.txt: add diffutils
>
> No need for this line in the commit log body. The email subject line
> appears as head line of the git commit once applied.
Yep.
> > The command `cmp` is used by `package/pkg-generic.mk` at commit
> > 8623cc5deb5. This command is provided by `diffutils`.
>
> Actually, we have host-diffutils, so we can build cmp if the host does
> not have it installed. All we need is support added under
> support/dependencies/ like a few other utilities.
Yes, but we're not going to build host-diffutils if cmp is missing.
It's not done in our current implementation, and I don't think we want
to do that. So it seems like diffutils is indeed a hard requirement.
> We also don't list findutils as prerequisite, even though we rely
> heavily on the 'find' utility.
So perhaps we should list findutils as well in our hard requirements?
José Luis: practically speaking, with which distribution have you been
able to get a system without diffutils/findutils installed by default?
Thanks,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-04-26 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 13:28 [Buildroot] [PATCH 1/1] docs/manual/prerequisite.txt: add diffutils José Luis Salvador Rufo
2022-04-26 17:16 ` Baruch Siach via buildroot
2022-04-26 22:01 ` Thomas Petazzoni via buildroot [this message]
2022-04-27 4:34 ` Baruch Siach via buildroot
2022-04-27 6:22 ` José Luis Salvador Rufo
2022-07-26 22:04 ` Thomas Petazzoni via buildroot
2022-08-29 11:15 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427000159.58749c28@windsurf \
--to=buildroot@buildroot.org \
--cc=salvador.joseluis@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.