All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wayne Lin <Wayne.Lin@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: stylon.wang@amd.com, Jayendran Ramani <Jayendran.Ramani@amd.com>,
	Evgenii Krasnikov <Evgenii.Krasnikov@amd.com>,
	Sunpeng.Li@amd.com, Harry.Wentland@amd.com,
	qingqing.zhuo@amd.com, Rodrigo.Siqueira@amd.com,
	roman.li@amd.com, solomon.chiu@amd.com, Aurabindo.Pillai@amd.com,
	Harry Vanzylldejong <Harry.Vanzylldejong@amd.com>,
	wayne.lin@amd.com, Bhawanpreet.Lakha@amd.com,
	agustin.gutierrez@amd.com, pavle.kotarac@amd.com
Subject: [PATCH 3/8] Revert "drm/amd/display: Reset cached PSR parameters after hibernate"
Date: Wed, 27 Apr 2022 11:00:54 +0800	[thread overview]
Message-ID: <20220427030059.1242868-4-Wayne.Lin@amd.com> (raw)
In-Reply-To: <20220427030059.1242868-1-Wayne.Lin@amd.com>

From: Evgenii Krasnikov <Evgenii.Krasnikov@amd.com>

This reverts commit cee342f2d6a8b57ef8209720d5892d0ee22fd3c8.

Commit cee342f2d6a8 ("drm/amd/display: Reset cached PSR parameters
after hibernate") causes a system hang when game resolution is
changed. Revert it.

Reviewed-by: Jayendran Ramani <Jayendran.Ramani@amd.com>
Reviewed-by: Harry Vanzylldejong <Harry.Vanzylldejong@amd.com>
Acked-by: Wayne Lin <wayne.lin@amd.com>
Signed-off-by: Evgenii Krasnikov <Evgenii.Krasnikov@amd.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc_link.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index 1eddf2785153..3d13ee32a3db 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -3317,14 +3317,9 @@ bool dc_link_setup_psr(struct dc_link *link,
 	 */
 	psr_context->frame_delay = 0;
 
-	if (psr) {
+	if (psr)
 		link->psr_settings.psr_feature_enabled = psr->funcs->psr_copy_settings(psr,
 			link, psr_context, panel_inst);
-		if (link->psr_settings.psr_feature_enabled) {
-			link->psr_settings.psr_power_opt = 0;
-			link->psr_settings.psr_allow_active = 0;
-		}
-	}
 	else
 		link->psr_settings.psr_feature_enabled = dmcu->funcs->setup_psr(dmcu, link, psr_context);
 
-- 
2.36.0


  parent reply	other threads:[~2022-04-27  3:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27  3:00 [PATCH v2 0/8] DC Patches April 27, 2022 Wayne Lin
2022-04-27  3:00 ` [PATCH 1/8] drm/amd/display: Make OPTC3 function accessible to other DCN Wayne Lin
2022-04-27  3:00 ` [PATCH 2/8] drm/amd/display: Add Connection Manager boot option Wayne Lin
2022-04-27  3:00 ` Wayne Lin [this message]
2022-04-27  3:00 ` [PATCH 4/8] drm/amd/display: Remove outdated register for dcn3+ Wayne Lin
2022-04-27  3:00 ` [PATCH 5/8] drm/amd/display: Add new DSC interface to disconnect from pipe Wayne Lin
2022-04-27  3:00 ` [PATCH 6/8] drm/amd/display: Clean up pixel format types Wayne Lin
2022-04-27  3:00 ` [PATCH 7/8] drm/amd/display: [FW Promotion] Release 0.0.115.0 Wayne Lin
2022-04-27  3:00 ` [PATCH 8/8] drm/amd/display: 3.2.184 Wayne Lin
  -- strict thread matches above, loose matches on Subject: below --
2022-04-27  2:39 [PATCH 0/8] DC Patches April 27, 2022 Wayne Lin
2022-04-27  2:39 ` [PATCH 3/8] Revert "drm/amd/display: Reset cached PSR parameters after hibernate" Wayne Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220427030059.1242868-4-Wayne.Lin@amd.com \
    --to=wayne.lin@amd.com \
    --cc=Aurabindo.Pillai@amd.com \
    --cc=Bhawanpreet.Lakha@amd.com \
    --cc=Evgenii.Krasnikov@amd.com \
    --cc=Harry.Vanzylldejong@amd.com \
    --cc=Harry.Wentland@amd.com \
    --cc=Jayendran.Ramani@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Sunpeng.Li@amd.com \
    --cc=agustin.gutierrez@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=pavle.kotarac@amd.com \
    --cc=qingqing.zhuo@amd.com \
    --cc=roman.li@amd.com \
    --cc=solomon.chiu@amd.com \
    --cc=stylon.wang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.