From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: meta-virtualization@lists.yoctoproject.org, nd@arm.com
Subject: Re: [meta-virtualization] [PATCH] xen: Add missing space in append to IMAGE_INSTALL
Date: Tue, 26 Apr 2022 23:04:00 -0400 [thread overview]
Message-ID: <20220427030359.GD55546@gmail.com> (raw)
In-Reply-To: <bba589c4be43035a5b84d5d470a0d62c2f14cd83.1650644264.git.bertrand.marquis@arm.com>
merged.
Bruce
In message: [meta-virtualization] [PATCH] xen: Add missing space in append to IMAGE_INSTALL
on 22/04/2022 Bertrand Marquis wrote:
> Add a space before doing an append in IMAGE_INSTALL on x86.
> This is solving issues happening if someone is using IMAGE_INSTALL in
> local.conf to add things to the generated image.
>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
> recipes-extended/images/xen-image-minimal.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-extended/images/xen-image-minimal.bb b/recipes-extended/images/xen-image-minimal.bb
> index f6fa5ed..3cf4230 100644
> --- a/recipes-extended/images/xen-image-minimal.bb
> +++ b/recipes-extended/images/xen-image-minimal.bb
> @@ -21,8 +21,8 @@ IMAGE_INSTALL += " \
> do_build[depends] += "xen:do_deploy"
>
> # Networking for HVM-mode guests (x86/64 only) requires the tun kernel module
> -IMAGE_INSTALL:append:x86 = "kernel-module-tun"
> -IMAGE_INSTALL:append:x86-64 = "kernel-module-tun"
> +IMAGE_INSTALL:append:x86 = " kernel-module-tun"
> +IMAGE_INSTALL:append:x86-64 = " kernel-module-tun"
>
> # Linux kernel option CONFIG_XEN_PCIDEV_BACKEND depends on X86
> XEN_PCIBACK_MODULE = ""
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7211): https://lists.yoctoproject.org/g/meta-virtualization/message/7211
> Mute This Topic: https://lists.yoctoproject.org/mt/90631753/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
prev parent reply other threads:[~2022-04-27 3:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 16:18 [PATCH] xen: Add missing space in append to IMAGE_INSTALL Bertrand Marquis
2022-04-22 17:04 ` [meta-virtualization] " Christopher Clark
2022-04-27 3:04 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427030359.GD55546@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=bertrand.marquis@arm.com \
--cc=meta-virtualization@lists.yoctoproject.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.