All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Hanna Reitz <hreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Emanuele Giuseppe Esposito <eesposit@redhat.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 3/4] Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions"
Date: Wed, 27 Apr 2022 08:22:09 -0500	[thread overview]
Message-ID: <20220427132209.ckzrv27kc242ffld@redhat.com> (raw)
In-Reply-To: <20220427114057.36651-4-hreitz@redhat.com>

On Wed, Apr 27, 2022 at 01:40:56PM +0200, Hanna Reitz wrote:
> This reverts commit b1c073490553f80594b903ceedfc7c1aef6b1b19.  (We
> wanted to do so once the 7.1 tree opens, which has happened.  The issue
> reported in https://gitlab.com/qemu-project/qemu/-/issues/945 should be
> fixed by the preceding patches.)
> 
> Signed-off-by: Hanna Reitz <hreitz@redhat.com>
> ---
>  include/qemu/main-loop.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

[Here's hoping we don't have to re-disable it because it finds more
bugs - but maximizing the soak time during development with it enabled
is good]

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



  reply	other threads:[~2022-04-27 13:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 11:40 [PATCH 0/4] Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions" Hanna Reitz
2022-04-27 11:40 ` [PATCH 1/4] block: Classify bdrv_get_flags() as I/O function Hanna Reitz
2022-04-27 13:14   ` Eric Blake
2022-04-27 11:40 ` [PATCH 2/4] qcow2: Do not reopen data_file in invalidate_cache Hanna Reitz
2022-04-27 13:20   ` Eric Blake
2022-04-27 16:05   ` Kevin Wolf
2022-04-27 11:40 ` [PATCH 3/4] Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions" Hanna Reitz
2022-04-27 13:22   ` Eric Blake [this message]
2022-04-27 11:40 ` [PATCH 4/4] iotests: Add regression test for issue 945 Hanna Reitz
2022-04-27 13:52   ` Eric Blake
2022-04-27 16:13 ` [PATCH 0/4] Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions" Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220427132209.ckzrv27kc242ffld@redhat.com \
    --to=eblake@redhat.com \
    --cc=eesposit@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.