From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 28 Apr 2022 02:30:22 -0400 From: "Michael S. Tsirkin" Subject: Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state Message-ID: <20220428022714-mutt-send-email-mst@kernel.org> References: <20220427111713-mutt-send-email-mst@kernel.org> <20220427114055-mutt-send-email-mst@kernel.org> <9a932876-1a5e-8166-57fd-f41bf4f153f5@redhat.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Jason Wang Cc: Parav Pandit , Virtio-Dev , Xuan Zhuo , Cornelia Huck , Stefan Hajnoczi List-ID: On Thu, Apr 28, 2022 at 02:13:42PM +0800, Jason Wang wrote: > > queue_reset removal has far more editorial changes. > > Before I update the v4 to incorporate, please discuss/sync with Michael or others what is best course of action from spec timing perspective. > > I am ok either way to draft either by > > (a) removal of queue_reset register and allow queue_disable by replacing RING_RESET definition in v4 > > Or > > (b) fixing the polarity as done in v3 > > Ok. > > Thanks So Jason, what is your take? I am inclined to keep queue reset register and just flip the polarity. Less spec work and semantics are more or less clear. Not helpful for migration - limited to queue resize, watchdog and similar uses - but if we are expanding scope to migration that makes it imo not 1.2 material. -- MST