From: "Richard W.M. Jones" <rjones@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: SELinux List <selinux@vger.kernel.org>,
Petr Lautrbach <plautrba@redhat.com>
Subject: Re: [PATCH for-3.5 0/5] selinux_restorecon(3), setfiles(8): skip relabeling errors
Date: Thu, 28 Apr 2022 10:22:51 +0100 [thread overview]
Message-ID: <20220428092251.GJ1127@redhat.com> (raw)
In-Reply-To: <20220428065354.27605-1-lersek@redhat.com>
A couple of comments:
I'm not clear from the patch series what the difference is between an
error which ignored (and counted) and an error that would actually
stop setfiles immediately. With setfiles -C, will all errors now be
counted and cause setfiles to exit with 1, or will some errors still
be fatal (exit with 255)?
Why on earth is setfiles originally calling exit(-1) at all?! I
didn't even know that was allowed. I wrote a test program and this
does indeed cause the exit status to be 255 (because the status is
&-ed with 0xff). Never seen a program before calling exit(-1).
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
nbdkit - Flexible, fast NBD server with plugins
https://gitlab.com/nbdkit/nbdkit
next prev parent reply other threads:[~2022-04-28 9:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 6:53 [PATCH for-3.5 0/5] selinux_restorecon(3), setfiles(8): skip relabeling errors Laszlo Ersek
2022-04-28 6:53 ` [PATCH for-3.5 1/5] setfiles: fix up inconsistent indentation Laszlo Ersek
2022-04-28 6:53 ` [PATCH for-3.5 2/5] setfiles: remove useless assignment and comment (after RHBZ#1926386) Laszlo Ersek
2022-04-28 6:53 ` [PATCH for-3.5 3/5] setfiles: remove useless "iamrestorecon" checks in option parsing Laszlo Ersek
2022-04-28 16:07 ` Daniel Burgener
2022-04-28 6:53 ` [PATCH for-3.5 4/5] selinux_restorecon: introduce SELINUX_RESTORECON_COUNT_ERRORS Laszlo Ersek
2022-04-29 8:13 ` Petr Lautrbach
2022-04-29 10:20 ` Laszlo Ersek
2022-04-28 6:53 ` [PATCH for-3.5 5/5] setfiles: introduce the -C option for distinguishing file tree walk errors Laszlo Ersek
2022-04-28 9:22 ` Richard W.M. Jones [this message]
2022-04-28 9:40 ` [PATCH for-3.5 0/5] selinux_restorecon(3), setfiles(8): skip relabeling errors Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428092251.GJ1127@redhat.com \
--to=rjones@redhat.com \
--cc=lersek@redhat.com \
--cc=plautrba@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.