All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: <jic23@kernel.org>, <bleung@chromium.org>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] chrome: Remove Custom ABI |location| attribute
Date: Thu, 28 Apr 2022 09:31:30 +0100	[thread overview]
Message-ID: <20220428093130.000051b2@Huawei.com> (raw)
In-Reply-To: <20220427190804.961697-1-gwendal@chromium.org>

On Wed, 27 Apr 2022 12:08:02 -0700
Gwendal Grignou <gwendal@chromium.org> wrote:

> Instead of using the custom |location| attribute, use the |label| attribute
> introduced in kernel 5.8.
> A new location is required for sensors located in a camera subassembly that
> swivels.
> 

I'm assuming this ABI change is fine because you can change the software stack
as well?

Is this likely to break anyone relying on the old location attribute?

Jonathan

> ---
>  changes in v2:
>  * Add "accel-camera" define.
>  * remove |location| attribute completely.
> 
> Gwendal Grignou (2):
>   iio: ABI: Add a new location label
>   iio: common: cros_ec_sensors: Add label attribute
> 
>  Documentation/ABI/testing/sysfs-bus-iio       |  5 ++++
>  drivers/iio/accel/cros_ec_accel_legacy.c      |  2 +-
>  .../cros_ec_sensors/cros_ec_sensors_core.c    | 30 ++++++-------------
>  drivers/iio/light/cros_ec_light_prox.c        |  2 --
>  drivers/iio/pressure/cros_ec_baro.c           |  2 --
>  .../linux/iio/common/cros_ec_sensors_core.h   |  2 --
>  6 files changed, 15 insertions(+), 28 deletions(-)
> 


  parent reply	other threads:[~2022-04-28  8:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 19:08 [PATCH v2 0/2] chrome: Remove Custom ABI |location| attribute Gwendal Grignou
2022-04-27 19:08 ` [PATCH v2 1/2] iio: ABI: Add a new location label Gwendal Grignou
2022-04-27 19:08 ` [PATCH v2 2/2] iio: common: cros_ec_sensors: Add label attribute Gwendal Grignou
2022-04-28  8:31 ` Jonathan Cameron [this message]
2022-05-08 18:05   ` [PATCH v2 0/2] chrome: Remove Custom ABI |location| attribute Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220428093130.000051b2@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=bleung@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.