All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/media/platform/samsung/exynos4-is/fimc-m2m.c:258 fimc_m2m_g_fmt_mplane() warn: passing a valid pointer to 'PTR_ERR'
Date: Thu, 28 Apr 2022 15:15:15 +0800	[thread overview]
Message-ID: <202204281544.pr5a0L3e-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 23151 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8f4dd16603ce834d1c5c4da67803ea82dd282511
commit: 238c84f71120f41c45301359902a912a19370f3d media: platform: rename exynos4-is/ to samsung/exynos4-is/
date:   6 weeks ago
:::::: branch date: 10 hours ago
:::::: commit date: 6 weeks ago
config: microblaze-randconfig-m031-20220427 (https://download.01.org/0day-ci/archive/20220428/202204281544.pr5a0L3e-lkp(a)intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/media/platform/samsung/exynos4-is/fimc-m2m.c:258 fimc_m2m_g_fmt_mplane() warn: passing a valid pointer to 'PTR_ERR'
drivers/media/platform/samsung/exynos4-is/fimc-m2m.c:385 fimc_m2m_g_selection() warn: passing a valid pointer to 'PTR_ERR'

vim +/PTR_ERR +258 drivers/media/platform/samsung/exynos4-is/fimc-m2m.c

97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  250  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  251  static int fimc_m2m_g_fmt_mplane(struct file *file, void *fh,
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  252  				 struct v4l2_format *f)
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  253  {
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  254  	struct fimc_ctx *ctx = fh_to_ctx(fh);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  255  	struct fimc_frame *frame = ctx_get_frame(ctx, f->type);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  256  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  257  	if (IS_ERR(frame))
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08 @258  		return PTR_ERR(frame);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  259  
fa8880bece7321d drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-11  260  	__fimc_get_format(frame, f);
fa8880bece7321d drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-11  261  	return 0;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  262  }
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  263  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  264  static int fimc_try_fmt_mplane(struct fimc_ctx *ctx, struct v4l2_format *f)
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  265  {
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  266  	struct fimc_dev *fimc = ctx->fimc_dev;
405f230c44d8097 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2012-08-02  267  	const struct fimc_variant *variant = fimc->variant;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  268  	struct v4l2_pix_format_mplane *pix = &f->fmt.pix_mp;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  269  	struct fimc_fmt *fmt;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  270  	u32 max_w, mod_x, mod_y;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  271  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  272  	if (!IS_M2M(f->type))
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  273  		return -EINVAL;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  274  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  275  	fmt = fimc_find_format(&pix->pixelformat, NULL,
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  276  			       get_m2m_fmt_flags(f->type), 0);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  277  	if (WARN(fmt == NULL, "Pixel format lookup failed"))
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  278  		return -EINVAL;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  279  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  280  	if (pix->field == V4L2_FIELD_ANY)
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  281  		pix->field = V4L2_FIELD_NONE;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  282  	else if (pix->field != V4L2_FIELD_NONE)
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  283  		return -EINVAL;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  284  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  285  	if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  286  		max_w = variant->pix_limit->scaler_dis_w;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  287  		mod_x = ffs(variant->min_inp_pixsize) - 1;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  288  	} else {
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  289  		max_w = variant->pix_limit->out_rot_dis_w;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  290  		mod_x = ffs(variant->min_out_pixsize) - 1;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  291  	}
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  292  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  293  	if (tiled_fmt(fmt)) {
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  294  		mod_x = 6; /* 64 x 32 pixels tile */
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  295  		mod_y = 5;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  296  	} else {
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  297  		if (variant->min_vsize_align == 1)
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  298  			mod_y = fimc_fmt_is_rgb(fmt->color) ? 0 : 1;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  299  		else
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  300  			mod_y = ffs(variant->min_vsize_align) - 1;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  301  	}
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  302  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  303  	v4l_bound_align_image(&pix->width, 16, max_w, mod_x,
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  304  		&pix->height, 8, variant->pix_limit->scaler_dis_w, mod_y, 0);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  305  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  306  	fimc_adjust_mplane_format(fmt, pix->width, pix->height, &f->fmt.pix_mp);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  307  	return 0;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  308  }
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  309  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  310  static int fimc_m2m_try_fmt_mplane(struct file *file, void *fh,
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  311  				   struct v4l2_format *f)
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  312  {
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  313  	struct fimc_ctx *ctx = fh_to_ctx(fh);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  314  	return fimc_try_fmt_mplane(ctx, f);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  315  }
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  316  
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  317  static void __set_frame_format(struct fimc_frame *frame, struct fimc_fmt *fmt,
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  318  			       struct v4l2_pix_format_mplane *pixm)
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  319  {
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  320  	int i;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  321  
8411323f8e04fca drivers/media/platform/exynos4-is/fimc-m2m.c Nicolas Dufresne   2014-03-25  322  	for (i = 0; i < fmt->memplanes; i++) {
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  323  		frame->bytesperline[i] = pixm->plane_fmt[i].bytesperline;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  324  		frame->payload[i] = pixm->plane_fmt[i].sizeimage;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  325  	}
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  326  
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  327  	frame->f_width = pixm->width;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  328  	frame->f_height	= pixm->height;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  329  	frame->o_width = pixm->width;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  330  	frame->o_height = pixm->height;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  331  	frame->width = pixm->width;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  332  	frame->height = pixm->height;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  333  	frame->offs_h = 0;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  334  	frame->offs_v = 0;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  335  	frame->fmt = fmt;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  336  }
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  337  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  338  static int fimc_m2m_s_fmt_mplane(struct file *file, void *fh,
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  339  				 struct v4l2_format *f)
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  340  {
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  341  	struct fimc_ctx *ctx = fh_to_ctx(fh);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  342  	struct fimc_dev *fimc = ctx->fimc_dev;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  343  	struct fimc_fmt *fmt;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  344  	struct vb2_queue *vq;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  345  	struct fimc_frame *frame;
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  346  	int ret;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  347  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  348  	ret = fimc_try_fmt_mplane(ctx, f);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  349  	if (ret)
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  350  		return ret;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  351  
43894d848a40075 drivers/media/platform/exynos4-is/fimc-m2m.c Sylwester Nawrocki 2013-08-25  352  	vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  353  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  354  	if (vb2_is_busy(vq)) {
bbc5296f2057075 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2012-07-26  355  		v4l2_err(&fimc->m2m.vfd, "queue (%d) busy\n", f->type);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  356  		return -EBUSY;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  357  	}
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  358  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  359  	if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  360  		frame = &ctx->s_frame;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  361  	else
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  362  		frame = &ctx->d_frame;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  363  
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  364  	fmt = fimc_find_format(&f->fmt.pix_mp.pixelformat, NULL,
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  365  			       get_m2m_fmt_flags(f->type), 0);
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  366  	if (!fmt)
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  367  		return -EINVAL;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  368  
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  369  	__set_frame_format(frame, fmt, &f->fmt.pix_mp);
81619ce1931a1d9 drivers/media/platform/s5p-fimc/fimc-m2m.c   Sylwester Nawrocki 2013-01-30  370  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  371  	/* Update RGB Alpha control state and value range */
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  372  	fimc_alpha_ctrl_update(ctx);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  373  
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  374  	return 0;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  375  }
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  376  
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  377  static int fimc_m2m_g_selection(struct file *file, void *fh,
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  378  				struct v4l2_selection *s)
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  379  {
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  380  	struct fimc_ctx *ctx = fh_to_ctx(fh);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  381  	struct fimc_frame *frame;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  382  
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  383  	frame = ctx_get_frame(ctx, s->type);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  384  	if (IS_ERR(frame))
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08 @385  		return PTR_ERR(frame);
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  386  
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  387  	switch (s->target) {
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  388  	case V4L2_SEL_TGT_CROP:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  389  	case V4L2_SEL_TGT_CROP_DEFAULT:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  390  	case V4L2_SEL_TGT_CROP_BOUNDS:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  391  		if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT)
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  392  			return -EINVAL;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  393  		break;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  394  	case V4L2_SEL_TGT_COMPOSE:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  395  	case V4L2_SEL_TGT_COMPOSE_DEFAULT:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  396  	case V4L2_SEL_TGT_COMPOSE_BOUNDS:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  397  		if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  398  			return -EINVAL;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  399  		break;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  400  	default:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  401  		return -EINVAL;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  402  	}
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  403  
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  404  	switch (s->target) {
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  405  	case V4L2_SEL_TGT_CROP:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  406  	case V4L2_SEL_TGT_COMPOSE:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  407  		s->r.left = frame->offs_h;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  408  		s->r.top = frame->offs_v;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  409  		s->r.width = frame->width;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  410  		s->r.height = frame->height;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  411  		break;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  412  	case V4L2_SEL_TGT_CROP_DEFAULT:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  413  	case V4L2_SEL_TGT_CROP_BOUNDS:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  414  	case V4L2_SEL_TGT_COMPOSE_DEFAULT:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  415  	case V4L2_SEL_TGT_COMPOSE_BOUNDS:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  416  		s->r.left = 0;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  417  		s->r.top = 0;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  418  		s->r.width = frame->o_width;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  419  		s->r.height = frame->o_height;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  420  		break;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  421  	default:
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  422  		return -EINVAL;
158efdeebc4871a drivers/media/platform/exynos4-is/fimc-m2m.c Hans Verkuil       2018-10-04  423  	}
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  424  	return 0;
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  425  }
97d974226575227 drivers/media/video/s5p-fimc/fimc-m2m.c      Sylwester Nawrocki 2012-05-08  426  

:::::: The code at line 258 was first introduced by commit
:::::: 97d974226575227ebafdf3ab009f0212d8a7e223 [media] s5p-fimc: Move m2m node driver into separate file

:::::: TO: Sylwester Nawrocki <s.nawrocki@samsung.com>
:::::: CC: Mauro Carvalho Chehab <mchehab@redhat.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

             reply	other threads:[~2022-04-28  7:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28  7:15 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-01-10  7:29 drivers/media/platform/samsung/exynos4-is/fimc-m2m.c:258 fimc_m2m_g_fmt_mplane() warn: passing a valid pointer to 'PTR_ERR' kernel test robot
2022-10-29 15:46 kernel test robot
2022-10-10 23:47 kernel test robot
2022-09-25 11:10 kernel test robot
2022-04-28 18:27 kernel test robot
2022-04-05  0:34 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202204281544.pr5a0L3e-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.