From: Jakub Kicinski <kuba@kernel.org>
To: kvalo@kernel.org
Cc: linux-wireless@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
tony0620emma@gmail.com
Subject: [PATCH wireless-next 1/3] wifi: rtw88: remove a copy of the NAPI_POLL_WEIGHT define
Date: Fri, 29 Apr 2022 10:46:41 -0700 [thread overview]
Message-ID: <20220429174643.196994-2-kuba@kernel.org> (raw)
In-Reply-To: <20220429174643.196994-1-kuba@kernel.org>
Defining local versions of NAPI_POLL_WEIGHT with the same
values in the drivers just makes refactoring harder.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: tony0620emma@gmail.com
CC: kvalo@kernel.org
CC: linux-wireless@vger.kernel.org
---
drivers/net/wireless/realtek/rtw88/main.h | 1 -
drivers/net/wireless/realtek/rtw88/pci.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/main.h b/drivers/net/wireless/realtek/rtw88/main.h
index 17815af9dd4e..2019c908fd5f 100644
--- a/drivers/net/wireless/realtek/rtw88/main.h
+++ b/drivers/net/wireless/realtek/rtw88/main.h
@@ -17,7 +17,6 @@
#include "util.h"
-#define RTW_NAPI_WEIGHT_NUM 64
#define RTW_MAX_MAC_ID_NUM 32
#define RTW_MAX_SEC_CAM_NUM 32
#define MAX_PG_CAM_BACKUP_NUM 8
diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
index a0991d3f15c0..cf7177b00092 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.c
+++ b/drivers/net/wireless/realtek/rtw88/pci.c
@@ -1703,7 +1703,7 @@ static void rtw_pci_napi_init(struct rtw_dev *rtwdev)
init_dummy_netdev(&rtwpci->netdev);
netif_napi_add(&rtwpci->netdev, &rtwpci->napi, rtw_pci_napi_poll,
- RTW_NAPI_WEIGHT_NUM);
+ NAPI_POLL_WEIGHT);
}
static void rtw_pci_napi_deinit(struct rtw_dev *rtwdev)
--
2.34.1
next prev parent reply other threads:[~2022-04-29 17:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 17:46 [PATCH wireless-next 0/3] wifi: remove copies of the NAPI_POLL_WEIGHT define Jakub Kicinski
2022-04-29 17:46 ` Jakub Kicinski [this message]
2022-05-02 14:38 ` [wireless-next,1/3] rtw88: remove a copy " Kalle Valo
2022-04-29 17:46 ` [PATCH wireless-next 2/3] wifi: ath10k: " Jakub Kicinski
2022-04-29 17:46 ` Jakub Kicinski
2022-04-29 19:06 ` Kalle Valo
2022-04-29 19:06 ` Kalle Valo
2022-04-29 19:16 ` Jakub Kicinski
2022-04-29 19:16 ` Jakub Kicinski
2022-05-02 14:00 ` Kalle Valo
2022-05-02 14:00 ` Kalle Valo
2022-04-29 17:46 ` [PATCH wireless-next 3/3] wifi: wil6210: use NAPI_POLL_WEIGHT for napi budget Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429174643.196994-2-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.