All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josua Mayer <josua@solid-run.com>
To: u-boot@lists.denx.de
Cc: alvaro.karsz@solid-run.com, Josua Mayer <josua@solid-run.com>,
	Joe Hershberger <joe.hershberger@ni.com>,
	Ramon Fried <rfried.dev@gmail.com>,
	Nate Drude <nate.d@variscite.com>
Subject: [PATCH 1/5] phy: adin: remove broken support for adi, phy-mode-override
Date: Sun,  1 May 2022 15:41:27 +0300	[thread overview]
Message-ID: <20220501124131.30614-2-josua@solid-run.com> (raw)
In-Reply-To: <20220501124131.30614-1-josua@solid-run.com>

The adin_get_phy_mode_override function does not compile, because it is
missing both declaration and implementation of
phy_get_interface_by_name.

Remove the whole function for now, since the missing implementation is
not included in mainline Linux - and thus can not be copied.

Signed-off-by: Josua Mayer <josua@solid-run.com>
---
 drivers/net/phy/adin.c | 34 ----------------------------------
 1 file changed, 34 deletions(-)

diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
index cff841ab3d..2433e76fea 100644
--- a/drivers/net/phy/adin.c
+++ b/drivers/net/phy/adin.c
@@ -94,35 +94,6 @@ static u32 adin_get_reg_value(struct phy_device *phydev,
 	return rc;
 }
 
-/**
- * adin_get_phy_mode_override - Get phy-mode override for adin PHY
- *
- * The function gets phy-mode string from property 'adi,phy-mode-override'
- * and return its index in phy_interface_strings table, or -1 in error case.
- */
-int adin_get_phy_mode_override(struct phy_device *phydev)
-{
-	ofnode node = phy_get_ofnode(phydev);
-	const char *phy_mode_override;
-	const char *prop_phy_mode_override = "adi,phy-mode-override";
-	int override_interface;
-
-	phy_mode_override = ofnode_read_string(node, prop_phy_mode_override);
-	if (!phy_mode_override)
-		return -ENODEV;
-
-	debug("%s: %s = '%s'\n",
-	      __func__, prop_phy_mode_override, phy_mode_override);
-
-	override_interface = phy_get_interface_by_name(phy_mode_override);
-
-	if (override_interface < 0)
-		printf("%s: %s = '%s' is not valid\n",
-		       __func__, prop_phy_mode_override, phy_mode_override);
-
-	return override_interface;
-}
-
 static u16 adin_ext_read(struct phy_device *phydev, const u32 regnum)
 {
 	u16 val;
@@ -148,11 +119,6 @@ static int adin_config_rgmii_mode(struct phy_device *phydev)
 {
 	u16 reg_val;
 	u32 val;
-	int phy_mode_override = adin_get_phy_mode_override(phydev);
-
-	if (phy_mode_override >= 0) {
-		phydev->interface = (phy_interface_t) phy_mode_override;
-	}
 
 	reg_val = adin_ext_read(phydev, ADIN1300_GE_RGMII_CFG);
 
-- 
2.34.1


  reply	other threads:[~2022-05-01 12:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-01 12:41 [PATCH 0/5] mx6cuboxi: add eth support for SoMs revision 1.9+ Josua Mayer
2022-05-01 12:41 ` Josua Mayer [this message]
2022-05-02 13:25   ` [PATCH 1/5] phy: adin: remove broken support for adi,phy-mode-override Nate Drude
2022-05-04  8:51     ` Josua Mayer
2022-05-04 12:46       ` Nate Drude
2022-05-05 15:30         ` Josua Mayer
2022-05-08  9:34           ` Josua Mayer
2022-05-01 12:41 ` [PATCH 2/5] phy: adin: add support for clock output Josua Mayer
2022-05-01 12:41 ` [PATCH 3/5] ARM: dts: imx6qdl-sr-som: add support for alternate phy addresses Josua Mayer
2022-05-01 12:41 ` [PATCH 4/5] mx6cuboxi: fixup dtb ethernet phy nodes before booting an OS Josua Mayer
2022-05-01 12:41 ` [PATCH 5/5] mx6cuboxi: enable driver for adin1300 phy Josua Mayer
2022-05-19  8:59 ` [PATCH 0/5] mx6cuboxi: add eth support for SoMs revision 1.9+ Josua Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220501124131.30614-2-josua@solid-run.com \
    --to=josua@solid-run.com \
    --cc=alvaro.karsz@solid-run.com \
    --cc=joe.hershberger@ni.com \
    --cc=nate.d@variscite.com \
    --cc=rfried.dev@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.