From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8F84C433F5 for ; Sun, 1 May 2022 12:52:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4FDA083DDA; Sun, 1 May 2022 14:52:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ToAw1fi/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 62F4B83F06; Sun, 1 May 2022 14:52:16 +0200 (CEST) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5E69383DDA for ; Sun, 1 May 2022 14:52:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id j9so9763767qkg.1 for ; Sun, 01 May 2022 05:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jZem6StDTqd8PFMb7vcR8fWy3qKMd4ZOrLy7EbstsTc=; b=ToAw1fi/8CWnJdkDi15Zp3cZPKV9TnMEmPNo3PsG4TN3nvlzFV8Xj/zaKspFT0xNk9 adpwy+HfHBO0a9Yn0ae9X8llOQcKs37qzuI0uxc7TyGdGTz8igJVkTVSKfq1fDAftw+p aOrg9RGeaARMY6DrNNVbyzt334tm1IZHuLvAw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jZem6StDTqd8PFMb7vcR8fWy3qKMd4ZOrLy7EbstsTc=; b=C5FrameLViOykOTzntyedVSEtYkBjZmaSD6Thkjgx54i22/3kxFKFQ7yFBPhlsf82X TBwdBCBrbqgsiA0GlNT5fPmOSFL7+r+f0NZmyCsB3MGRH0B4CAi7m5sg+XG3/C6xF4sM 9fC8o/QvWZbHEmKHDo7A0XmCnOqLo3LBAB3OxhzqUxN/wXDCTAqc8iEy46w55xdpfIol TxQ64Wevd5g71QixcNSiYKcnDW+WsEwqLOwJAHmPhN4VNFMRASXMnttRMv5b6LFFQbGa VbfHvQrguN6tPe45zJIN59wZw+C8wxLXMINNzCqXumcK9D4HFq/KQ0s2JPaWWkaAnyHl f5SA== X-Gm-Message-State: AOAM531agfRQzVA9DF9JkswatLDdISAvCxEcOZdVf6ZuXtNDVlHrqJBE JTYev1qqafyNhAT96wwY4BskuQ== X-Google-Smtp-Source: ABdhPJwBWEjJGnGuWZp7dDxkLepyAscuHwqNU/dLz3XTnjs+XJ/cLLRXXgBSR7cbc944fAbjhjBjnQ== X-Received: by 2002:a05:620a:270b:b0:69f:8e5e:81b2 with SMTP id b11-20020a05620a270b00b0069f8e5e81b2mr5308378qkp.426.1651409531984; Sun, 01 May 2022 05:52:11 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-4500-8850-9ae8-f0b0-d694.res6.spectrum.com. [2603:6081:7b01:4500:8850:9ae8:f0b0:d694]) by smtp.gmail.com with ESMTPSA id b15-20020ac8540f000000b002f39b99f69csm2503412qtq.54.2022.05.01.05.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 May 2022 05:52:11 -0700 (PDT) Date: Sun, 1 May 2022 08:52:09 -0400 From: Tom Rini To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Weijie Gao , Stefan Roese , u-boot@lists.denx.de, GSS_MTK_Uboot_upstream Subject: Re: [PATCH v3 00/15] Add support for MediaTek MT7621 SoC Message-ID: <20220501125209.GF1182808@bill-the-cat> References: <20220428181955.1717ea7d@thinkpad> <3363c536747a3519b2a1eb8d22c029bfd02cc507.camel@mediatek.com> <055adba5a54f3d18ea310cdc7616f212bcc6c61e.camel@mediatek.com> <20220429171330.3f8e3d39@thinkpad> <20220430154804.3593a53e@thinkpad> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="H4Dtu32JQD1K2gM0" Content-Disposition: inline In-Reply-To: <20220430154804.3593a53e@thinkpad> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --H4Dtu32JQD1K2gM0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 30, 2022 at 03:48:04PM +0200, Marek Beh=FAn wrote: > On Sat, 30 Apr 2022 21:31:15 +0800 > Weijie Gao wrote: >=20 > > On Fri, 2022-04-29 at 17:13 +0200, Marek Beh=FAn wrote: > > > On Fri, 29 Apr 2022 15:59:44 +0800 > > > Weijie Gao wrote: > > > =20 > > > > On Fri, 2022-04-29 at 08:15 +0200, Stefan Roese wrote: =20 > > > > > Hi Weijie > > > > >=20 > > > > > On 4/29/22 03:23, Weijie Gao wrote: =20 > > > > > > Hi Marek, > > > > > >=20 > > > > > > Yes. MT7621 does need such a proprietary binary for DDR > > > > > > initialization > > > > > > and calibration. That's why I submit only the ram-bootable part > > > > > > here. > > > > > >=20 > > > > > > I'm considering to create a preloader to load and run DDR > > > > > > init&calib > > > > > > binary and ram-bootable u-boot image. The ram-bootable u-boot > > > > > > image > > > > > > can be appended to the proloader to form the flash-bootable > > > > > > bootloader. > > > > > >=20 > > > > > > The source code of preloader will be uploaded to github. =20 > > > > >=20 > > > > > Just to be sure: You are not implementing this preloader as an U- > > > > > Boot > > > > > SPL loader, as this would conflict with U-Boot's GPL > > > > > compatibility? =20 > > > >=20 > > > > Yes. Submitting the source code of this binary also violates MTK's > > > > non- > > > > disclosure agreement. =20 > > >=20 > > > Isn't it possible to submit the DDR training code in binary version, > > > and somehow call into it from SPL? =20 > >=20 > > It's possible and I've already implemented it. But will u-boot accept > > binary file? >=20 > U-Boot at least accepts drivers that require proprietary firmware to > load (bnxt driver, for example). >=20 > I don't know whether a binary firmware can be accepted into the U-Boot > repository, whether in a separate file or as an u8 array in a .c file, > but it should at least be possible to make it so that the user can > compile it thsemsevles to be bundled, i.e. create a Kconfig option that > configures a path to the firmware. If it is present, it will be > compiled with DDR training bundled. >=20 > Stefan, Tom, can this be done? >=20 > BTW, Weijie, can I already test this on mt7621 board, also with DDR > training? Can you send me the patch that adds calling the proprietary > code? At the high level, I would make a further disappointed sigh and note the NXP ddr firmware blobs, the binary blobs we pull in for x86, and all of the other blobs we bring in today via binman. Please make use of one of these otherwise existing mechanics to bring in the required DDR blobs here. --=20 Tom --H4Dtu32JQD1K2gM0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJugnUACgkQFHw5/5Y0 tyyE9Av9F2T8Z8DCvM7me4z0SRQUfOXJP2Gn84jWYodwJWGRw0prADWh+1jr/x90 +U2/tA0tSFAZxytbHnMP5PPsE3SWjmNZ/RkdKVCjQ1afaj87cb5tknlGW16MIhXo S3cYxj3bd5u47M6iivchuhP8KpC0FC2kAOe9Ffln9vWGDgx47pUwno/6IScgXWCa 0ffKpPRqzB1DmoiOynJkSogGgO4LVzAPrPxr1aWB7Acsc09YkimZ/aKjDXQTQzsb s9jgQOu0TA9X8uHCTZlLrRUVsj9suEZ6oitLS9on4Pi5wf+nnOvJhIiIgHufHMlH El9DmAZO8Rw4qf4HUxGCiXHYNugPH9S5CAE1EoTfH84Oc2+8mwFXjJDAx1O/ohrP 539sKBS5UPlYEnna+tKchLx0zp3lm5tLzDFKTsyXtMedrzJ84nSTzrxU88FfxM3V kVFnC+tHhn22TcYsBLPCvUxcd15afmRf4exhljkXjtxWWvd5unptT8KZSn5wcxZD oB5xGxBP =D6Ne -----END PGP SIGNATURE----- --H4Dtu32JQD1K2gM0--