From: Jakub Kicinski <kuba@kernel.org>
To: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Simon Horman <horms@verge.net.au>, Julian Anastasov <ja@ssi.bg>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>, Shuah Khan <shuah@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexei Starovoitov <ast@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Lorenz Bauer <lmb@cloudflare.com>,
Akhmat Karakotov <hmukos@yandex-team.ru>
Subject: Re: [net-next v4 3/3] selftests/sysctl: add sysctl macro test
Date: Mon, 2 May 2022 07:26:46 -0700 [thread overview]
Message-ID: <20220502072646.7fdc45bc@kernel.org> (raw)
In-Reply-To: <CAMDZJNV69HeaBmy1uY7g7R=GKunoV3=bgNd5yfEMKUg_jMPuUg@mail.gmail.com>
On Sun, 1 May 2022 11:31:47 +0800 Tonghao Zhang wrote:
> static int __init test_sysctl_init(void)
> {
> + int i;
> +
nit: No empty line needed here.
> + struct {
> + int defined;
> + int wanted;
> + } match_int[] = {
> + {.defined = *(int *)SYSCTL_ZERO, .wanted = 0},
> + {.defined = *(int *)SYSCTL_ONE, .wanted = 1},
> + {.defined = *(int *)SYSCTL_TWO, .wanted = 2},
> + {.defined = *(int *)SYSCTL_THREE, .wanted = 3},
> + {.defined = *(int *)SYSCTL_FOUR, .wanted = 4},
> + {.defined = *(int *)SYSCTL_ONE_HUNDRED, .wanted = 100},
> + {.defined = *(int *)SYSCTL_TWO_HUNDRED, .wanted = 200},
> + {.defined = *(int *)SYSCTL_ONE_THOUSAND, .wanted = 1000},
> + {.defined = *(int *)SYSCTL_THREE_THOUSAND, .wanted = 3000},
> + {.defined = *(int *)SYSCTL_INT_MAX, .wanted = INT_MAX},
> + {.defined = *(int *)SYSCTL_MAXOLDUID, .wanted = 65535},
> + {.defined = *(int *)SYSCTL_NEG_ONE, .wanted = -1},
> + };
> +
> + for (i = 0; i < ARRAY_SIZE(match_int); i++)
> + if (match_int[i].defined != match_int[i].wanted)
> + match_int_ok = 0;
That's better, thank you!
next prev parent reply other threads:[~2022-05-02 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 7:01 [net-next v4 0/3] use standard sysctl macro xiangxia.m.yue
2022-04-22 7:01 ` [net-next v4 1/3] net: sysctl: use shared " xiangxia.m.yue
2022-04-22 7:01 ` [net-next v4 2/3] net: sysctl: introduce sysctl SYSCTL_THREE xiangxia.m.yue
2022-04-22 7:01 ` [net-next v4 3/3] selftests/sysctl: add sysctl macro test xiangxia.m.yue
2022-04-25 19:58 ` Jakub Kicinski
2022-05-01 3:31 ` Tonghao Zhang
2022-05-02 14:26 ` Jakub Kicinski [this message]
2022-04-22 14:44 ` [net-next v4 0/3] use standard sysctl macro Luis Chamberlain
2022-04-22 19:43 ` Jakub Kicinski
2022-04-25 19:47 ` Luis Chamberlain
2022-04-25 19:56 ` Jakub Kicinski
2022-04-25 20:53 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502072646.7fdc45bc@kernel.org \
--to=kuba@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=hmukos@yandex-team.ru \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lmb@cloudflare.com \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=shuah@kernel.org \
--cc=xiangxia.m.yue@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.