From: Jakub Kicinski <kuba@kernel.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: linux-doc@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Dave Jones <davej@redhat.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
"David S . Miller" <davem@davemloft.net>,
Pavel Begunkov <asml.silence@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net/core: Remove comment quote for __dev_queue_xmit()
Date: Tue, 3 May 2022 18:03:41 -0700 [thread overview]
Message-ID: <20220503180341.36dcbb07@kernel.org> (raw)
In-Reply-To: <20220503072949.27336-1-bagasdotme@gmail.com>
On Tue, 3 May 2022 14:29:49 +0700 Bagas Sanjaya wrote:
> - * -----------------------------------------------------------------------------------
> - * I notice this method can also return errors from the queue disciplines,
> - * including NET_XMIT_DROP, which is a positive value. So, errors can also
> - * be positive.
> - *
> - * Regardless of the return value, the skb is consumed, so it is currently
> - * difficult to retry a send to this method. (You can bump the ref count
> - * before sending to hold a reference for retry if you are careful.)
> - *
> - * When calling this method, interrupts MUST be enabled. This is because
> - * the BH enable code must have IRQs enabled so that it will not deadlock.
> - * --BLG
> + * This method can also return positive errno code from the queue
> + * disciplines (including NET_XMIT_DROP).
> + *
> + * Note that regardless of the return value, the skb is consumed
> + * anyway, so it is currently difficult to retry sending to this
> + * method.
Why drop almost half of the comment if the problem is just the ----
banner?
next prev parent reply other threads:[~2022-05-04 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 7:29 [PATCH net-next] net/core: Remove comment quote for __dev_queue_xmit() Bagas Sanjaya
2022-05-04 1:03 ` Jakub Kicinski [this message]
2022-05-04 4:28 ` Bagas Sanjaya
2022-05-04 13:43 ` Akira Yokosawa
2022-05-04 14:37 ` Jakub Kicinski
2022-05-05 0:30 ` Akira Yokosawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503180341.36dcbb07@kernel.org \
--to=kuba@kernel.org \
--cc=asml.silence@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.