From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
netdev@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net] net/sched: act_pedit: really ensure the skb is writable
Date: Wed, 4 May 2022 08:33:34 -0700 [thread overview]
Message-ID: <20220504083334.1b7a98e3@kernel.org> (raw)
In-Reply-To: <a8abc239076eb96ed88680dab1a1abe50a5dac7b.camel@redhat.com>
On Wed, 04 May 2022 17:11:25 +0200 Paolo Abeni wrote:
> > For testing stuff like this would it be possible to inject packets
> > with no headers pulled and frags in pages we marked read-only?
> > We can teach netdevsim to do it.
>
> We additionally need to ensure that the crafted packets are cloned,
> otherwise the current code is AFAICS fine.
Depends whether skb frags are writable, or not. Or to put it differently
why does skb_cow_data() exist and does what it does.
next prev parent reply other threads:[~2022-05-04 15:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 14:05 [PATCH net] net/sched: act_pedit: really ensure the skb is writable Paolo Abeni
2022-05-03 20:10 ` Jamal Hadi Salim
2022-05-04 8:52 ` Paolo Abeni
2022-05-04 14:47 ` Jakub Kicinski
2022-05-04 15:11 ` Paolo Abeni
2022-05-04 15:33 ` Jakub Kicinski [this message]
2022-05-05 3:04 ` Jakub Kicinski
2022-05-05 14:13 ` Paolo Abeni
-- strict thread matches above, loose matches on Subject: below --
2022-05-05 15:36 Paolo Abeni
2022-05-05 20:30 ` Mat Martineau
2022-05-06 8:39 ` Paolo Abeni
2022-05-05 17:31 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504083334.1b7a98e3@kernel.org \
--to=kuba@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.