From: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
David Hildenbrand <david@redhat.com>
Cc: Janis Schoetterl-Glausch <scgl@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [kvm-unit-tests PATCH 1/3] s390x: Fix sclp facility bit numbers
Date: Thu, 5 May 2022 14:46:54 +0200 [thread overview]
Message-ID: <20220505124656.1954092-2-scgl@linux.ibm.com> (raw)
In-Reply-To: <20220505124656.1954092-1-scgl@linux.ibm.com>
sclp_feat_check takes care of adjusting the bit numbering such that they
can be defined as they are in the documentation.
Fixes: 4dd649c8 ("lib: s390x: sclp: Extend feature probing")
Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
---
lib/s390x/sclp.h | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/lib/s390x/sclp.h b/lib/s390x/sclp.h
index fead007a..4ce2209f 100644
--- a/lib/s390x/sclp.h
+++ b/lib/s390x/sclp.h
@@ -134,13 +134,15 @@ struct sclp_facilities {
};
/* bit number within a certain byte */
-#define SCLP_FEAT_85_BIT_GSLS 7
-#define SCLP_FEAT_98_BIT_KSS 0
-#define SCLP_FEAT_116_BIT_64BSCAO 7
-#define SCLP_FEAT_116_BIT_CMMA 6
-#define SCLP_FEAT_116_BIT_ESCA 3
-#define SCLP_FEAT_117_BIT_PFMFI 6
-#define SCLP_FEAT_117_BIT_IBS 5
+#define SCLP_FEAT_80_BIT_SOP 2
+#define SCLP_FEAT_85_BIT_GSLS 0
+#define SCLP_FEAT_85_BIT_ESOP 6
+#define SCLP_FEAT_98_BIT_KSS 7
+#define SCLP_FEAT_116_BIT_64BSCAO 0
+#define SCLP_FEAT_116_BIT_CMMA 1
+#define SCLP_FEAT_116_BIT_ESCA 4
+#define SCLP_FEAT_117_BIT_PFMFI 1
+#define SCLP_FEAT_117_BIT_IBS 2
typedef struct ReadInfo {
SCCBHeader h;
--
2.33.1
next prev parent reply other threads:[~2022-05-05 12:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 12:46 [kvm-unit-tests PATCH 0/3] s390x: More storage key instruction Janis Schoetterl-Glausch
2022-05-05 12:46 ` Janis Schoetterl-Glausch [this message]
2022-05-06 15:31 ` [kvm-unit-tests PATCH 1/3] s390x: Fix sclp facility bit numbers Claudio Imbrenda
2022-05-10 17:13 ` Janosch Frank
2022-05-10 17:13 ` Janosch Frank
2022-05-11 9:48 ` Janis Schoetterl-Glausch
2022-05-05 12:46 ` [kvm-unit-tests PATCH 2/3] s390x: Test TEID values in storage key test Janis Schoetterl-Glausch
2022-05-06 15:37 ` Claudio Imbrenda
2022-05-09 13:39 ` Janis Schoetterl-Glausch
2022-05-05 12:46 ` [kvm-unit-tests PATCH 3/3] s390x: Test effect of storage keys on some more instructions Janis Schoetterl-Glausch
2022-05-06 16:52 ` Claudio Imbrenda
2022-05-09 14:07 ` Janis Schoetterl-Glausch
-- strict thread matches above, loose matches on Subject: below --
2022-05-20 19:08 [kvm-unit-tests PATCH 0/3] s390x: Rework TEID decoding and usage Janis Schoetterl-Glausch
2022-05-20 19:08 ` [kvm-unit-tests PATCH 1/3] s390x: Fix sclp facility bit numbers Janis Schoetterl-Glausch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505124656.1954092-2-scgl@linux.ibm.com \
--to=scgl@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.