From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8163C433EF for ; Thu, 5 May 2022 13:15:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0F00B83F73; Thu, 5 May 2022 15:15:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="lY3safi3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 52D3F83BF4; Thu, 5 May 2022 15:15:10 +0200 (CEST) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BF75A83FE0 for ; Thu, 5 May 2022 15:15:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id p4so3076671qtq.12 for ; Thu, 05 May 2022 06:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9It2K3YWa7TY4CICmKaZbzeq5u5jmSv9dGM8tDuh2TQ=; b=lY3safi3Pw8B9ECgch42AtbeGqjddP3weMX/zLnFzGYWduXaZxiy34U2JdP0SDWSwO Xo/45fBmlWTODKW5Z+TUIHQpSeRY91Em3ar9TU1iWaXIA2ukGJXqtrDIFHp6qJqpZNwQ rjnyAP0AlBM1CIfAzpCI2+CpUW5L8v+yiwDiw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9It2K3YWa7TY4CICmKaZbzeq5u5jmSv9dGM8tDuh2TQ=; b=abyQQpWOiFb9g9MsxiXqxbrZ+3+g726bAIzp7Tgvez/FM8xqZgkPqcmTnAmxj8qVcR KEk+uogtlsTJYsGtoTG7v63y2vNF9VMoklP6rIMNPdA2H4wZOo/REn24f+cmxnvfQQdG KPRQYfA5FPcmuxeNZxfXdiix+1FVlfRS77ewuVKf6HYsch6a6qPuyMBZ4u6qdFp96ewx hwlb70hNXKs2BLu14opdXlZvnKU0eF4H7RVJFtbMLEtC4ha+b2xR0D1mhGNAvf+Il2wR RKly+aPJ74ZgIgaHUgWEZ4+i/xSIIVnFDOzKwb4Eehk4Q4H172dMakfRu1U25EtL6BVi CoKA== X-Gm-Message-State: AOAM533ycJINY4KwrWBe8u61pztXELYne5WbAUNwNAxv2pU0SNk1AL7I yLFCvrmVxY5kZnmr9iTZsSkObA== X-Google-Smtp-Source: ABdhPJywhdHhNjsQ13pnmA+Lk5NeUOCXGu/ukeB4feq5tplOuOTmSUACLbjorAARHT+wt3RH2s0kAQ== X-Received: by 2002:a05:622a:38b:b0:2f3:a40b:bdd7 with SMTP id j11-20020a05622a038b00b002f3a40bbdd7mr18047702qtx.258.1651756503484; Thu, 05 May 2022 06:15:03 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-4500-8198-5fe8-142c-d795.res6.spectrum.com. [2603:6081:7b01:4500:8198:5fe8:142c:d795]) by smtp.gmail.com with ESMTPSA id o27-20020a05620a15db00b0069fc13ce203sm752870qkm.52.2022.05.05.06.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 06:15:02 -0700 (PDT) Date: Thu, 5 May 2022 09:15:00 -0400 From: Tom Rini To: Sean Nyekjaer , Joao Marcos Costa , Thomas Petazzoni , Miquel Raynal Cc: u-boot@lists.denx.de, Sean Nyekjaer Subject: Re: [PATCH] fs/squashfs: use do_div function for math Message-ID: <20220505131500.GF3580959@bill-the-cat> References: <20220505092637.1856223-1-sean@geanix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AH+kv8CCoFf6qPuz" Content-Disposition: inline In-Reply-To: <20220505092637.1856223-1-sean@geanix.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --AH+kv8CCoFf6qPuz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 05, 2022 at 11:26:37AM +0200, Sean Nyekjaer wrote: > From: Sean Nyekjaer >=20 > When compling for x86: > ld.bfd: fs/squashfs/sqfs.o: in function `sqfs_read': > u-boot/fs/squashfs/sqfs.c:1443: undefined reference to `__udivmoddi4' > ld.bfd: u-boot/fs/squashfs/sqfs.c:1521: undefined reference to `__udivmod= di4' >=20 > Signed-off-by: Sean Nyekjaer > --- > fs/squashfs/sqfs.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c > index 5d9c52af80..6405db4ff3 100644 > --- a/fs/squashfs/sqfs.c > +++ b/fs/squashfs/sqfs.c > @@ -8,6 +8,7 @@ > */ > =20 > #include > +#include > #include > #include > #include > @@ -1440,7 +1441,7 @@ int sqfs_read(const char *filename, void *buf, loff= _t offset, loff_t len, > } > =20 > for (j =3D 0; j < datablk_count; j++) { > - start =3D data_offset / ctxt.cur_dev->blksz; > + start =3D do_div(data_offset, ctxt.cur_dev->blksz); > table_size =3D SQFS_BLOCK_SIZE(finfo.blk_sizes[j]); > table_offset =3D data_offset - (start * ctxt.cur_dev->blksz); > n_blks =3D DIV_ROUND_UP(table_size + table_offset, > @@ -1516,7 +1517,7 @@ int sqfs_read(const char *filename, void *buf, loff= _t offset, loff_t len, > goto out; > } > =20 > - start =3D frag_entry.start / ctxt.cur_dev->blksz; > + start =3D do_div(frag_entry.start, ctxt.cur_dev->blksz); > table_size =3D SQFS_BLOCK_SIZE(frag_entry.size); > table_offset =3D frag_entry.start - (start * ctxt.cur_dev->blksz); > n_blks =3D DIV_ROUND_UP(table_size + table_offset, ctxt.cur_dev->blksz); Adding maintainers... --=20 Tom --AH+kv8CCoFf6qPuz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmJzzdQACgkQFHw5/5Y0 tyzyUgv+NR6B08+bdNt/ruMNEWIoxmscJlQBvvbYI5sM4rTOiPiR1DdEj/TO4uES 5b8II/uDtEAq50vNmBzwTpBXd/Z8HsuASGiYGWpZybLbXhzyLvsHu3PDTDttZAYB 1CuQNygRThLUFCClQoGBK1qL36ebZwsBpHcKfyjb1hlxnMbe/y40lOL3kPYVUcDJ QNLXMk8rkXhmybjlaUdC9r/E+mzzxVfCbmU3N5AMw80c7lbu+JJHSSQXsSHrV2e1 KsP45r8cvYclOU/3AxiTXr9Mqjv40ZkU2xpkRGUV9+kQSHt8MgKEhAfSW8908xhd +dJzc5yx8DIrvpr335O4SzDK/PlLhn84QjruuArQGBY2FFFFBnFPCKiBh3vZIW53 GZ1B4iS9T02NTxNSAuJTD1GGE3POaMS78wMawExKMj12kddq6IkiXwZWlz4XxQKb ugXomFHOiI3cg8V929y0NUvhSNVBf/whveqc8ilQHPZX5api2DhU6hopIcmo3SLg xTkGL0u+ =RRvA -----END PGP SIGNATURE----- --AH+kv8CCoFf6qPuz--