From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@fb.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: set dma alignment to 3
Date: Thu, 5 May 2022 15:45:34 +0200 [thread overview]
Message-ID: <20220505134533.GA13926@lst.de> (raw)
In-Reply-To: <20220504184325.1439476-1-kbusch@fb.com>
On Wed, May 04, 2022 at 11:43:25AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The nvme specification only requires qword alignment for segment
> descriptors, and the driver already guarantees that. The spec has always
> allowed user data to be dword aligned, which is what the queue's
> attribute is for, so relax the alignment requirement to that value.
>
> While we could allow byte alignment for some controllers when using
> SGLs, we still need to support PRP, and that only allows dword.
Can't we just turn it go up to eleven? ;-)
next prev parent reply other threads:[~2022-05-05 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 18:43 [PATCH] nvme: set dma alignment to 3 Keith Busch
2022-05-05 13:45 ` Christoph Hellwig [this message]
2022-05-05 16:31 ` Keith Busch
2022-05-05 14:56 ` Jonathan Derrick
2022-05-10 6:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505134533.GA13926@lst.de \
--to=hch@lst.de \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.