From: Kees Cook <keescook@chromium.org>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: Randy Dunlap <rdunlap@infradead.org>, Song Liu <song@kernel.org>,
Bixuan Cui <cuibixuan@huawei.com>,
Alexei Starovoitov <ast@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
David Vernet <void@manifault.com>,
Stephen Boyd <swboyd@chromium.org>, Jiri Olsa <jolsa@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Changbin Du <changbin.du@intel.com>,
Nathan Chancellor <nathan@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
Alex Gaynor <alex.gaynor@gmail.com>,
Wedson Almeida Filho <wedsonaf@google.com>,
Gary Guo <gary@garyguo.net>, Boqun Feng <boqun.feng@gmail.com>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v1 2/3] kallsyms: support "big" kernel symbols
Date: Thu, 5 May 2022 16:47:35 -0700 [thread overview]
Message-ID: <202205051647.B5839507@keescook> (raw)
In-Reply-To: <20220505191704.22812-3-ojeda@kernel.org>
On Thu, May 05, 2022 at 09:16:44PM +0200, Miguel Ojeda wrote:
> Rust symbols can become quite long due to namespacing introduced
> by modules, types, traits, generics, etc.
>
> Increasing to 255 is not enough in some cases, and therefore
> we need to introduce longer lengths to the symbol table.
>
> In order to avoid increasing all lengths to 2 bytes (since most
> of them are small, including many Rust ones), we use ULEB128 to
> keep smaller symbols in 1 byte, with the rest in 2 bytes.
>
> Co-developed-by: Alex Gaynor <alex.gaynor@gmail.com>
> Signed-off-by: Alex Gaynor <alex.gaynor@gmail.com>
> Co-developed-by: Wedson Almeida Filho <wedsonaf@google.com>
> Signed-off-by: Wedson Almeida Filho <wedsonaf@google.com>
> Co-developed-by: Gary Guo <gary@garyguo.net>
> Signed-off-by: Gary Guo <gary@garyguo.net>
> Co-developed-by: Boqun Feng <boqun.feng@gmail.com>
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> Co-developed-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Looks good to me.
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2022-05-05 23:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 19:16 [PATCH v1 0/3] kallsyms: Rust requirements Miguel Ojeda
2022-05-05 19:16 ` [PATCH v1 1/3] kallsyms: avoid hardcoding the buffer size Miguel Ojeda
2022-05-05 23:46 ` Kees Cook
2022-05-06 5:26 ` Miguel Ojeda
2022-05-06 11:19 ` James Bottomley
2022-05-06 12:58 ` Miguel Ojeda
2022-05-06 14:48 ` James Bottomley
2022-05-05 19:16 ` [PATCH v1 2/3] kallsyms: support "big" kernel symbols Miguel Ojeda
2022-05-05 23:47 ` Kees Cook [this message]
2022-05-05 19:16 ` [PATCH v1 3/3] kallsyms: increase maximum kernel symbol length to 512 Miguel Ojeda
2022-05-05 23:48 ` Kees Cook
2022-05-06 8:34 ` Petr Mladek
2022-05-06 9:45 ` Geert Stappers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205051647.B5839507@keescook \
--to=keescook@chromium.org \
--cc=alex.gaynor@gmail.com \
--cc=ast@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=changbin.du@intel.com \
--cc=cuibixuan@huawei.com \
--cc=gary@garyguo.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=song@kernel.org \
--cc=swboyd@chromium.org \
--cc=void@manifault.com \
--cc=wedsonaf@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.